Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp5819829ioo; Wed, 1 Jun 2022 13:17:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJy6pAC5IW8n8JESrRUP83YTogLuJtB/BHO6dZkZXjf5cu1D0ZT2cYthT9NziiRQYgSQlFtp X-Received: by 2002:a17:90b:1e47:b0:1e6:7d04:2f4 with SMTP id pi7-20020a17090b1e4700b001e67d0402f4mr1095080pjb.93.1654114635027; Wed, 01 Jun 2022 13:17:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654114635; cv=none; d=google.com; s=arc-20160816; b=bgLuAMkA1GPn4ksOMh8GJu4KgZuWnwhhv1meV/cMkrYowsbA2yQ81GEMVg9t8oVV8F 5axZTAZM+AxFfgmJSvca7YRyRfUZiqhQjZzy6FrJc1cD1tPTFAimN0FjFBEnvxmoZYym Qh++kZz3XqLH2klvgPJQdOI6SI2Cslaca0C+0WOvzx8pfTXWk8tWzRaQhNo1j6QXSlS/ Q8fb6yj+6uIYst/1UmQA2P+VRm7xwiysYOx3/e2L9mQ+AUnz/R701wfTaJWJx4mZij35 jKtzHRlNRmleKEFTp82u/ZhuHWg18DOla4nCbVbqbIOdn24Q2QY2OAeNDJtZV5Wnnppn ks8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=J3XEFiqlO85yR0rlrt+0Ucb3kcbo/uXfSzDk57v+UvI=; b=RFL89Y0MSkmMEFa6c0f2EjdLsNj0oJik01Uc/+dIHVj+PQd10BGAShSNtqs8sXEHb5 XM5Uu5fgJAyWy0NtIh4AlWuEb+j0xoCm5Yuah+uULuzSCPNHFNKP2btIgskxRONvJXkZ 4GxBTZ8yMaTPZBkHiO9jGbPpqj3WJF+LX7dM5D/+0iZv6ObzIRJdozUyjF1YKwfzm40x 9TvMOIBBC+yl/hFszfLj38z4RgQDjMkjMl6Cm7QoHI6F99vgeIGvrj+Y9J8KXdF9KbYM O4UIPyTZYVfeTsw7JATNcUeEF78gHCKjkp/uZ9KMCaBjy+KcZIKmq1t3zgqIKf9mECDj KgwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=sK08a5JR; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id q7-20020a17090ab98700b001e32a639040si7000945pjr.67.2022.06.01.13.17.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 13:17:15 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@ibm.com header.s=pp1 header.b=sK08a5JR; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=ibm.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 3DB3F2453AD; Wed, 1 Jun 2022 12:31:28 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242812AbiE3Scs (ORCPT + 99 others); Mon, 30 May 2022 14:32:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236666AbiE3Scq (ORCPT ); Mon, 30 May 2022 14:32:46 -0400 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 78A7A6A402; Mon, 30 May 2022 11:32:45 -0700 (PDT) Received: from pps.filterd (m0098414.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 24UIM0H1024517; Mon, 30 May 2022 18:29:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=message-id : date : mime-version : subject : to : cc : references : from : in-reply-to : content-type : content-transfer-encoding; s=pp1; bh=J3XEFiqlO85yR0rlrt+0Ucb3kcbo/uXfSzDk57v+UvI=; b=sK08a5JRQZv/pRZYSijJfgzCNWcnImFCMS1209YIqfs77/e2+DqGCKxKlBXdJgBmlco8 lBUxmyGoc+OLGeLWYBYYR26O3FsvegFajhqOddNqC68LJDao5jNt43AilvT83QFtIU09 ymysBZ+7yYvC1vU7jJWa8h114YLyiWf0mvxibmh4UXnXn2YZzAzo8CIdHOnqkmFzsY1r B+BMFqTlkhhhT5CMeGiBcg1sFURj8WmM61cUPcqTMXIorBEaBI5LTzeO9gIr7HvJfINf FIjGzFOAKcrEWvMA8wWWcaPvQrckVA5zWZJHRK+ah1+o9L5zMidx1M1UKYE9RYi3B87E oA== Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3gd34y82yk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 May 2022 18:29:40 +0000 Received: from m0098414.ppops.net (m0098414.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 24UIQonu010446; Mon, 30 May 2022 18:29:39 GMT Received: from ppma06fra.de.ibm.com (48.49.7a9f.ip4.static.sl-reverse.com [159.122.73.72]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3gd34y82y9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 May 2022 18:29:39 +0000 Received: from pps.filterd (ppma06fra.de.ibm.com [127.0.0.1]) by ppma06fra.de.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 24UIM2B8011304; Mon, 30 May 2022 18:29:37 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma06fra.de.ibm.com with ESMTP id 3gbcb7j9t2-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 30 May 2022 18:29:37 +0000 Received: from d06av21.portsmouth.uk.ibm.com (d06av21.portsmouth.uk.ibm.com [9.149.105.232]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 24UITYUm39059828 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 30 May 2022 18:29:34 GMT Received: from d06av21.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 12CBA5204F; Mon, 30 May 2022 18:29:34 +0000 (GMT) Received: from [9.171.42.121] (unknown [9.171.42.121]) by d06av21.portsmouth.uk.ibm.com (Postfix) with ESMTP id D9F875204E; Mon, 30 May 2022 18:29:30 +0000 (GMT) Message-ID: <58b163b1-22ec-7634-dcd3-5a0a54adec45@linux.ibm.com> Date: Mon, 30 May 2022 20:29:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: [PATCH v4] mm: Avoid unnecessary page fault retires on shared memory types Content-Language: en-US To: Peter Xu Cc: Heiko Carstens , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Will Deacon , Matt Turner , linux-s390@vger.kernel.org, Andrew Morton , Brian Cain , Borislav Petkov , linux-alpha@vger.kernel.org, Alistair Popple , Jonas Bonn , linux-arm-kernel@lists.infradead.org, linux-ia64@vger.kernel.org, Michael Ellerman , Stefan Kristiansson , linux-snps-arc@lists.infradead.org, Vineet Gupta , Vasily Gorbik , Vlastimil Babka , Ivan Kokshaysky , Rich Felker , sparclinux@vger.kernel.org, Russell King , David Hildenbrand , Benjamin Herrenschmidt , Nicholas Piggin , "James E . J . Bottomley" , linux-xtensa@linux-xtensa.org, linux-sh@vger.kernel.org, Paul Walmsley , linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, Richard Henderson , Guo Ren , linux-parisc@vger.kernel.org, Andrea Arcangeli , Helge Deller , Al Viro , Albert Ou , linux-um@lists.infradead.org, "H . Peter Anvin" , Janosch Frank , Sven Schnelle , Anton Ivanov , openrisc@lists.librecores.org, Thomas Bogendoerfer , linux-hexagon@vger.kernel.org, Andy Lutomirski , Stafford Horne , linux-csky@vger.kernel.org, Thomas Gleixner , linux-mips@vger.kernel.org, Paul Mackerras , Alexander Gordeev , Dinh Nguyen , Palmer Dabbelt , "David S . Miller" , Johannes Weiner , Hugh Dickins , Ingo Molnar , Peter Zijlstra , linux-riscv@lists.infradead.org, Max Filippov , Catalin Marinas , Geert Uytterhoeven , Johannes Berg , Chris Zankel , Michal Simek , x86@kernel.org, Yoshinori Sato , Dave Hansen , Richard Weinberger , Ingo Molnar References: <20220527193936.30678-1-peterx@redhat.com> <33fd4731-9765-d78b-bdc3-f8243c98e81f@linux.ibm.com> From: Christian Borntraeger In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Proofpoint-GUID: BcnqcIajExbqAnGujS-ZUqcYMX48oxDt X-Proofpoint-ORIG-GUID: iK5fU7K0gq48iA5OulnJebFyFFDVydua X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.874,Hydra:6.0.517,FMLib:17.11.64.514 definitions=2022-05-30_07,2022-05-30_03,2022-02-23_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 mlxscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 suspectscore=0 adultscore=0 malwarescore=0 impostorscore=0 spamscore=0 mlxlogscore=999 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2205300096 X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 30.05.22 um 18:00 schrieb Peter Xu: > On Mon, May 30, 2022 at 11:52:54AM -0400, Peter Xu wrote: >> On Mon, May 30, 2022 at 11:35:10AM +0200, Christian Borntraeger wrote: >>> >>> >>> Am 29.05.22 um 22:33 schrieb Heiko Carstens: >>> [...] >>>> >>>> Guess the patch below on top of your patch is what we want. >>>> Just for clarification: if gmap is not NULL then the process is a kvm >>>> process. So, depending on the workload, this optimization makes sense. >>>> >>>> diff --git a/arch/s390/mm/fault.c b/arch/s390/mm/fault.c >>>> index 4608cc962ecf..e1d40ca341b7 100644 >>>> --- a/arch/s390/mm/fault.c >>>> +++ b/arch/s390/mm/fault.c >>>> @@ -436,12 +436,11 @@ static inline vm_fault_t do_exception(struct pt_regs *regs, int access) >>>> /* The fault is fully completed (including releasing mmap lock) */ >>>> if (fault & VM_FAULT_COMPLETED) { >>>> - /* >>>> - * Gmap will need the mmap lock again, so retake it. TODO: >>>> - * only conditionally take the lock when CONFIG_PGSTE set. >>>> - */ >>>> - mmap_read_lock(mm); >>>> - goto out_gmap; >>>> + if (gmap) { >>>> + mmap_read_lock(mm); >>>> + goto out_gmap; >>>> + } >>>> + goto out; > > Hmm, right after I replied I found "goto out" could be problematic, since > all s390 callers of do_exception() will assume it an error condition (side > note: "goto out_gmap" contains one step to clear "fault" to 0). I'll > replace this with "return 0" instead if it looks good to both of you. > > I'll wait for a confirmation before reposting. Thanks, Yes, that sounds good and thank you for double checking.