Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
From:   Wan Jiabing <wanjiabing@vivo.com>
To:     Pavel Machek <pavel@ucw.cz>,
        Bjorn Andersson <bjorn.andersson@linaro.org>,
        Stephen Boyd <swboyd@chromium.org>,
        Marijn Suijten <marijn.suijten@somainline.org>,
        Satya Priya <quic_c_skakit@quicinc.com>,
        Wan Jiabing <wanjiabing@vivo.com>, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] leds: Add of_node_put() before return
Date:   Wed,  1 Jun 2022 15:52:03 +0800
Message-Id: <20220601075211.2117596-1-wanjiabing@vivo.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?0emmY5vg7t7qbckatmpqC8vXTtq2nFITdx5jmcBYEYZZxL508D+9Fgh1Zx97?=
 =?us-ascii?Q?b3i70CXbSTUZDu0u2sUqq6PtpnJvcrvMVjlLHWYi7dKkdmt/6U0NeyTmQGkB?=
 =?us-ascii?Q?fajUOfvbqlObPqWvz2Kl8tKvOu5MyLe28hKtznYzj8BJ89qzK8LeqP6PsURo?=
 =?us-ascii?Q?SieTzvDt+sUMz1598G+N6yN0MAEGtzdL6unyVqB7z+0kKqwWz5UbQb4R0Wsg?=
 =?us-ascii?Q?F4U11lOtijDaeR+dop11hiD3U03PPw83BWkBbeOkPLVYPPmsEjpIimzSYta/?=
 =?us-ascii?Q?gAPo7vVRZkjkzo0lOzmb+c8src2XWGnrZTAX7zFHyVt/wm8mH3GZQOLP71El?=
 =?us-ascii?Q?GPQVeqQH7c5hUOTiZSMOoZSUcf2yOb9g0CyqV3IQKzE/DHsUsWa7xbKlAcR3?=
 =?us-ascii?Q?2kcTz52lDYmbP+d3maT3NtCwqAOoh5X08c/imyX8hjuG8jcb0QAjWlqkr7Eh?=
 =?us-ascii?Q?8/UbJUjs61xUPWJ0qi4prKQnqIob0cW3Ro544Rb6whgZwUVnG8X46AyYMytD?=
 =?us-ascii?Q?1i/Jbu2wj8x8JYtSCLI9gemv9rzxbkzdMaqK+ZvaSwrv0B5WpRu8Lpm1aFPQ?=
 =?us-ascii?Q?Xl4qsaZUPxeeERL2AjcR4ftFhJ+wendJjMO0V57B5xDMrN8YpASC2LCxnCR2?=
 =?us-ascii?Q?2p0Yy7fxrbf22lhY/DSJ8YJEceslh7ELyH7TeXNaigQEIs/xcjfASnGoEkaH?=
 =?us-ascii?Q?S0BSkZMQ+MU1JlXUtJlVYseXTJO1GiKyT+bGEJCNs3UtXANPFcnMj4dEXld7?=
 =?us-ascii?Q?zOb8fTzLFPSz+Pp3uce3ZYF5UWItOKNaTosmHHyI1VJA2RrOtSqEN0ilKv5l?=
 =?us-ascii?Q?AWEg6uF7ZjX6HNiA1l7lG0ZT77bZhG8OxdDBXIxb1II/0gZ/90c/eW5unjWE?=
 =?us-ascii?Q?SJI4ac5WHsVkVKm/5EdT7cZZaMW5QU7stwPoVBp0u773Gj3g3CZHfj6nEXTT?=
 =?us-ascii?Q?35eHpYbO1iCzF0MnMuKR/yDXICcUx06Say3/HmEtGbtWA5541LTAct4YMESX?=
 =?us-ascii?Q?cZJtcLvS3xz6oC1jEb3oolfm3z++gKPUrG0qs2OdliPK4SOKuxfjowDABAYA?=
 =?us-ascii?Q?p2mZ3nVGYioVNci9xk9104gJ1U14fFJMTJHKS5jMyGJ1MuZ0CoJQJCJ4aZ2c?=
 =?us-ascii?Q?2g5zBhvV/R5AGnhRhSWNgbrvHWZ7hi/eXIvgOIySso/JE4OFVx2K/mEdAYjs?=
 =?us-ascii?Q?vIWq/JFzPrx79q3hS1ogcCQqOQX8vQFl4WUt/KNH5g5OsvJCEFmh6uHGalmn?=
 =?us-ascii?Q?ut7aBSVJagdYmQw3M3C0IqyZeFQvCcJMu4PC8AcjyqTMDFX13lIFfOUxL49R?=
 =?us-ascii?Q?2lPxEbNgJOK2EOL4rn1URzQHK9Om/lemP2hW4zXtNeaiHDOFT1LjlfIIgkVM?=
 =?us-ascii?Q?z7b3pwvH77wXmhZfnK8bVekZmwGDVn+G4Mz6KTtDcPEqh+7+kP6AQB7pOX+r?=
 =?us-ascii?Q?7xMfLbvszAX8n8K2oBdCZGbzNPdcJxzUdJCgPNZ7orRszUuzcNWF4h/Q1TsC?=
 =?us-ascii?Q?05FwdbSiFYb5ZGAOfwVfi5o+aAdsubHsiEeTkcrEhvHRfaVbdlB6OU8+uZlL?=
 =?us-ascii?Q?iQf6SoaIrMHhAiTGHPxVnzWvqrgy/hLvKgX6FZ1dBHblglYFz3g/Y3lzeoHO?=
 =?us-ascii?Q?fgQvuaXWO0DXOFH+1hiNU9uQl515sx+zeFZPyDRS76IUB0AYsL+ba6yN5mxL?=
 =?us-ascii?Q?q3QJsoNAT2crDPusDfgOR2NjQ+271R3CicDfYXUECu0oS9QuxeagEAa8pPQ4?=
 =?us-ascii?Q?E2AY36hvEw=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b6631bca-0049-405a-c9be-08da43a3b898
X-MS-Exchange-CrossTenant-AuthSource: SG2PR06MB3367.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2022 07:52:48.5378
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: c7F4AByb1ev5By3qpnlebvR8gy8tjNmQKYcDr+qldgAM1d+HCH+Bv1+hiRuuzgktPeNfsWIUT+MI+xWJBD4p0g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: TYAPR06MB2094
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE,
	SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Fix following coccicheck warning:
drivers/leds/rgb/leds-qcom-lpg.c:1107:2-34: WARNING: Function for_each_available_child_of_node should have of_node_put() before return around line 1110.
drivers/leds/rgb/leds-qcom-lpg.c:1286:1-33: WARNING: Function for_each_available_child_of_node should have of_node_put() before return around line 1289.

Early exits from for_each_available_child_of_node should decrement the
node reference counter.

Fixes: 24e2d05d1b68 ("leds: Add driver for Qualcomm LPG")
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
 drivers/leds/rgb/leds-qcom-lpg.c | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/leds/rgb/leds-qcom-lpg.c b/drivers/leds/rgb/leds-qcom-lpg.c
index 02f51cc61837..05f064543444 100644
--- a/drivers/leds/rgb/leds-qcom-lpg.c
+++ b/drivers/leds/rgb/leds-qcom-lpg.c
@@ -1106,8 +1106,10 @@ static int lpg_add_led(struct lpg *lpg, struct device_node *np)
 		i = 0;
 		for_each_available_child_of_node(np, child) {
 			ret = lpg_parse_channel(lpg, child, &led->channels[i]);
-			if (ret < 0)
+			if (ret < 0) {
+				of_node_put(child);
 				return ret;
+			}
 
 			info[i].color_index = led->channels[i]->color;
 			info[i].intensity = 0;
@@ -1285,8 +1287,10 @@ static int lpg_probe(struct platform_device *pdev)
 
 	for_each_available_child_of_node(pdev->dev.of_node, np) {
 		ret = lpg_add_led(lpg, np);
-		if (ret)
+		if (ret) {
+			of_node_put(np);
 			return ret;
+		}
 	}
 
 	for (i = 0; i < lpg->num_channels; i++)
-- 
2.36.1