Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <928114e2-05c4-3cfe-7a9e-05ae89f18807@nvidia.com>
Date:   Tue, 31 May 2022 15:43:51 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH net-next] selftests: net: fib_rule_tests: add support to
 run individual tests
Content-Language: en-US
To:     Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>,
        netdev@vger.kernel.org
Cc:     outreachy@lists.linux.dev, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220530181242.8487-1-eng.alaamohamedsoliman.am@gmail.com>
From:   Roopa Prabhu <roopa@nvidia.com>
In-Reply-To: <20220530181242.8487-1-eng.alaamohamedsoliman.am@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UnNqNGdFdlZkcDQyV25IVzJaK3p6eGRTNTlUQnd2Mm5BeDB0U2hQOEVVdVlr?=
 =?utf-8?B?K1g2N3R0cWVERTlSVjlNdm9CM0R1cmtFWk8rSkN3U0YyaEgvbndiWmlFNGFD?=
 =?utf-8?B?Nmh0ZUlNYmk0a2gvbVRjaTJiMFhmb2hHZU9wUmpiRW5ldVFUbjJXSkE5RmNN?=
 =?utf-8?B?aitUdlJ1bjVLMWR0d2RlTEpJT04zUkFOVEZVNTQxN0ZkRjcrbjNZNGJVNnhs?=
 =?utf-8?B?VG5JallYcWM5NXpzYStpTGVJbEpUVnovUVRSczYwTmNieWVFMTIyTUVIdVFH?=
 =?utf-8?B?ZlJKV2RraTYyRGlpRWtDRkNIOHNIQ1lkV01vQVJ6VHlBWXlRblVidjVSc2xq?=
 =?utf-8?B?cFlmdlMyajcybWVIQ01FQ01tOTg2Q28rUmZ4V29TY01hYTA5ME5vVVY0a1ps?=
 =?utf-8?B?NUtDdHkrUjhmYWFTRUdGTWxXZ2FWd1RqK1UrMmpueTdRNktUOFdwU21LZTZL?=
 =?utf-8?B?aFYxR1ZnZzNyUjJvZGJ5U0JuaU9ZY2VmcTFVSmtJZWRzRE1JTDI5STBTamh0?=
 =?utf-8?B?Q3kwL0FhY3BYV1BvbXI0RHJXc3E5ZmpuMzRxcGpjVk1kcS9RTldvSE9PZ0hP?=
 =?utf-8?B?V0FQblRaQ3FSSjEvcWRjM1BEdlcvSFp6U1NaNlpxZmhtVVNWcUh4dGxWcUFX?=
 =?utf-8?B?a0RIWWZCM2JVcFA1emFpOGkyL2NOWnNua0JEVGs0alM3TzE4VHZuczlJZERw?=
 =?utf-8?B?OCtScUhMR2t5alBUZG1XZ01jV3RCbkNSRWJwbU45dmNoWitzbGl0SmkwTlVU?=
 =?utf-8?B?a3lIVmpIbjF5UTJ0VG8zTzF1bGNha3NNM3ZsUmorSGExZDlwTVhhQ3NDRjh5?=
 =?utf-8?B?VzZ6MmREb1ErYWdKWTVwWFlneHVHZnVoL2lZMjZyZDE4eUFRRERveFZ0WHds?=
 =?utf-8?B?MStvTzRUZHlBZ0pramNFWWJqd2FBaktxNjk3ZWIzUForRGlPOHdHSVlrZkFq?=
 =?utf-8?B?bjk1S3N5czNYSlcxamZ5U3hzMmhrSktPeTNVUTRxUllMT01ZV1lScFhxbTBI?=
 =?utf-8?B?ZE5TanZ4RE1yU3BmM0Zuem01RW05cVZXS2Q5aG51TDJSaWV4T0xMNlNTTGZ6?=
 =?utf-8?B?Z0NSczBOSGllK0FJSmFBczUweThrT2ZDdXI5K2NSRWUrSlNlRWRWbldOK2I2?=
 =?utf-8?B?RnJ6UityYmIzOVp2TnBZNUFxamEwYTlsYkxvZ1UydDN0MllkdnpCZ293WlhJ?=
 =?utf-8?B?VDdSamZCRkpmSCtyVFV3Tld4QmhYY2N5My9iMEV0UzNFQXkvTzdhRHpvRnRQ?=
 =?utf-8?B?Sm1FTEt4RWpXRE1Jc05SbmFjTUhPckVZRkpVRW1OOFpJT1JDVXJ5ekE3NjNm?=
 =?utf-8?B?b2p2TU1HSS9paTcvUWtpNW9wcWE3TEdhK2JUUW4xV1NNQzBSTUtLbytHYU5i?=
 =?utf-8?B?TFUxdVV3YUNoSlNLK2hrMzBYYkJnYmZRNmM5dUsrbDYzbjI1UlowQUN0SWZG?=
 =?utf-8?B?ejdzZlNCeGlKVUJKSGJkUCtmcTZLSDk5bi9aaEprNVdhRGZjYTA2cXE5Vnln?=
 =?utf-8?B?V0NUMys3L1VON2hzQm11NWUvanFROEFFQ1oybktsQ0VvQnVVeEdFUXRReXJm?=
 =?utf-8?B?d3ZvQkxaTlJjUUhIWkRKajdCYmZVeHBSNk5tMUpwNCt3Rm83ZStJSTE0cTZo?=
 =?utf-8?B?U000TVlxaWxmK1FKRC9uSW9Yc2FQVE5NaVpqR212QXZHWldTazVJeXBNRFdB?=
 =?utf-8?B?eWRuR3o4VVZNc0pIOVJIOUNBTTlNL1BqeWNVSFdnR0Z0TkQyUWszQnAwNDU4?=
 =?utf-8?B?WE81ZkJ3Y3FHZndqcmJpSUI3aE5mNGovc2prV0N1RmhSTDVGUWxlT1lrRTFD?=
 =?utf-8?B?NkNubGpIWFk0NlJGdFdRa250aG1pUlExcUdGdldUS1ozUEp3NHFLQUZnSXRq?=
 =?utf-8?B?Qm5SKzhCRnEvQlZuNTR4K1NrYkJnVWwxTnZId3drREJrbFViSW42YjVwaXVR?=
 =?utf-8?B?Z0F2cWpTRjVXYVRVOFhQRWNOcWpoNnZKaEcwM3NIdjlkZjJvaEt5Z09QVUtE?=
 =?utf-8?B?K1FIbVlEV0JjMjVnNkhvQUtzMUZRN0VOQ1NQaU9BZXE0ODhkb0tQQWhuL0VM?=
 =?utf-8?B?V0xyUm84QTN0ajg0ZzRZa2kwYjg1UnhxaVo0RjhMbmhEWGExcDVveGZkR29Z?=
 =?utf-8?B?bm9xaUJFSnBwRmdsSEVDNkFHQVdPVVJOczUwM0x6U3lFaU5HS2ErY1I3cGdl?=
 =?utf-8?B?UGZ5K2lYTkJRbjBQaE1UbS9qNG1rWW1heUdtcDR6RExZMmhFV1BHSW1kWnlh?=
 =?utf-8?B?TjVOMlZRQm1oY01MeFdWRVlnb2xFT1Ntb0UwZnN1a3J1bmx6RXNUODB5azVq?=
 =?utf-8?B?ckhHbytMOVhpZWRrWmZVaDlUQ3FNaWNoQmo0eVhPb1RQVWxCbWRRQT09?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6fdab5a-b02e-4457-a3ca-08da435709cb
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR12MB5504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 22:43:53.3321
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MTgXqvs8N6WWkUMtTzG8/34Lwrg8fwDsn+VQYduv0bA+IGfAEfMqa7wU9+EJ0kgczl/CC4wPwv41A7441FFw3g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL0PR12MB4740
X-Spam-Status: No, score=-3.8 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
	DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/30/22 11:12, Alaa Mohamed wrote:
> add -t option to run individual tests in the test with -t option
>
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> ---

Alaa, I suggest you send a v2 with a fixes tag for this. This actually 
completes commit "816cda9ae531" which went in incomplete.

For examples of fixes tag, look for "Fixes" in git log. change the patch 
title to convey the fix.

rest looks good.


>   tools/testing/selftests/net/fib_rule_tests.sh | 23 +++++++++++++++++++
>   1 file changed, 23 insertions(+)
>
> diff --git a/tools/testing/selftests/net/fib_rule_tests.sh b/tools/testing/selftests/net/fib_rule_tests.sh
> index bbe3b379927a..c245476fa29d 100755
> --- a/tools/testing/selftests/net/fib_rule_tests.sh
> +++ b/tools/testing/selftests/net/fib_rule_tests.sh
> @@ -303,6 +303,29 @@ run_fibrule_tests()
>   	log_section "IPv6 fib rule"
>   	fib_rule6_test
>   }
> +################################################################################
> +# usage
> +
> +usage()
> +{
> +	cat <<EOF
> +usage: ${0##*/} OPTS
> +
> +        -t <test>   Test(s) to run (default: all)
> +                    (options: $TESTS)
> +EOF
> +}
> +
> +################################################################################
> +# main
> +
> +while getopts ":t:h" opt; do
> +	case $opt in
> +		t) TESTS=$OPTARG;;
> +		h) usage; exit 0;;
> +		*) usage; exit 1;;
> +	esac
> +done
>   
>   if [ "$(id -u)" -ne 0 ];then
>   	echo "SKIP: Need root privileges"