Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Mon, 30 May 2022 08:22:49 +0200
Message-ID: <87r14by1xi.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Marios Levogiannis <marios.levogiannis@gmail.com>
Cc:     Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
        alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda/realtek - Fix microphone noise on ASUS TUF B550M-PLUS
In-Reply-To: <20220529223524.9057-1-marios.levogiannis@gmail.com>
References: <20220529223524.9057-1-marios.levogiannis@gmail.com>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0
MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 30 May 2022 00:35:24 +0200,
Marios Levogiannis wrote:
> 
> Set microphone pins 0x18 (rear) and 0x19 (front) to VREF_50 to fix the
> microphone noise on ASUS TUF B550M-PLUS which uses the ALCS1200A codec.
> The initial value was VREF_80.
> 
> The same issue is also present on Windows using both the default Windows
> driver and all tested Realtek drivers before version 6.0.9049.1. Comparing
> Realtek driver 6.0.9049.1 (the first one without the microphone noise) to
> Realtek driver 6.0.9047.1 (the last one with the microphone noise)
> revealed that the fix is the result of setting pins 0x18 and 0x19 to
> VREF_50.
> 
> This fix may also work for other boards that have been reported to have
> the same microphone issue and use the ALC1150 and ALCS1200A codecs, since
> these codecs are similar and the fix in the Realtek driver on Windows is
> common for both. However, it is currently enabled only for ASUS TUF
> B550M-PLUS as this is the only board that could be tested.

Could you resubmit with your Signed-off-by tag?  It's mandatory.


thanks,

Takashi