Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Tue, 31 May 2022 22:11:02 +0800
From:   Hilton Chain <hako@ultrarare.space>
To:     =?UTF-8?B?Sm9zw6kgRXhww7NzaXRv?= <jose.exposito89@gmail.com>
Cc:     bryancain3@gmail.com, jikos@kernel.org,
        benjamin.tissoires@redhat.com, linux-kernel@vger.kernel.org,
        linux-input@vger.kernel.org
Subject: Re: [PATCH] HID: apple: Reset quirks when Fn key is not found
Message-ID: <20220531221102.7bd7da7d@ultrarare.space>
In-Reply-To: <20220530061812.GA10391@elementary>
References: <20220529180230.17e9a0f9@ultrarare.space>
        <20220529182036.10226-1-jose.exposito89@gmail.com>
        <20220530083752.1973a905@ultrarare.space>
        <20220530061812.GA10391@elementary>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, 30 May 2022 08:18:12 +0200 Jos=C3=A9 Exp=C3=B3sito wrote:
> That could be problematic because Apple keyboards can be renamed after
> connecting=C2=A0them to a Mac.
>
> For example, the name of my keyboard is: "Jos=C3=A9 Exp=C3=B3sito=E2=80=
=99s Keyboard".

Well, editable name. I have a bad feeling about this...

> I think it'd be safer to assume that the device is an Apple keyboard
> and create exceptions for know non-Apple keyboards  because the
> majority of the devices handled by this driver are Apple keyboards and
> because there is already a config option available (real_fnmode) to fix
> the problematic devices in the meanwhile.
>
> In my opinion, creating a function like "apple_is_non_apple_keyboard"
> (or similar) containing all the rules to identify devices from
> Keychron, GANSS, etc could do the trick. Something similar to:
>
>   if (apple_is_non_apple_keyboard(hdev)) {
>           hid_info(hdev, "Non-apple keyboard detected; function keys will=
 default to fnmode=3D2 behavior\n");
>           asc->quirks |=3D APPLE_IS_NON_APPLE;
>   }

Done. However I couldn't figure out corresponding names from other known
bug reports, so that the initial array only contains two devices.

> Unfortunately, I can't think of a generic way to detect those devices
> as they have the same vendor and product as the Apple ones :S

T^T

Stay boiled,
Chain