Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 1 Jun 2022 10:35:38 -0400
From:   Jan Harkes <jaharkes@cs.cmu.edu>
To:     Haowen Bai <baihaowen@meizu.com>
Cc:     linux-kernel@vger.kernel.org
Subject: Re: [PATCH] coda: remove unused variable
Message-ID: <20220601143538.e232rih7wndlofd7@cs.cmu.edu>
References: <1654070283-7216-1-git-send-email-baihaowen@meizu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1654070283-7216-1-git-send-email-baihaowen@meizu.com>
User-Agent: NeoMutt/20180716
Precedence: bulk

Sorry, but I cannot ack this patch.

Clearly there is a lack of clarity in this particular bit of code
because this suggestion seems to reappear every few years,

https://www.mail-archive.com/linux-kernel@vger.kernel.org/msg2269222.html

The insize variable is in fact used by the UPARG macro that follows, and
once this patch is applied you end up with an obvious compilation error.

Jan


On Wed, Jun 01, 2022 at 03:58:03PM +0800, Haowen Bai wrote:
> The variable insize is initialized but never used otherwise.
> 
> Signed-off-by: Haowen Bai <baihaowen@meizu.com>
> ---
>  fs/coda/upcall.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/coda/upcall.c b/fs/coda/upcall.c
> index 59f6cfd06f96..c214b424426d 100644
> --- a/fs/coda/upcall.c
> +++ b/fs/coda/upcall.c
> @@ -477,10 +477,9 @@ int venus_pioctl(struct super_block *sb, struct CodaFid *fid,
>  {
>          union inputArgs *inp;
>          union outputArgs *outp;  
> -	int insize, outsize, error;
> +	int outsize, error;
>  	int iocsize;
>  
> -	insize = VC_MAXMSGSIZE;
>  	UPARG(CODA_IOCTL);
>  
>          /* build packet for Venus */
> -- 
> 2.7.4
> 
>