Received: by 2002:a19:771d:0:0:0:0:0 with SMTP id s29csp1274918lfc; Wed, 1 Jun 2022 13:53:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJya0c5lWhoH8DgONK2I8TrhAA5pL09tsBbAAbUTKqK6oRzoKcJOSaPhhzpvM5bWlvqmOY+z X-Received: by 2002:a17:90b:380b:b0:1e6:67f6:c5b4 with SMTP id mq11-20020a17090b380b00b001e667f6c5b4mr3820557pjb.48.1654116788874; Wed, 01 Jun 2022 13:53:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654116788; cv=none; d=google.com; s=arc-20160816; b=yBt+aYHCPyhn05Hg/pmUrMeRgnkS5ZtZd6XWJgJOF5SbqdNXWxbihyeJrYIxvS1mrR UVfM/0Q5FxUmaYcyXI8Mb1/Cx24U2xnCfNXOpUtAOBc8uiAVemXWXTzC9VMzXLHJorfc TcPkDUkYkY+OQDQ9Rb73qpw18pYlcVepMj3Y3fLkS5BE1aFSGk1yqLsFUCGy+zy/+EKM 0HB7c2+7fGg2kKNfN3sO5QI5R2VTa+P20U8CZWCUwwgzEgO0h1MKe6sH0gbZA0O91K+q AZzKeu/Kd0gC+XHxvpODddaQtZHgsXBrc7Sw6TNClyq2/EXw/ouYXrIbec0xNpkvlIhk vk+g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Px54YeB8y4JCFlFNgwFGWbi1FoMMkCqF3KundDZ3EiM=; b=FRpGpL6Ahww00iWjS+g1sUlirDUUQ1MghISxSqQbBwbtjVV0GnKaevahmtDVpRGyDR 67BSjqGk6oTgGz7Xlbew5hAZ+ODl3ivnTfvA0bmi0jVP/kZV27FNml3RmEglyjgevXo1 OUYZhy5W1rFxl9eUVswpZY9HVnoYd0Jemm5dKb9wE+V3F1ylhbF2u3MOnxzxj9CS/1Lj ls+SqiuYo75Ifh5MpIpPLDy+Yc5H0Fx74QzfVpRwUs/aMfytgnCNUfrD5oaXOa1VRv3w GfKGS2PYeW/z7g4aHb5qyh1yEwEvqlGWaWEUS7HM7kGlNgq8fGW2I9oMeusTEaRwgPhx /6NA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=M8QTLybU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id nl3-20020a17090b384300b001e30158abf3si8767882pjb.1.2022.06.01.13.53.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 13:53:08 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=M8QTLybU; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id C59072ADF64; Wed, 1 Jun 2022 12:55:53 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230442AbiFAILh (ORCPT + 99 others); Wed, 1 Jun 2022 04:11:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33044 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348233AbiFAILd (ORCPT ); Wed, 1 Jun 2022 04:11:33 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5AFD64D01 for ; Wed, 1 Jun 2022 01:11:30 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id q18so1059378pln.12 for ; Wed, 01 Jun 2022 01:11:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Px54YeB8y4JCFlFNgwFGWbi1FoMMkCqF3KundDZ3EiM=; b=M8QTLybUaNBk1aN+aW6WTC6oMiD4gHTGH1IngOQcZXfUt6/9wkK5VwiDq6/TgBjLAi VVsj1zx/ZRNW6HwMWapL1em5dRTDFO1BdGM4XJEzdGl465emrnSipiJlkXL99sIWN7qI 9CSmCdLCdbtaS5kOdWFVaX+dXjXQFG3VInPenaz9FVnGInt6sogEJ3OUq9UKXKTUi8Tg y3iCO9U3saux5xWEPNNxjZUTr3CRhtjY9lza1ynF5mNDhIArJKqHuSDLhxPIyjv8C8Q+ tVZdl1wi9BZZSp8Cv+flw3+ENseAF/nVTGBzMznepyaQD+/Awxu8IeXC1MK+Dka/qAib EvnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Px54YeB8y4JCFlFNgwFGWbi1FoMMkCqF3KundDZ3EiM=; b=chhySVU9aN9lh2pg5/XUh1fOObXjftr6vrOvmOcwUI1o9/LBiDtiWSrAslFZFN1WAJ 1pBWJ17lcsD7V3B+O+ST+mgpYsZpNroUkTOJ9WuRSfa21qpaPHwWdob0MoFE2KnuQS4M A7NkXvukIMY+P7VBedAZH+9lwVompiab0Jz4eJwAsR0JlRylFn2axzKrnMKFn4AIGUm0 GPU3blc1/sec8hIVjXHRFB9JiLmhVoPm33c3Y9KOiJuoKGK1QR/rt2B76TGz2fN/Wi2Q mdjV33mF/u5gND3VLglcyBiM++qcXdQQTV0GIyu1h8jZOeNuAE52kl1tRETUaUp9C3Ym eYcw== X-Gm-Message-State: AOAM530+g7m54Iphmkbx5uf6ZQg1hHQwxCpqjlJ/TS7/iGfh0zs9Xt/O /Lc6rKSDwzhlb56omOE9rVs= X-Received: by 2002:a17:902:690b:b0:159:65c:9044 with SMTP id j11-20020a170902690b00b00159065c9044mr66244014plk.47.1654071090228; Wed, 01 Jun 2022 01:11:30 -0700 (PDT) Received: from localhost.localdomain ([202.120.234.246]) by smtp.googlemail.com with ESMTPSA id y1-20020a17090ad0c100b001e2f3831102sm792288pjw.17.2022.06.01.01.11.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 01:11:29 -0700 (PDT) From: Miaoqian Lin To: Hector Martin , Sven Peter , Alyssa Rosenzweig , Thomas Gleixner , Marc Zyngier , Linus Walleij , Birger Koblitz , John Crispin , Bert Vermeulen , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Miaoqian Lin Subject: [PATCH 1/6] irqchip/gic/realview: Fix refcount leak in realview_gic_of_init Date: Wed, 1 Jun 2022 12:09:25 +0400 Message-Id: <20220601080930.31005-2-linmq006@gmail.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20220601080930.31005-1-linmq006@gmail.com> References: <20220601080930.31005-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-1.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RDNS_NONE, SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org of_find_matching_node_and_match() returns a node pointer with refcount incremented, we should use of_node_put() on it when not need anymore. Add missing of_node_put() to avoid refcount leak. Fixes: 82b0a434b436 ("irqchip/gic/realview: Support more RealView DCC variants") Signed-off-by: Miaoqian Lin --- drivers/irqchip/irq-gic-realview.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/irqchip/irq-gic-realview.c b/drivers/irqchip/irq-gic-realview.c index b4c1924f0255..38fab02ffe9d 100644 --- a/drivers/irqchip/irq-gic-realview.c +++ b/drivers/irqchip/irq-gic-realview.c @@ -57,6 +57,7 @@ realview_gic_of_init(struct device_node *node, struct device_node *parent) /* The PB11MPCore GIC needs to be configured in the syscon */ map = syscon_node_to_regmap(np); + of_node_put(np); if (!IS_ERR(map)) { /* new irq mode with no DCC */ regmap_write(map, REALVIEW_SYS_LOCK_OFFSET, -- 2.25.1