Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 1 Jun 2022 16:47:07 +0200
From:   Thierry Reding <thierry.reding@gmail.com>
To:     Miaoqian Lin <linmq006@gmail.com>
Cc:     Emma Anholt <emma@anholt.net>, David Airlie <airlied@linux.ie>,
        Eric Anholt <eric@anholt.net>, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] drm/v3d/v3d_drv: Fix PM disable depth imbalance
Message-ID: <Ypd76wmrBsIgeE3O@orome>
References: <20220601122050.1822-1-linmq006@gmail.com>
 <YpdpCWW9+igsVydr@phenom.ffwll.local>
 <55d99105-8492-e020-bed6-82e52b5fc8a1@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="UFHMz0lUhc2lO5hB"
Content-Disposition: inline
In-Reply-To: <55d99105-8492-e020-bed6-82e52b5fc8a1@gmail.com>
User-Agent: Mutt/2.2.4 (c3baa83e) (2022-04-30)
Precedence: bulk


--UFHMz0lUhc2lO5hB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Wed, Jun 01, 2022 at 09:55:02PM +0800, Miaoqian Lin wrote:
> Hi, Daniel
>=20
> On 2022/6/1 21:26, Daniel Vetter wrote:
> > On Wed, Jun 01, 2022 at 04:20:50PM +0400, Miaoqian Lin wrote:
> >> The pm_runtime_enable will increase power disable depth.
> >> If the probe fails, we should use pm_runtime_disable() to balance
> >> pm_runtime_enable().
> >> Also call disable function in remove function.
> >>
> >> Fixes: 57692c94dcbe ("drm/v3d: Introduce a new DRM driver for Broadcom=
 V3D V3.x+")
> >> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> >> ---
> >> Changes in v3:
> >> - call pm_runtime_disable() in v3d_platform_drm_remove
> >> - update commit message
> >>
> >> Changes in v2
> >> - put pm_runtime_disable before dma_free_wc
> >> - rename dma_free to pm_disable
> >>
> >> v1: https://lore.kernel.org/r/20220105120442.14418-1-linmq006@gmail.com
> >> v2: https://lore.kernel.org/r/20220106124657.32737-1-linmq006@gmail.com
> > Maybe a bit late since we're at v3 already, but are there no devm_
> > functions here that would dtrt automatically?=20
>=20
> Sorry I don't see one, or we can use devm_add_action_or_reset() to add ha=
ndling
>=20
> action. something like disp_cc_sm8250_probe() in drivers/clk/qcom/dispcc-=
sm8250.c
>=20
> How do you think?

Looks like there's a devm_pm_runtime_enable() helper that does exactly
that. See commit b3636a3a2c51 ("PM: runtime: add devm_pm_runtime_enable
helper"). I haven't seen any large janitorial series yet for that, so
perhaps it's just not widely known yet.

Thierry

--UFHMz0lUhc2lO5hB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEiOrDCAFJzPfAjcif3SOs138+s6EFAmKXe+sACgkQ3SOs138+
s6G5NRAAm+7+JLpQwcbmQEA9ILZ74xJkjZz+/ZlHJU1BF/IDWqOJWT2fWdrNKS3H
JOYpuq+LENvxoU91xe3d3yXMADFU0/v97apTBB0UJbZZTD9Af5xwhGGziAIMmPdD
6ZMO5Jzq9x/udiLjEdLV1+kNt0RE40MSD/ZmrhxRnFPjrLY/AKN6rsT87BbXCd0j
w0thsxX7OtqSv1ovYD9+aEaKU4ap4ukib0dwwkkyX4pAg2p0O7D+pRk66/BDU4Nd
3iQ3NcuwOQj5ErJ2QysygElOHzk+lhJG4BkLI3IJwFrSqFWNRjrZ1TpHlo2Nt2xO
grlAni/O8erj+EnHk1VabGGmdAEGxtL4dUZmxpZV8w7VQz5ehh/OTpl0JEUJIOCp
U9bAQCqz/9D/xE906HQj2yyCYK0lofORQ8PgASntx4uvte7CD2SorS+9Tp0L//Wd
TlmzW+idcF8/ELfHvhRfyhp/DqGuUh4UI946qmEqEYkW/YWAMXgYm1h4jGwY/HCn
ATw3HDq8IzOuKkBji3ClrsFPw7F8kFSgi5ysouAUeMAz1itZX67TQSPhrw1VporY
zTatyEfZo5aesC5d+E6/d0IdvgidiPVdTDn5mOLL1ceme5umt9zX0Fg5+Avq0M4o
MPnGHIgZR8U72nAqdWQq/c7BsgFJm7SGgIGUIIOmViOn3FN0IVk=
=5P+q
-----END PGP SIGNATURE-----

--UFHMz0lUhc2lO5hB--