Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <50fc0322-78b2-061a-46f1-dc13e4ec7184@oracle.com>
Date:   Tue, 31 May 2022 13:27:24 -0400
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.1
Subject: Re: [PATCH] xen: replace xen_remap() with memremap()
Content-Language: en-US
To:     Juergen Gross <jgross@suse.com>, xen-devel@lists.xenproject.org,
        x86@kernel.org, linux-kernel@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org
Cc:     Stefano Stabellini <sstabellini@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Dave Hansen <dave.hansen@linux.intel.com>,
        "H. Peter Anvin" <hpa@zytor.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Jiri Slaby <jirislaby@kernel.org>,
        kernel test robot <lkp@intel.com>
References: <20220530082634.6339-1-jgross@suse.com>
From:   Boris Ostrovsky <boris.ostrovsky@oracle.com>
In-Reply-To: <20220530082634.6339-1-jgross@suse.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cVViZDVXeGV2V0hnUTM1d1pua1Y1WWgyQXBnU2RCa2J6Y0dHY1F1Q3ZtUjN0?=
 =?utf-8?B?UC9uM2hiT0gxUmt4UHNCOWFJbjh5dDA5SUZ4MmJHQVg3amhHcVgzcTdjQ2p1?=
 =?utf-8?B?ZWV1OERORk8yS3M2ZE5NOEpWYW94Z3lIY1paTXJDK2RhalFNV3hHU2xETzNp?=
 =?utf-8?B?ekkrNDlNcnc5Vk1nTUM5VWhnRk1rT28zOVdCcFk1djlPYXZERUVYODE4OWxD?=
 =?utf-8?B?R3IybmJORHBHZFZZMjR2bmZkNXBnMkhnem5pTHhUVDdkbU5KMFJQRTBwR1Jm?=
 =?utf-8?B?ejVyc01tMXliWXhnUk93d1AvQm9RdEZoWlhEN0VHU2ZIK1MxajQxVzRDREMy?=
 =?utf-8?B?MTE2Q2hnZWErRkUzL09UTktNd1ZzK2wrclNvK2dnTWVmS3BmODJuSmVXSmQ3?=
 =?utf-8?B?N052dm1xTlBobVAwaFRpQVR3emdSeUNyaVEyaS9RYjdDODdzWGVua3lEWVNs?=
 =?utf-8?B?bHo4SmphNkZVdnVCRkhtNEQzYzBTSFNzam5uMWdzcHBRMEQzTkViVGcya3dH?=
 =?utf-8?B?ajYrMG9pbHRlZjI1bkk2bm13TkZES1F0a2hYbDdHdmFBSUh0b0kvdklta2NP?=
 =?utf-8?B?UEFSb0dZcFYvRFRRNFRjY25KZ1JRalpHeGN5VjZ6cTRob0o2cXVRVHcrNXFx?=
 =?utf-8?B?aUFIcnpGWWZkYXZ1amhnQWJFN1RwNzh5MGdUbVJlZjVqSGVjVjBDN1ZjeFJX?=
 =?utf-8?B?STdNeDExRmdWZUxWU2pWanlMMjd4dnRpZ1UycW9mNkEyMnZlRTgvNU83T1kw?=
 =?utf-8?B?endkaG4rb3lVQVl6blpXR09nQlcvbG9idDNqUElyZjRoSzQ3a2JZYkMyWkZ5?=
 =?utf-8?B?cU1oRXYxUm53Nnd2dHViRk1KaDVTZ0d1VElqbkF5anpLWW9oL3pYcDhERGk5?=
 =?utf-8?B?Z1RUUmR6RXY0Y1grWTdBOVVOeDc0bnl4eFgxSDBRUGdOTzBCSUpGT0kxN1cv?=
 =?utf-8?B?NWhxUmFIL0t2OGZBSmF5VFIrOWFDZmhzY3ZHZVVVT1RyWi8rdENCWFdQT1Zr?=
 =?utf-8?B?eHdlT0RVWDlxdzNNVk4wRG5HcGU5dkhjMVMrWTFScGFSUlZsc05SQzV2RkZL?=
 =?utf-8?B?VStNdGcrczlmenlFZVcwTXRDeXo0Z1p0UVp2THB0NThvWVFyS2IrZ1BFajE5?=
 =?utf-8?B?NkNBVldzaFpNeXJHNUkzNUx3dzhabEVwQml0ZFFHR2VTQXloRktOUDQvUmp5?=
 =?utf-8?B?Z3FnOC9qSjRjVzF5ck4yYThDKzBIWnMrZ09OaTIrYjZyd016bTRtVjhwU0d3?=
 =?utf-8?B?cTFHK2NnR1AvcTQveDgzTjFLZHdRVVhNNkE3TTRtU0wrZFFVVVFjdG8va1ph?=
 =?utf-8?B?R1ZtVzhCelBQb1FmOWx4WVYwWVB0aDNaR0Zaa1FMd2NwbW9pTlorQjRER1I2?=
 =?utf-8?B?QWFtM1ZDdnJ0Vm9Bd21GdFVzY0pyZEExZE1DYzg1UnRnc01UY1BBTVNnTXYy?=
 =?utf-8?B?SFV2MmlpRk80YXZlSEdGVVQ2K016Y2JlVXhBd2dmVU96WDZTRXVMNnRBZFRC?=
 =?utf-8?B?blhaTC94Uk5sMDZHOTF6eUhteFBWb1dwRzcyUlczZFBGVkl4ZFJOVzNHRWZ0?=
 =?utf-8?B?K1puQjFNOG9zRUl4TStHZ2N3bVM2SVBRWUxvMnB3eUlIMFJ1bGlVU0xobkNn?=
 =?utf-8?B?Si9ZWmxMWXcvVnR4WkpxUlo4MmtvMjdKYkg5Y01oKzJkOVZMZDRZc3MxWkt6?=
 =?utf-8?B?R3FSR2tMZWZqWXZBTnJtU3dKazNKakZQeHpWREN3b1QxVThGeFRYako2WVF4?=
 =?utf-8?B?aTZIcFdXcFNOM3NxYzlCTUQ4ZGRZbkJPeHlzOG1ic2hUVldqN1Z6Z1QzWWZB?=
 =?utf-8?B?VkhNaWNpMjJYa1NKN3Y0QnpFVGN0RnU3c2ZBRGZnRjY3Umxxam5zSk9xazI5?=
 =?utf-8?B?dmM2d29Ga3dxOUpocnpmWWZWckVSMFhobUVycnE2Y1ArZEtkbk1NMGZwSzFi?=
 =?utf-8?B?TFMwZzI1WUJXSHZidkFydjJiMitrUGd6dm9jUDR5L0xBTWRrQUtUaVlNeEp1?=
 =?utf-8?B?bU9weDN1N3dvRWw5T2hCbWhRR1hMNmxPU1gvVGt3SzlRUlR6UHI3SnhTdUlK?=
 =?utf-8?B?dURRVlYvZHhvaVpzT2RvR1dHa2Fuajk0K2EyYkFTMElKM0NoS2VUelcrcTh6?=
 =?utf-8?B?VzZvc093OXdxeWV5RytycXVTSXBjOVpPazgralNkeFoxTUtnSHFvU2ZTLzRs?=
 =?utf-8?B?RWxJbTFDank5MlZTN055WHhjS1B1OXhqTDQwdWJDVHp1Q25hQStOOGFPcTFu?=
 =?utf-8?B?M21aSkZKRy9yNGxrNWpoSGVYc1oydmwzMjRmblprZEFZWGRqOXl3QlhmaEdy?=
 =?utf-8?B?ZE16d3g0WVIwYkY5R0pEUWMxQm82eno5d21zZlJReFhidDZwM1loajdpWnpX?=
 =?utf-8?Q?aCtzrj0FpMYXF/1o=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c6b0b92d-1547-4047-9ccb-08da432ae080
X-MS-Exchange-CrossTenant-AuthSource: BLAPR10MB5009.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 May 2022 17:27:46.1496
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: FToyA8KUwIaDrUS7VVEJR8cAydo/ABLKvjST829zwOfNIiuslBxfHREgJ0dnmhhh0hb3iSczgFzOKsLuTagzg1WIXEaSQGn5rYntu4MFEgo=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY4PR10MB1846
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-05-31_07:2022-05-30,2022-05-31 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 adultscore=0 mlxscore=0 phishscore=0
 suspectscore=0 mlxlogscore=999 bulkscore=0 spamscore=0 malwarescore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000
 definitions=main-2205310081
X-Proofpoint-ORIG-GUID: 1OduQthX29qWivf9uxvq95tNT4ajXpIS
X-Proofpoint-GUID: 1OduQthX29qWivf9uxvq95tNT4ajXpIS
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 5/30/22 4:26 AM, Juergen Gross wrote:
> xen_remap() is used to establish mappings for frames not under direct
> control of the kernel: for Xenstore and console ring pages, and for
> grant pages of non-PV guests.
>
> Today xen_remap() is defined to use ioremap() on x86 (doing uncached
> mappings), and ioremap_cache() on Arm (doing cached mappings).
>
> Uncached mappings for those use cases are bad for performance, so they
> should be avoided if possible. As all use cases of xen_remap() don't
> require uncached mappings (the mapped area is always physical RAM),
> a mapping using the standard WB cache mode is fine.
>
> As sparse is flagging some of the xen_remap() use cases to be not
> appropriate for iomem(), as the result is not annotated with the
> __iomem modifier, eliminate xen_remap() completely and replace all
> use cases with memremap() specifying the MEMREMAP_WB caching mode.
>
> xen_unmap() can be replaced with memunmap().
>
> Reported-by: kernel test robot <lkp@intel.com>
> Signed-off-by: Juergen Gross <jgross@suse.com>


Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>