Received: by 2002:a19:771d:0:0:0:0:0 with SMTP id s29csp1277803lfc; Wed, 1 Jun 2022 13:59:29 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyf/xSfdfT40aszC4OS5eCXXnm0OZ4ZuSUxTVoMz2SHiL9tDeyrU7SkEua7JuvP/+wTRncB X-Received: by 2002:a05:6a00:1acb:b0:518:986c:a7c4 with SMTP id f11-20020a056a001acb00b00518986ca7c4mr1481791pfv.2.1654117169187; Wed, 01 Jun 2022 13:59:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654117169; cv=none; d=google.com; s=arc-20160816; b=Kw7yxhdCt34r9DLV46VJFABAX0BsrEowVH7WQjxHKrU1pr7e9t5nsD9LSoRsF8RvRC TKhAnpuulxKpBtEVhfMbDc2JWmJYZi6zrbWUWGqXODc/IjBJ8mvbED8ZzqQ3wIMfESY0 XZlqj5v35G07REUnTiK0DuVQiXRbV6XtqjdQNjnLtb9ziygOJ2tSjVy2+N1zsROHSwF/ SY3VlbD9liDSEYk+wuGjyHsdXiUJNFChttJo8+jrNUdZwWB1N7uDCzI+KrWUFr6IUN27 MXpUpaVLVonblf5WcR7SkVJ6o71GDuz6Sv8pHo2uD6XIuzo18ZXu6wrN5QgK94ZeSl8h lLsg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:sender:dkim-signature; bh=p/oEfQcvC4y8mbzff9uEi91rnRRVUl2cW2LAWQsIYNE=; b=aZCYyqKaCQTK9b6f7ffHtcFqb88m5ZjPBlwGS1C/vFPCKT8ZGWGetmLrMsV+vPYwTV eoZkzVslHVw+2zlIENY9nSrbTVs/kD389iMeQNvTtfNpz6vj8RiYzucdBFSGdCez/C2+ tQgubV7E9Z/iM6iMmdgQ+Ic+dp+hlBNu+euy/pQUoz8NmdSdL9bJMbp5ousAeaKO2uFW ZJVM097xJR6EJrjmtiG+23ktDfcR4X05n3+19wS8K9Ld89uu3NQYPY1ZuiCWOLO+mdmM VZF4glE+IMyV6OFUbGHoK5zdGs6qt7stig6ZJfsU0pjDWgkYLZJo7/UaqQsN8Iih7OpY yGKg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=fZwluBYE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id c11-20020a056a000acb00b0051b2c6fe811si3716472pfl.90.2022.06.01.13.59.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 13:59:29 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=fZwluBYE; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 9555F15BAC4; Wed, 1 Jun 2022 13:01:57 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1346466AbiEaRRD (ORCPT + 99 others); Tue, 31 May 2022 13:17:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51850 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242650AbiEaRRC (ORCPT ); Tue, 31 May 2022 13:17:02 -0400 Received: from mail-ot1-x329.google.com (mail-ot1-x329.google.com [IPv6:2607:f8b0:4864:20::329]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB73F10FC9 for ; Tue, 31 May 2022 10:17:01 -0700 (PDT) Received: by mail-ot1-x329.google.com with SMTP id 61-20020a9d0bc3000000b0060b9bfcfe76so2612028oth.9 for ; Tue, 31 May 2022 10:17:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=p/oEfQcvC4y8mbzff9uEi91rnRRVUl2cW2LAWQsIYNE=; b=fZwluBYEsdK3ua48/g8/ZChC0JNS/Fcer/NXU7xb4xHNzAta8PD8F2U1e98Ngva2oF TY29/D0cMb4tlYMr01HnlxS+mXLzE7Vdr8FlCIqEwnHIBPpXlNNWDG+epPbP0rRtps7I dvI5RRafkmqXJaWHxIxKFUc/8KScC1a2pEMpiCHluLnmrjehwrqmKEgz9e+qSGF3undM GDP/Sd11QDMXX6D7JEqXAvbXa3BFGUecwYX/lQ9S0su3CTRRTTtWRdeL5uegmkwEPOT9 i04VjpDr3A82Pon3rpzm4ns/RCYYat6s0LkWdtgGTPhEgqgmPMSnDyeHgs4JxSl22isP DrOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:message-id:date:mime-version:user-agent :subject:content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=p/oEfQcvC4y8mbzff9uEi91rnRRVUl2cW2LAWQsIYNE=; b=C1o4b7hml6Fhk5g6a96QKa02aL9oO8bUJcajfE90bARFYy5oMyEeonmWCW5vjkll66 X23PnUWinZInySqQ6o+mxtFsID6ZT0y5oRatGVm7cp/Ulr/MF/Oz2s+HzRhtk8A/Ft1t DIIr//PU9UXnMFoWxWpvovtTG6oroORkS99pZN0UXUf5H76sq6u4TsuDC8sxJv0w5t2P 1wFhbXfb0EVZfzZ8ZVvRd9/Eq6qZTzNvqIpfkFMPwjLSJQ+nDaZe0Di4JoqEhfUYDTHV JdnX+gTBFEr3FiMuuOFF9NFDTYtW04KG0XELj0U3lPTteheIzNm+r1tJ99U70gJ/H94o VArw== X-Gm-Message-State: AOAM530WuqKeUF2WU0Y9HpxuVK9gcmx9mCeEMcpe3xdJriYZEMaUphDJ BU6aU+R73awVuQo10YBbt2/EfobTCAA= X-Received: by 2002:a05:6830:348e:b0:60b:f4b:c306 with SMTP id c14-20020a056830348e00b0060b0f4bc306mr16910221otu.297.1654017421098; Tue, 31 May 2022 10:17:01 -0700 (PDT) Received: from ?IPV6:2603:8090:2005:39b3::100e? (2603-8090-2005-39b3-0000-0000-0000-100e.res6.spectrum.com. [2603:8090:2005:39b3::100e]) by smtp.gmail.com with ESMTPSA id v1-20020a056830090100b00605fd407259sm6438194ott.3.2022.05.31.10.16.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 May 2022 10:17:00 -0700 (PDT) Sender: Larry Finger Message-ID: Date: Tue, 31 May 2022 12:16:58 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Subject: Re: [PATCH v3 0/2] Fix some compile warnings in v5.18+ Content-Language: en-US To: Phillip Potter Cc: gregkh@linuxfoundation.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Dan Carpenter References: <20220531013103.2175-1-Larry.Finger@lwfinger.net> From: Larry Finger In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/31/22 01:40, Phillip Potter wrote: > > Hi Larry, > > Both patches look good to me, however I've already submitted a patch 10 > days ago that does exactly what your rtw_xmit.c patch does, in > addition to fixing the changed error handling semantics for the relevant > function (in f94b47c6bde6) which broke the driver. Phil, Sorry I missed your patch. I have been really busy the past month on another problem, and I was not paying much attention to r8188eu. When I built a mainline kernel in the middle of the merge from 5.18 to 5.19, those two warnings stood out. Your patch should be ahead of mine in Greg's queue, thus mine should fail, and I will get the "does not apply" message. At that time, I will send the other patch. As both of us missed the 5.19 merge, the build warnings will persist until 5.20, but no harm. Larry