Received: by 2002:a19:771d:0:0:0:0:0 with SMTP id s29csp1281548lfc; Wed, 1 Jun 2022 14:06:27 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwLVZ6KA7fesjpIZaIvDE19H5zVELM5N0EdfU9xP/edEVfZ9WmTfuX5UQ8MCmH/YR8xIga7 X-Received: by 2002:a17:903:288:b0:15f:4cc6:3195 with SMTP id j8-20020a170903028800b0015f4cc63195mr1320839plr.45.1654117586839; Wed, 01 Jun 2022 14:06:26 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654117586; cv=none; d=google.com; s=arc-20160816; b=wTsoGvoTEb97Vy25FC7epYSDdplwiMU3LiTwaQrcT1l0prIYGb8JYAUrpJ35il6qB1 NznMBOD2nu0uKE1eS9u9Jfb/J2YEeJ8jYS6soe0JqJcKy+wIAtoCT8qwxIYHs3KAJiQK Sg+qkHPR+QTJQxiQQWSY6vXwtAi1CO8Hc0lsI3kVCCFxTxyYgreq+19j7VK25FXKQBZO spG7weh+CzDfRGaOg9AklNnAK75NVtg1MdFaKThoJC5giirmrr0xXyCQu0gGbkFHIxhN UAVSYsV8RunJTzDGnsR0YXrpl8aOQN5I/Tf1gEgGJkDsBvdU7aLzaqJ8zuuqS07A/02f hg2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=S5HbQ4GeNXkSwKapXKaJFJEkoNQznjwpv1TzB8wY/Ks=; b=M1EW3HXvKIcYLhDe7xjrkgqHf81/G6cOY1KrKD5Hn62y3DimGFdVEkzp5E5CvzW/PD P0Bu4PDen6KjDYbHZS7ESNFw+0cX+U1DSW1JNqsfs8uyekGzt/q/lAJ5R8lZjaoMvC/E B6ZeZva+JZ48kXLMFAyE84CbcWx2LnOxSyG42L2Fv7kfXpsMZl9/zBcsLxRuP6RBshav nbYi687HPj5zAoQ1kSdxh3/b0g2dapQF3LH93P4TSipgcuCHWOMwKFC3++j7FoCxg6YS 7wUvY2LRQNBDyO/zpkZHSk9EVAHGfydb8I8jUXEohl0fGDTlDF7sC3S43G03RU6s6nck 01wA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cw6Cl91t; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [23.128.96.19]) by mx.google.com with ESMTPS id l38-20020a635b66000000b003fc38fd3ba2si4252792pgm.193.2022.06.01.14.06.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 14:06:26 -0700 (PDT) Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cw6Cl91t; spf=softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 6EFCD2FB437; Wed, 1 Jun 2022 13:13:53 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244348AbiEaQ5V (ORCPT + 99 others); Tue, 31 May 2022 12:57:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232657AbiEaQ5T (ORCPT ); Tue, 31 May 2022 12:57:19 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 33F091D338 for ; Tue, 31 May 2022 09:57:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BE29060DFD for ; Tue, 31 May 2022 16:57:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 51BE0C34114; Tue, 31 May 2022 16:57:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654016237; bh=OAsO/LDcILzsEYb7Ai+a+cFkwhmI78SSd8v+OAbhhmE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cw6Cl91tM514+EB8xrik4iPkzjJgRrMM1pZnMZo55VT8zieiuYdS66MhIrmbBp9Jm XODXUoxP068OSfkzpTu8v9a6/DL6imlDZ6pwnUVUMQkaSQYcN4mnLj8lTOXdRvSxBr bhKt5PZddhw1LkFrsWtcHWxtzzIAYxZ/BQRrTreRFXnK7aJdYIUIR1ITugUWJhM3QS OtesMoaNRwMPuVS73YThb5ZAzhlBuBtIt7BYTrh2zJjdF9Q52mpTLU+nvoOav0rLQf HqXkQ5gNqshdEX3zIEqCIlHw6xTLNrdEecGsH93r4aoaUlyLk18peKdzTJxDHfA3cq EYFAj7IKjzfmw== Date: Tue, 31 May 2022 17:57:11 +0100 From: Will Deacon To: Qian Cai Cc: Marc Zyngier , James Morse , Alexandru Elisei , Suzuki K Poulose , Catalin Marinas , linux-arm-kernel@lists.infradead.org, kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: arm64: Fix memory leaks from stage2 pagetable Message-ID: <20220531165710.GB25631@willie-the-truck> References: <20220526203956.143873-1-quic_qiancai@quicinc.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220526203956.143873-1-quic_qiancai@quicinc.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 26, 2022 at 04:39:56PM -0400, Qian Cai wrote: > Running some SR-IOV workloads could trigger some leak reports from > kmemleak. > > unreferenced object 0xffff080243cef500 (size 128): > comm "qemu-system-aar", pid 179935, jiffies 4298359506 (age 1629.732s) > hex dump (first 32 bytes): > 28 00 00 00 01 00 00 00 00 e0 4c 52 03 08 ff ff (.........LR.... > e0 af a4 7f 7c d1 ff ff a8 3c b3 08 00 80 ff ff ....|....<...... > backtrace: > kmem_cache_alloc_trace > kvm_init_stage2_mmu Hmm, I can't spot a 128-byte allocation in here so this is pretty cryptic. I don't really like the idea of papering over the report; we'd be better off trying to reproduce it. Will