Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
MIME-Version: 1.0
References: <CGME20220531064348epcas2p2168f11ba49e9a119219bebe18a769dff@epcas2p2.samsung.com>
 <20220531064346.51677-1-chanho61.park@samsung.com>
In-Reply-To: <20220531064346.51677-1-chanho61.park@samsung.com>
From:   Arnd Bergmann <arnd@arndb.de>
Date:   Tue, 31 May 2022 13:25:56 +0200
Message-ID: <CAK8P3a3nknJgEDESGdJH91jMj6R_xydFqWASd8r5BbesdvMBgA@mail.gmail.com>
Subject: Re: [PATCH] linux/time32.h: correct ns_to_kernel_old_timeval prototype
To:     Chanho Park <chanho61.park@samsung.com>
Cc:     Arnd Bergmann <arnd@arndb.de>, John Stultz <jstultz@google.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Stephen Boyd <sboyd@kernel.org>, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Tue, May 31, 2022 at 8:43 AM Chanho Park <chanho61.park@samsung.com> wrote:
>
> The function argument is defined with const identifier in
> kernel/time/time.c but the prototype looks different between time.c and
> time32.h. There is a review[1] why it was omitted during review stage but
> they should be matched.

Thanks for report and the patch!

Since the 'const' keyword is still useless here, I would suggest
instead dropping
it from the function definition where I accidentally left it, and from the
related ns_to_timespec64() as well, both its declaration and definition.

       Arnd