Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 1 Jun 2022 09:50:39 +0200
From:   Mark Brown <broonie@kernel.org>
To:     Catalin Marinas <catalin.marinas@arm.com>
Cc:     kernel test robot <lkp@intel.com>, kbuild-all@lists.01.org,
        linux-kernel@vger.kernel.org
Subject: Re: arch/arm64/kernel/fpsimd.c:1944:55: sparse: sparse: dereference
 of noderef expression
Message-ID: <YpcaTwI4SvV3IrwF@sirena.org.uk>
References: <202205280635.XKlMkfKD-lkp@intel.com>
 <YpZJBoxqvaCLRQfX@arm.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="IO56PR2s3EuDY7aL"
Content-Disposition: inline
In-Reply-To: <YpZJBoxqvaCLRQfX@arm.com>
Precedence: bulk


--IO56PR2s3EuDY7aL
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, May 31, 2022 at 05:57:42PM +0100, Catalin Marinas wrote:

> This looks wrong indeed. IIUC, something like below but waiting for Mark
> to confirm:
>=20
> diff --git a/arch/arm64/kernel/fpsimd.c b/arch/arm64/kernel/fpsimd.c
> index 819979398127..ac521b3403d6 100644
> --- a/arch/arm64/kernel/fpsimd.c
> +++ b/arch/arm64/kernel/fpsimd.c
> @@ -1965,7 +1965,7 @@ void __efi_fpsimd_end(void)
>  							   0,
>  							   SVCR_SM_MASK);
>  					if (!system_supports_fa64())
> -						ffr =3D efi_sm_state;
> +						ffr =3D false;

Yes, that looks right - feel free to add my Reviewed-by or I'll
do that when I see the patch sent properly.

--IO56PR2s3EuDY7aL
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmKXGk8ACgkQJNaLcl1U
h9BhUAf9FRg75H4oV4i/BwM7cGHEToFEzf56u9rqFEdInDw0ljrQDX7aLerEwY+A
bpZY2Vd3KKkb+wPDi9vlIYTCAyhPzbEW7V5Lui4BTk22XxP+soTvYVKOn1N6zSbs
XQr6JzHq3iN3yJRGtTO84kjIRvHqnr15gnJCJJxdNOndSqUWAIJChs2mpQbuvKSg
/UKDHv5Dv1Bp6vSjrK7ftVd24QVT8uIOteXEKwwNCGnCMXq5pIitboYcju7aKEv8
PHsDO+mbqg1FV5Vs69h+D6S4W1+yhDBqZXgNZBlw8Gos5HwkGM/TgLwpMtcqdP40
Ukm2Y6aY0UUHBWIfTmvjqOFK2AWJag==
=uyNY
-----END PGP SIGNATURE-----

--IO56PR2s3EuDY7aL--