Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <e49b3faa-cdac-3e57-4a7f-be2a899ec2af@suse.com>
Date:   Mon, 30 May 2022 09:39:10 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.0
Subject: Re: [PATCH] drivers: scsi: Directly use ida_alloc()/free()
Content-Language: en-US
To:     keliu <liuke94@huawei.com>, jejb@linux.ibm.com,
        martin.petersen@oracle.com, cleech@redhat.com,
        michael.christie@oracle.com, linux-scsi@vger.kernel.org,
        linux-kernel@vger.kernel.org, open-iscsi@googlegroups.com
References: <20220527083049.2552526-1-liuke94@huawei.com>
From:   Lee Duncan <lduncan@suse.com>
In-Reply-To: <20220527083049.2552526-1-liuke94@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tzk5WUZFUWdlSmNad3VabHpJUWIrdWx4OEw5RCsyYTlEZTU2ZG9qTzlVSmdT?=
 =?utf-8?B?dHRhbXRic0s0WHIwRnhKQ0pSTFdwemxON2REZVFpZmtQNUtNSXhVR0g5dGJD?=
 =?utf-8?B?S2YvWWsvZmJNd0kzQTNBaE4yYWI1QVBHMTBmS0FCd2tlRk1iak82aWs0UnlH?=
 =?utf-8?B?QVdNdk15ZCtabndsRzBnRkpsaXBaUXZ1V3BOSElILy9mWFg5VzkrK1hsc3ow?=
 =?utf-8?B?OWdGUDdqdUFLOHVmTXkybmVaaDBjWW9hRXBLRE1lM1FIMkVUbjFtMGlQU2dX?=
 =?utf-8?B?WWRQdlA4OVJiM0ErRTN4ZWlKVTF2T1duUFkrUEI2OEw0ZVRkK2Y1Nk5hVEpx?=
 =?utf-8?B?Q1UwRkg1eTgxTWE5RG9mVVV6eTNueXAzcGtZUjFzMDErK3JkOEhzUE5rMExG?=
 =?utf-8?B?bGZXbHRHL0JNRFR4bFpDZjBLY2U0ZGRPaGpzMDd2cEpOWmpUSlk3U3JaVzhm?=
 =?utf-8?B?dm1TbXp5L2JQYzNPay9UU2RhSWcxNkZhWlNvT1hqbnlqNWdDaDU0UjhiSkJ6?=
 =?utf-8?B?TEMydnBtb0tjeWJRRWFMYTZ6REJXcU9jUVBiTjF2QW1jME92cTZiR1Radmtq?=
 =?utf-8?B?R0txbmZWbjN3dmY1RkE1ek42bmRBa1kyRFV6a21sTnk5RkkxTVZXRkNKMUVm?=
 =?utf-8?B?bXFtcUw2R0pRT1VHeTlrTHYvckd1b0RKZ2hiQjR5MmRlaFRmcEYxM2dyczJk?=
 =?utf-8?B?VXZXTVJ3akdzQVNkVEM1TFRRV2hZeEpsVmdlbGhEejVFYnE3R2Q5cmk5c1hZ?=
 =?utf-8?B?U3ZNTTdhb1JDek15N0dmSTEzL2dhb05jcTZwNlI2bm1SMFVGOVdzejlwV3da?=
 =?utf-8?B?MjBoa0UzeFFWakJtb1RONzliWTNYRDUweGNxSU9PZHpNRml4MkNyR25Kemlz?=
 =?utf-8?B?TlpURUN2SENxZHBZMnBzNmtKQk5jOVcwWjZ5cERQWVBNQXlaSHhveUVMZW10?=
 =?utf-8?B?UVBkT2lRSWY0QkZwOTFhTnNVVEthZkF0WUY1WVdNSjZTNnFZZE04dU5DVEYw?=
 =?utf-8?B?SWlibjh5cFpKZC9wT2ladTR1SjFMVTk4SW94d0phc3o4ZXI0Z2l2UVprSWtR?=
 =?utf-8?B?b2dDVXYxZk1MYlg5MlNRcUI2TU9RdW9pNkJMSldnQmxjVjVBTzBFdTFRZVVO?=
 =?utf-8?B?S3NRTkJ0MWVkRGJza3d3azllbmE5bERQcjlxQkx6ZWF3aTdQdDJ3Wkx6alhF?=
 =?utf-8?B?K2lsdW96ZlhFb3N3RDFBVTM4N3dUaGNkdHFmYjg2U3EvSWZ0K0FuUFlBclFN?=
 =?utf-8?B?YnBFdjFyeVhOLyt1cm16RmxCSGMwR1lvUmc0OGYzcHl3Wm12anBWdDlWU0JF?=
 =?utf-8?B?VS9lOHFMemxWSExJb2JrdllwTk1GV0dJT0M2ZllWVlBVUzdmRklDY2Y1cWtW?=
 =?utf-8?B?SnNPRFJ3ZmlIamdaL1dvSHRqOVpVRUpXeWpQMWNRMkUwWEVXTFJ5eFRnUERV?=
 =?utf-8?B?azRGazFZUUlZOVRDckdtaVVKQmNOc0ppcWJCT09vemZPZ09ZeUdwRTdseXZ0?=
 =?utf-8?B?TnQ5UzV3V1M3c3RPbVVOeFRUYWJsZ1Z0Z2g5K0tjYlNEMXYyL3Q3Q1hxUWhn?=
 =?utf-8?B?K2c2d1dTWklaTkZjWE9qOFhqb0YxaDJWcXF1bFAwNmZuNVR0cW1SdHJGdFRs?=
 =?utf-8?B?eDI0eTJPNnNiOFd3dU5lS2tHeUdIdDl2OVVZSXNxRkdTWHZrK1ZDeTE0eTBZ?=
 =?utf-8?B?NTV3cVhOSUR6TVhCeHQ3aU4yMnBsVU82cGQ3bXFXOHRmVlhrRXRtbiszWlp5?=
 =?utf-8?B?WlR3TXppTlV2Vk9ycVc3M3p0S3ZlZ3lPVHF6OVdSUGEyQjZlczgwNHNuQUUw?=
 =?utf-8?B?czR5d0VsNUxGcVlubXdlcWc1alZYb0kyZVZRczByMWVNS2loTlNoSWF2NzJu?=
 =?utf-8?B?TGNWREhZV0hJNndUN093ZmhVUWpyU0RoSWNEMlRhWTBIbk9ZVk91KzZicnlV?=
 =?utf-8?B?cW1Sd3N0MkZFdm1EVGUrQmpwUjJyeFQxV29CWEJDNmxnT2tZdWdPSUdEWEtl?=
 =?utf-8?B?YVpzSHRkYmI2SU9GUEpLR1RESzkrWDJVbGJWRnBjbkJBd3lIbk1QaWJQaE41?=
 =?utf-8?B?bGpFcU1qZUNJajRVNktyVmxSclVwcjN1OTQveXh5aVVLU1VDV2JLek5UNU9P?=
 =?utf-8?B?ZWhLVGZiWXdrMW9peUZLa1NHUUpCbGw2Qk1oUmdPaHZleWlLZ2JMMnNEWVBp?=
 =?utf-8?B?MmFXN3dleEJVVzBodjIxM2hiVVdIS1c0YzI3TGYzcENCem4yM2RsMXBBeE9j?=
 =?utf-8?B?TXIyd24vRHI2WTVvdUdDcEZsMjB1NGVkUzIwazZnVGhGdkJCVDV0ZDYwUnNV?=
 =?utf-8?B?bVAxZlBnb0RTd1hRdFpmaFp0amdpeVhmbmhMTmFrZjR1R0toSGp6dz09?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9306a4b2-612b-488f-2e7c-08da425aeede
X-MS-Exchange-CrossTenant-AuthSource: AM5PR04MB3089.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 May 2022 16:39:15.0718
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ZZL+pQLwL69VYj5C9iwBsraSkYAHl1SjuZ6dPD+MbQlmJGNGX4VkCNCVPkZVogDytL0sGHrg7Jxd3FEugEdibw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM7PR04MB7189
X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE,
	T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no
	version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 5/27/22 01:30, keliu wrote:
> Use ida_alloc()/ida_free() instead of deprecated
> ida_simple_get()/ida_simple_remove() .
> 
> Signed-off-by: keliu <liuke94@huawei.com>
> ---
>   drivers/scsi/hosts.c                | 4 ++--
>   drivers/scsi/scsi_transport_iscsi.c | 6 +++---
>   2 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/scsi/hosts.c b/drivers/scsi/hosts.c
> index f69b77cbf538..ec16cfad034e 100644
> --- a/drivers/scsi/hosts.c
> +++ b/drivers/scsi/hosts.c
> @@ -350,7 +350,7 @@ static void scsi_host_dev_release(struct device *dev)
>   
>   	kfree(shost->shost_data);
>   
> -	ida_simple_remove(&host_index_ida, shost->host_no);
> +	ida_free(&host_index_ida, shost->host_no);
>   
>   	if (shost->shost_state != SHOST_CREATED)
>   		put_device(parent);
> @@ -395,7 +395,7 @@ struct Scsi_Host *scsi_host_alloc(struct scsi_host_template *sht, int privsize)
>   	init_waitqueue_head(&shost->host_wait);
>   	mutex_init(&shost->scan_mutex);
>   
> -	index = ida_simple_get(&host_index_ida, 0, 0, GFP_KERNEL);
> +	index = ida_alloc(&host_index_ida, GFP_KERNEL);
>   	if (index < 0) {
>   		kfree(shost);
>   		return NULL;
> diff --git a/drivers/scsi/scsi_transport_iscsi.c b/drivers/scsi/scsi_transport_iscsi.c
> index 2c0dd64159b0..2578db4c095d 100644
> --- a/drivers/scsi/scsi_transport_iscsi.c
> +++ b/drivers/scsi/scsi_transport_iscsi.c
> @@ -1975,7 +1975,7 @@ static void __iscsi_unbind_session(struct work_struct *work)
>   	scsi_remove_target(&session->dev);
>   
>   	if (session->ida_used)
> -		ida_simple_remove(&iscsi_sess_ida, target_id);
> +		ida_free(&iscsi_sess_ida, target_id);
>   
>   unbind_session_exit:
>   	iscsi_session_event(session, ISCSI_KEVENT_UNBIND_SESSION);
> @@ -2044,7 +2044,7 @@ int iscsi_add_session(struct iscsi_cls_session *session, unsigned int target_id)
>   		return -ENOMEM;
>   
>   	if (target_id == ISCSI_MAX_TARGET) {
> -		id = ida_simple_get(&iscsi_sess_ida, 0, 0, GFP_KERNEL);
> +		id = ida_alloc(&iscsi_sess_ida, GFP_KERNEL);
>   
>   		if (id < 0) {
>   			iscsi_cls_session_printk(KERN_ERR, session,
> @@ -2083,7 +2083,7 @@ int iscsi_add_session(struct iscsi_cls_session *session, unsigned int target_id)
>   	device_del(&session->dev);
>   release_ida:
>   	if (session->ida_used)
> -		ida_simple_remove(&iscsi_sess_ida, session->target_id);
> +		ida_free(&iscsi_sess_ida, session->target_id);
>   destroy_wq:
>   	destroy_workqueue(session->workq);
>   	return err;

Reviewed-by: Lee Duncan <lduncan@suse.com>