Received: by 2002:a19:771d:0:0:0:0:0 with SMTP id s29csp1284136lfc; Wed, 1 Jun 2022 14:12:12 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCNYyDGGNKrNbB68At2gvFDHZa+zI1oJv0VxKSZr7DDlB9M6E1ovI9eCUPK9LR41/Suy40 X-Received: by 2002:a17:902:aa04:b0:163:c204:f41 with SMTP id be4-20020a170902aa0400b00163c2040f41mr1317165plb.172.1654117932278; Wed, 01 Jun 2022 14:12:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654117932; cv=none; d=google.com; s=arc-20160816; b=P1++Q3nmSFurrBEbh+dH3AOPPwzh/x9BAyGJkBW4GmSIUYfAhdVdfwHwlnus2raiVm 2PMg8vmiObrmWMEd3D62VXU5FuBpCcX2P0gaaZws8Ymhnrr7YQdkDzU0kaXMKzZPYBlt mOkgYd+i4d5qmPMjk1sVkIKKNMHJihzH8MztlWu08PKcKov1gn1JBJXmIMAi1yosE+4k qiPRy177rSES7UCwLlwG25xEF8hVdp32FjAPKx9ZPP73J0PUJNSJg8C+5eNwT9O35Koh jO7WuUIfCvVEo9svZELetOpWGMlVP8BgBVlYkGsKEU/kjWj4L28Anh9AbTk6mwIjrNHs XFQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:in-reply-to:references:date:message-id :from:subject:content-transfer-encoding:mime-version:dkim-signature; bh=MtUIKcEilw5BgSf8EqEPrTISzsfm3kgbxoJdw4WOFr0=; b=xuIuk/SKFWk0if9J/GKeVigtmW20TD3J4nONpJ2jUGdE2hCGdYbvgorlMY1PkImAnp WJ6jJikM96+xfH1MRLgQfDgUnFmdWodginY0QTtggL0XSHEvocRFEU7wjBXOMaTSnxR/ 1d9b1rAJ04uZaV+5R4ZRIbLJfEQVmNTEjMuyTNbyL0oo+LwsGh/qfWsnf0AcfE6E/HxA 6I8XBN/7BmIqzRHkZLPARl5+lQvhNUSCZ67GB0DjBoRzbqG+xpYuWuL8TAvYmMYuq9+k YFHkA29faB++c5RXbytiFv3t40/39k1YsSMWbsVoFR5Tg7Px4ZL9WY2M1qGihR61JdVg 21Og== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ePU8nggo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id g6-20020a056a001a0600b005188fc8f52asi3848683pfv.71.2022.06.01.14.12.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 14:12:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=ePU8nggo; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 813522D29FB; Wed, 1 Jun 2022 13:04:23 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348483AbiEaWkQ (ORCPT + 99 others); Tue, 31 May 2022 18:40:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238162AbiEaWkO (ORCPT ); Tue, 31 May 2022 18:40:14 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8773F9EB4A; Tue, 31 May 2022 15:40:13 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 23DAD61468; Tue, 31 May 2022 22:40:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPS id 6F7EAC3411D; Tue, 31 May 2022 22:40:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654036812; bh=4cd7A12mmB7TOFG1oNOqmQmjZoSqWu2ThW8sKS2FhmY=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=ePU8nggokZOUGbrVKMRgoXk1AjyOxfFmbvGUNPTB+EKtObcTwS/DQ61tZNjOePdSt 7zivQqMyoBXVO/01C0juKlMB7YWZlZ3FR0BsWEs/HJT8IpMX8CaE17jWTgjB8rQd+I 0Ogv/AX1cBPppgI+pMZ5DDJMNzs/fXFa7LDko+7KNBhcfa+Gsw7Gih1wE+VLFb8X+F WFsFmx3OkC+TPqvRGVtaeV2JpMHkJK/3E+f07nbNDRTUcdZVPgEuZg37vCn12qRC9M s+2liPRW3TEQEkfzYODhQ4Uhur2KJXhNijZdfyD3wE6Ab2xvbwj5+0pT9WMYu3XI/P xON7OBoyJfBhA== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id 4D6A9F0394D; Tue, 31 May 2022 22:40:12 +0000 (UTC) Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] Check for NULL ptr of btf in codegen_asserts From: patchwork-bot+netdevbpf@kernel.org Message-Id: <165403681231.3395.15965102902497727563.git-patchwork-notify@kernel.org> Date: Tue, 31 May 2022 22:40:12 +0000 References: <20220523194917.igkgorco42537arb@jup> In-Reply-To: <20220523194917.igkgorco42537arb@jup> To: Michael Mullin Cc: ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org, kafai@fb.com, songliubraving@fb.com, yhs@fb.com, john.fastabend@gmail.com, kpsingh@kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello: This patch was applied to bpf/bpf-next.git (master) by Andrii Nakryiko : On Mon, 23 May 2022 15:49:17 -0400 you wrote: > bpf_object__btf() can return a NULL value. If bpf_object__btf returns > null, do not progress through codegen_asserts(). This avoids a null ptr > dereference at the call btf__type_cnt() in the function find_type_for_map() > > Signed-off-by: Michael Mullin > --- > tools/bpf/bpftool/gen.c | 3 +++ > 1 file changed, 3 insertions(+) Here is the summary with links: - Check for NULL ptr of btf in codegen_asserts https://git.kernel.org/bpf/bpf-next/c/d992a11f1171 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html