Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Message-ID: <e3ba1b78-5047-3bb3-e1af-988c718c075b@einfach.org>
Date:   Wed, 1 Jun 2022 08:04:24 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.10.0
Subject: Re: [PATCH] average: Clarify the restrictions
Content-Language: en-US
To:     Jui-Tse Huang <juitse.huang@gmail.com>,
        linux-kernel@vger.kernel.org
Cc:     Mark Rutland <mark.rutland@arm.com>,
        Johannes Berg <johannes.berg@intel.com>,
        Ching-Chun Huang <jserv@ccns.ncku.edu.tw>
References: <20220601065746.18426-1-juitse.huang@gmail.com>
From:   Bruno Randolf <br1@einfach.org>
In-Reply-To: <20220601065746.18426-1-juitse.huang@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 01/06/2022 07:57, Jui-Tse Huang wrote:
> There is several restrictions in the EWMA helper macro that the
> developers should take care of, but the comment does not mentioned yet,
> thus, this patch clarify the restrictions.
> 
> Signed-off-by: Jui-Tse Huang <juitse.huang@gmail.com>
> ---
>   include/linux/average.h | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/include/linux/average.h b/include/linux/average.h
> index a1a8f09631ce..1618f6519c3d 100644
> --- a/include/linux/average.h
> +++ b/include/linux/average.h
> @@ -13,6 +13,10 @@
>    * precision and fall-off coefficient determined at compile-time
>    * and built into the generated helper funtions.
>    *
> + * This implementation supports upto 30 bits of precition, and for

spelling: up to ... precision

> + * usage concern, only the api of fetching non-fractional part is
> + * provided for now.

spelling: "API for"

wording: remove "and for usage concern", just ", and only the API for" 
would be enough.

Thank you,
bruno