Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 01 Jun 2022 01:33:17 +0000
From:   Adam Wujek <dev_public@wujek.eu>
Cc:     Adam Wujek <dev_public@wujek.eu>,
        Guenter Roeck <linux@roeck-us.net>,
        Jean Delvare <jdelvare@suse.com>, linux-hwmon@vger.kernel.org,
        linux-kernel@vger.kernel.org
Reply-To: Adam Wujek <dev_public@wujek.eu>
Subject: [PATCH v3 2/2] hwmon: (pmbus) add MFR_* registers to debugfs
Message-ID: <20220601013232.801133-2-dev_public@wujek.eu>
In-Reply-To: <20220601013232.801133-1-dev_public@wujek.eu>
References: <20220601013232.801133-1-dev_public@wujek.eu>
Feedback-ID: 23425257:user:proton
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
To:     unlisted-recipients:; (no To-header on input)
Precedence: bulk

Add registers to debugfs:
PMBUS_MFR_ID
PMBUS_MFR_MODEL
PMBUS_MFR_REVISION
PMBUS_MFR_LOCATION
PMBUS_MFR_DATE
PMBUS_MFR_SERIAL

To reduce the number of debugfs entries, only values from page 0 are
reported. It is assumed that values of these registers are the same for
all pages. Please note that the PMBUS standard allows added registers to
be page-specific.

Signed-off-by: Adam Wujek <dev_public@wujek.eu>
---
  - This is a reworked patch to report the registers only once (for page 0)
  Changes in v2:
    - no changes
  Changes in v3:
    - Change last paragraph od the commit message
    - fix formating in the comment
 drivers/hwmon/pmbus/pmbus_core.c | 99 +++++++++++++++++++++++++++++++-
 1 file changed, 97 insertions(+), 2 deletions(-)

diff --git a/drivers/hwmon/pmbus/pmbus_core.c b/drivers/hwmon/pmbus/pmbus_c=
ore.c
index a1c70877ae68..9c55b0cf1511 100644
--- a/drivers/hwmon/pmbus/pmbus_core.c
+++ b/drivers/hwmon/pmbus/pmbus_core.c
@@ -2659,6 +2659,34 @@ static int pmbus_debugfs_get_status(void *data, u64 =
*val)
 DEFINE_DEBUGFS_ATTRIBUTE(pmbus_debugfs_ops_status, pmbus_debugfs_get_statu=
s,
 =09=09=09 NULL, "0x%04llx\n");

+static ssize_t pmbus_debugfs_mfr_read(struct file *file, char __user *buf,
+=09=09=09=09       size_t count, loff_t *ppos)
+{
+=09int rc;
+=09struct pmbus_debugfs_entry *entry =3D file->private_data;
+=09char data[I2C_SMBUS_BLOCK_MAX + 2] =3D { 0 };
+
+=09rc =3D pmbus_read_block_data(entry->client, entry->page, entry->reg,
+=09=09=09=09   data);
+=09if (rc < 0)
+=09=09return rc;
+
+=09/* Add newline at the end of a read data */
+=09data[rc] =3D '\n';
+
+=09/* Include newline into the length */
+=09rc +=3D 1;
+
+=09return simple_read_from_buffer(buf, count, ppos, data, rc);
+}
+
+static const struct file_operations pmbus_debugfs_ops_mfr =3D {
+=09.llseek =3D noop_llseek,
+=09.read =3D pmbus_debugfs_mfr_read,
+=09.write =3D NULL,
+=09.open =3D simple_open,
+};
+
 static int pmbus_debugfs_get_pec(void *data, u64 *val)
 {
 =09struct i2c_client *client =3D data;
@@ -2723,9 +2751,13 @@ static int pmbus_init_debugfs(struct i2c_client *cli=
ent,
 =09=09return -ENODEV;
 =09}

-=09/* Allocate the max possible entries we need. */
+=09/*
+=09 * Allocate the max possible entries we need.
+=09 * 6 entries device-specific
+=09 * 10 entries page-specific
+=09 */
 =09entries =3D devm_kcalloc(data->dev,
-=09=09=09       data->info->pages * 10, sizeof(*entries),
+=09=09=09       6 + data->info->pages * 10, sizeof(*entries),
 =09=09=09       GFP_KERNEL);
 =09if (!entries)
 =09=09return -ENOMEM;
@@ -2733,6 +2765,69 @@ static int pmbus_init_debugfs(struct i2c_client *cli=
ent,
 =09debugfs_create_file("pec", 0664, data->debugfs, client,
 =09=09=09    &pmbus_debugfs_ops_pec);

+=09/*
+=09 * Add device-specific entries.
+=09 * Please note that the PMBUS standard allows all registers to be
+=09 * page-specific.
+=09 * To reduce the number of debugfs entries for devices with many pages
+=09 * assume that values of the following registers are the same for all
+=09 * pages and report values only for page 0.
+=09 */
+=09if (pmbus_check_block_register(client, 0, PMBUS_MFR_ID)) {
+=09=09entries[idx].client =3D client;
+=09=09entries[idx].page =3D 0;
+=09=09entries[idx].reg =3D PMBUS_MFR_ID;
+=09=09debugfs_create_file("mfr_id", 0444, data->debugfs,
+=09=09=09=09    &entries[idx++],
+=09=09=09=09    &pmbus_debugfs_ops_mfr);
+=09}
+
+=09if (pmbus_check_block_register(client, 0, PMBUS_MFR_MODEL)) {
+=09=09entries[idx].client =3D client;
+=09=09entries[idx].page =3D 0;
+=09=09entries[idx].reg =3D PMBUS_MFR_MODEL;
+=09=09debugfs_create_file("mfr_model", 0444, data->debugfs,
+=09=09=09=09    &entries[idx++],
+=09=09=09=09    &pmbus_debugfs_ops_mfr);
+=09}
+
+=09if (pmbus_check_block_register(client, 0, PMBUS_MFR_REVISION)) {
+=09=09entries[idx].client =3D client;
+=09=09entries[idx].page =3D 0;
+=09=09entries[idx].reg =3D PMBUS_MFR_REVISION;
+=09=09debugfs_create_file("mfr_revision", 0444, data->debugfs,
+=09=09=09=09    &entries[idx++],
+=09=09=09=09    &pmbus_debugfs_ops_mfr);
+=09}
+
+=09if (pmbus_check_block_register(client, 0, PMBUS_MFR_LOCATION)) {
+=09=09entries[idx].client =3D client;
+=09=09entries[idx].page =3D 0;
+=09=09entries[idx].reg =3D PMBUS_MFR_LOCATION;
+=09=09debugfs_create_file("mfr_location", 0444, data->debugfs,
+=09=09=09=09    &entries[idx++],
+=09=09=09=09    &pmbus_debugfs_ops_mfr);
+=09}
+
+=09if (pmbus_check_block_register(client, 0, PMBUS_MFR_DATE)) {
+=09=09entries[idx].client =3D client;
+=09=09entries[idx].page =3D 0;
+=09=09entries[idx].reg =3D PMBUS_MFR_DATE;
+=09=09debugfs_create_file("mfr_date", 0444, data->debugfs,
+=09=09=09=09    &entries[idx++],
+=09=09=09=09    &pmbus_debugfs_ops_mfr);
+=09}
+
+=09if (pmbus_check_block_register(client, 0, PMBUS_MFR_SERIAL)) {
+=09=09entries[idx].client =3D client;
+=09=09entries[idx].page =3D 0;
+=09=09entries[idx].reg =3D PMBUS_MFR_SERIAL;
+=09=09debugfs_create_file("mfr_serial", 0444, data->debugfs,
+=09=09=09=09    &entries[idx++],
+=09=09=09=09    &pmbus_debugfs_ops_mfr);
+=09}
+
+=09/* Add page specific entries */
 =09for (i =3D 0; i < data->info->pages; ++i) {
 =09=09/* Check accessibility of status register if it's not page 0 */
 =09=09if (!i || pmbus_check_status_register(client, i)) {
--
2.17.1