Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <6676b6a4-2d2d-27bf-2f71-b0c4767b71bf@arm.com>
Date:   Mon, 30 May 2022 14:33:18 +0530
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH V2] mm/memory_hotplug: Drop 'reason' argument from
 check_pfn_span()
Content-Language: en-US
To:     David Hildenbrand <david@redhat.com>, linux-mm@kvack.org
Cc:     Oscar Salvador <osalvador@suse.de>,
        Andrew Morton <akpm@linux-foundation.org>,
        linux-kernel@vger.kernel.org
References: <20220526021258.4030749-1-anshuman.khandual@arm.com>
 <8c5c5bd6-fea6-4c27-9a84-4b9c937068d7@redhat.com>
From:   Anshuman Khandual <anshuman.khandual@arm.com>
In-Reply-To: <8c5c5bd6-fea6-4c27-9a84-4b9c937068d7@redhat.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 5/30/22 12:24, David Hildenbrand wrote:
> On 26.05.22 04:12, Anshuman Khandual wrote:
>> In check_pfn_span(), a 'reason' string is being used to recreate the caller
>> function name, while printing the warning message. It is really unnecessary
>> as the warning message could just be printed inside the caller depending on
>> the return code. Currently there are just two callers for check_pfn_span()
>> i.e  __add_pages() and __remove_pages(). Let's clean this up.
>>
>> Cc: Oscar Salvador <osalvador@suse.de>
>> Cc: David Hildenbrand <david@redhat.com>
>> Cc: Andrew Morton <akpm@linux-foundation.org>
>> Cc: linux-mm@kvack.org
>> Cc: linux-kernel@vger.kernel.org
>> Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
>> ---
>> Changes in V2:
>>
>> - Fixed typo in commit message
>> - Dropped using 'ret' to capture check_pfn_span() return value in __add_pages()
>>
>> Changes in V1:
>>
>> https://lore.kernel.org/all/20220525033910.3781764-1-anshuman.khandual@arm.com/
>>
>>  mm/memory_hotplug.c | 20 +++++++++-----------
>>  1 file changed, 9 insertions(+), 11 deletions(-)
>>
>> diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c
>> index 416b38ca8def..3b24386e9276 100644
>> --- a/mm/memory_hotplug.c
>> +++ b/mm/memory_hotplug.c
>> @@ -220,8 +220,7 @@ static void release_memory_resource(struct resource *res)
>>  	kfree(res);
>>  }
>>  
>> -static int check_pfn_span(unsigned long pfn, unsigned long nr_pages,
>> -		const char *reason)
>> +static int check_pfn_span(unsigned long pfn, unsigned long nr_pages)
>>  {
>>  	/*
>>  	 * Disallow all operations smaller than a sub-section and only
>> @@ -238,12 +237,8 @@ static int check_pfn_span(unsigned long pfn, unsigned long nr_pages,
>>  		min_align = PAGES_PER_SUBSECTION;
>>  	else
>>  		min_align = PAGES_PER_SECTION;
>> -	if (!IS_ALIGNED(pfn, min_align)
>> -			|| !IS_ALIGNED(nr_pages, min_align)) {
>> -		WARN(1, "Misaligned __%s_pages start: %#lx end: #%lx\n",
>> -				reason, pfn, pfn + nr_pages - 1);
>> +	if (!IS_ALIGNED(pfn, min_align) || !IS_ALIGNED(nr_pages, min_align))
> We could do
> 
> if (!IS_ALIGNED(pfn | nr_pages, min_align))


Sure, will change it.