Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp5873748ioo; Wed, 1 Jun 2022 14:38:48 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyoAHMhlzMvJ3A6iPBnUhndu1Ymwi6488Vb1t+MNOZ3gbeUsg+M3slH4VJAe8pM0ac6LbJg X-Received: by 2002:a17:90b:4c0e:b0:1e6:6c62:a30c with SMTP id na14-20020a17090b4c0e00b001e66c62a30cmr3604338pjb.166.1654119527856; Wed, 01 Jun 2022 14:38:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654119527; cv=none; d=google.com; s=arc-20160816; b=ZRDDPI6GtClK2eXaDbWp8pgUlmUCJ4EKV7R+NUMPc/D7eoOt9BwCy0qZXj2bcr/C6z KPvxClXKEgqmX9S6X1XB5QEvHJFi9kCWjKTG8PRipu+Y0RaZpy+tp2rKJP4iQRuBxcbC jQjwCzZcjljnIh4gv4UEZZ2nKKYE5ffndf67EtJ1fvDikOfsm7Q4owVeE1yD4EkgLk3P xDl3OrO6eWJJXpey5aJmgpxFLKgk1EnUWCKZ2imKqwsXtIPZY5C9y2ZAL+3mfw1YMaK0 7SrTp16ugReNkXqUTTtbuo6GYpjl/3rXjBx7PNcTWXVs/nYLckGRcmDOkgixes8zf3gA 5wXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to:from :references:cc:to:content-language:subject:user-agent:mime-version :date:message-id:dkim-signature; bh=DcSjpVSz5kBdKttL/qibmuyG6zf/I/eEkUNKVypzm4Y=; b=o/VAVsjC2DGS0ujP/v4+2lFZM1WkWmiklyBkURhJr9FGDCh0BpprCncMJun7YDN+dA AbTYkD/XfTYXbXeFtrtJlU/l7mHzylTo91FiE0TnOTinYclLoQ9UINZLxhyc4RW0GWPT ZWnUbWyU5KB/Sov7ZPAgPTh0ExcP7A02pihjuM/MGaAkr9u4otM0F0puPdpEpVcB7vIG 9c3dEpsAvC+V5qGPGdzE/7JSeORgN/sQGpNKINx4zDxhg8RgyvL3ykAiWQf7H/WK1qVi hwUtcFZxzShcF3JbVcH/hMnHhnFNDyH+ytt8OM8p5UzdIhJAXmYzCyUB843FIW19shFu qvnw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LeXZCfDw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id w1-20020a1709027b8100b00162496617adsi3548699pll.142.2022.06.01.14.38.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 14:38:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=LeXZCfDw; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id BFE4E27229E; Wed, 1 Jun 2022 13:47:50 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230217AbiFAUqr (ORCPT + 99 others); Wed, 1 Jun 2022 16:46:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229890AbiFAUoJ (ORCPT ); Wed, 1 Jun 2022 16:44:09 -0400 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA4141EA077 for ; Wed, 1 Jun 2022 13:29:09 -0700 (PDT) Received: by mail-lf1-x136.google.com with SMTP id u23so4640978lfc.1 for ; Wed, 01 Jun 2022 13:29:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=DcSjpVSz5kBdKttL/qibmuyG6zf/I/eEkUNKVypzm4Y=; b=LeXZCfDwi2JzAKvy4kHtOnltGKxqKYskF08v+UIdsvEtOxxkwoK78b2BOKkHrkgRfW Y+8VuwFXMA22RggbMXr8BqJP8G9jxw4NnRbS5rJ+Hlm7fSLvPjIgZFIY3mCYuRhB7AwR TDIq6/uCsckrZ4MnKi3K5jPuGZNp+R5ffvuOnJlAukZOGyMaOXN+e+lddOkZneNNJNBr KwAPb0MnVnY+5+izFAW7GUFLx7j2b7w7PBm9XR71icRTloDMuybxUTteLsrK5SaaUyO/ N0nALzFMvqA0DKYCugRlIBeZSBKbPu6/Dkk/jBaJJJ1YQoQIpWnIz7fBd9gMiYKhkysR s9CA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=DcSjpVSz5kBdKttL/qibmuyG6zf/I/eEkUNKVypzm4Y=; b=FEBauB0nzdmEQXXTcOEQG9NcmCjB4ITQq/+r2Rmm+m0t8VfSHHkGaGuIdORQdaPQH0 UVIw6JE5rVS5oObs500iglWUsaBFalehL+WWL8qNAv2gCWcJYp+zMps+tNROnGbbNEHE KfTJ2ULff4unEQcwXukDUaZXZcxokXOXSwyAn+Xx3XOJ+ArMK6/LWOU0qyQkNa8aO/yM Yh7vma4N3uXHI6FsatDGRHbfoJ4pdWCQF0rgvw8XwBly3XseZjGZQlRDYXv4ODVkSgDB ZsgZaeQ+uA5Tv/w43crndp4EuhemNw7ou3jsr80MWRIYDh1+OmvQbCg/YNTBVQEYs4fl 8KAQ== X-Gm-Message-State: AOAM533mJ4qsda2Sdy+lryrHTcO99th3FWP4Kxh6qxkxCcvrKehUZn3o NZT3quK3OM0MdQkdcAuGpuyRxg== X-Received: by 2002:ac2:4289:0:b0:477:b3eb:f2f with SMTP id m9-20020ac24289000000b00477b3eb0f2fmr916181lfh.386.1654115347986; Wed, 01 Jun 2022 13:29:07 -0700 (PDT) Received: from [192.168.1.211] ([37.153.55.125]) by smtp.gmail.com with ESMTPSA id z8-20020a0565120c0800b00478e5ef1ee5sm550811lfu.245.2022.06.01.13.29.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Jun 2022 13:29:07 -0700 (PDT) Message-ID: <846ef8f5-230e-4e52-f67c-d2fc2530fcc0@linaro.org> Date: Wed, 1 Jun 2022 23:29:06 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 1/4] drm/dp: Export symbol / kerneldoc fixes for DP AUX bus Content-Language: en-GB To: Douglas Anderson , dri-devel@lists.freedesktop.org Cc: Hsin-Yi Wang , Abhinav Kumar , Philip Chen , Sankeerth Billakanti , Robert Foss , freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, Stephen Boyd , Daniel Vetter , David Airlie , Javier Martinez Canillas , Linus Walleij , Lyude Paul , Thomas Zimmermann , linux-kernel@vger.kernel.org References: <20220510192944.2408515-1-dianders@chromium.org> <20220510122726.v3.1.Ia91f4849adfc5eb9da1eb37ba79aa65fb3c95a0f@changeid> From: Dmitry Baryshkov In-Reply-To: <20220510122726.v3.1.Ia91f4849adfc5eb9da1eb37ba79aa65fb3c95a0f@changeid> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.2 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_NONE,SPF_HELO_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/05/2022 22:29, Douglas Anderson wrote: > While working on the DP AUX bus code I found a few small things that > should be fixed. Namely the non-devm version of > of_dp_aux_populate_ep_devices() was missing an export. There was also > an extra blank line in a kerneldoc and a kerneldoc that incorrectly > documented a return value. Fix these. > > Fixes: aeb33699fc2c ("drm: Introduce the DP AUX bus") > Signed-off-by: Douglas Anderson Reviewed-by: Dmitry Baryshkov > --- > None of these seem critical, so my plan is to land this in > drm-misc-next and not drm-misc-fixes. This will avoid merge conflicts > with future patches. > > Changes in v3: > - Patch ("drm/dp: Export symbol / kerneldoc fixes...") split for v3. > > drivers/gpu/drm/display/drm_dp_aux_bus.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/display/drm_dp_aux_bus.c b/drivers/gpu/drm/display/drm_dp_aux_bus.c > index dccf3e2ea323..552f949cff59 100644 > --- a/drivers/gpu/drm/display/drm_dp_aux_bus.c > +++ b/drivers/gpu/drm/display/drm_dp_aux_bus.c > @@ -66,7 +66,6 @@ static int dp_aux_ep_probe(struct device *dev) > * @dev: The device to remove. > * > * Calls through to the endpoint driver remove. > - * > */ > static void dp_aux_ep_remove(struct device *dev) > { > @@ -120,8 +119,6 @@ ATTRIBUTE_GROUPS(dp_aux_ep_dev); > /** > * dp_aux_ep_dev_release() - Free memory for the dp_aux_ep device > * @dev: The device to free. > - * > - * Return: 0 if no error or negative error code. > */ > static void dp_aux_ep_dev_release(struct device *dev) > { > @@ -256,6 +253,7 @@ int of_dp_aux_populate_ep_devices(struct drm_dp_aux *aux) > > return 0; > } > +EXPORT_SYMBOL_GPL(of_dp_aux_populate_ep_devices); > > static void of_dp_aux_depopulate_ep_devices_void(void *data) > { -- With best wishes Dmitry