Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Date:   Wed, 1 Jun 2022 14:57:56 -0400
From:   Joe Simmons-Talbott <joetalbott@gmail.com>
To:     Andy Shevchenko <andy.shevchenko@gmail.com>
Cc:     Jonathan Cameron <jic23@kernel.org>,
        linux-iio <linux-iio@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Joe Perches <joe@perches.com>
Subject: Re: [PATCH v2] iio: Use octal permissions and DEVICE_ATTR_{RO,RW}.
Message-ID: <Ype2tDgWRVC68O//@spruce>
References: <20220531181016.76007-1-joetalbott@gmail.com>
 <CAHp75Vdei4SyC0Ph0xB3DFLgkixU2FJ1TS4og8r=b+CkiMQ5hQ@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAHp75Vdei4SyC0Ph0xB3DFLgkixU2FJ1TS4og8r=b+CkiMQ5hQ@mail.gmail.com>
Precedence: bulk

On Wed, Jun 01, 2022 at 12:01:12PM +0200, Andy Shevchenko wrote:
> On Tue, May 31, 2022 at 9:40 PM Joe Simmons-Talbott
> <joetalbott@gmail.com> wrote:
> >
> > As reported by checkpatch.pl.  Where possible use DEVICE_ATTR_RO and
> 
> DEVICE_ATTR_RO()
> 
> > DEVICE_ATTR_RW.  Change function names to be <var>_show() for read and
> 
> DEVICE_ATTR_RW()
> 
> > <var>_store() for write.
> 
> ...
> 
> >  static struct device_attribute dev_attr_length_ro = __ATTR(length,
> > +       0444, length_show, NULL);
> 
> >  static struct device_attribute dev_attr_watermark_ro = __ATTR(watermark,
> > +       0444, watermark_show, NULL);
> 
> Why not __ATTR_RO() here?

Thank you for reviewing.  An updated v3 patch has been sent.

Thanks,
Joe
> 
> -- 
> With Best Regards,
> Andy Shevchenko