Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
Message-ID: <5ec9be313961b4cb3771180a75a4767998c6fdc0.camel@intel.com>
Subject: Re: [RFC PATCH v6 006/104] KVM: TDX: Detect CPU feature on kernel
 module initialization
From:   Kai Huang <kai.huang@intel.com>
To:     Isaku Yamahata <isaku.yamahata@gmail.com>,
        Sagi Shahar <sagis@google.com>
Cc:     "Yamahata, Isaku" <isaku.yamahata@intel.com>, kvm@vger.kernel.org,
        linux-kernel@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>,
        Erdem Aktas <erdemaktas@google.com>,
        Sean Christopherson <seanjc@google.com>
Date:   Thu, 02 Jun 2022 10:11:09 +1200
In-Reply-To: <20220526192844.GC3413287@ls.amr.corp.intel.com>
References: <cover.1651774250.git.isaku.yamahata@intel.com>
         <eb5d2891a3ff55d88545221c588ba87e4c811878.1651774250.git.isaku.yamahata@intel.com>
         <CAAhR5DFWo6KjBO_0QtT71S2ZmKc-kAo6Kqcwc2M4-kFc-PkmyA@mail.gmail.com>
         <20220526192844.GC3413287@ls.amr.corp.intel.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) 
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 2022-05-26 at 12:28 -0700, Isaku Yamahata wrote:
> +       if (!platform_has_tdx()) {
> +               if (__seamrr_enabled())
> +                       pr_warn("Cannot enable TDX with SEAMRR disabled\n");
> +               else
> +                       pr_warn("Cannot enable TDX on TDX disabled platform.\n");
> +               return -ENODEV;
> +       }

This is really overkill.  I cannot tell the difference between "SEAMRR disabled"
and "TDX disabled platform".

Btw, the v4 has removed __seamrr_enabled(), and there are other changes too. 
Could you rebase the KVM code to latest v4?

https://lore.kernel.org/lkml/cover.1654025430.git.kai.huang@intel.com/

-- 
Thanks,
-Kai