Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
From:   Stephen Brennan <stephen.s.brennan@oracle.com>
To:     Eric Biggers <ebiggers@kernel.org>,
        David Howells <dhowells@redhat.com>
Cc:     torvalds@linux-foundation.org, stable@vger.kernel.org,
        Jarkko Sakkinen <jarkko@kernel.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        keyrings@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] assoc_array: Fix BUG_ON during garbage collect
In-Reply-To: <YpfrLUknlmcvwNzY@sol.localdomain>
References: <165295023086.3361286.8662079860706628540.stgit@warthog.procyon.org.uk>
 <YpfrLUknlmcvwNzY@sol.localdomain>
Date:   Wed, 01 Jun 2022 16:03:12 -0700
Message-ID: <87y1ygyojz.fsf@stepbren-lnx.us.oracle.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?YsbEV83xGj8Vei3llKacBI2Oq3YF+fnVPc2JhiVcF8y6M5qMJMZTlk7Bq2pr?=
 =?us-ascii?Q?RGt5XhTpbunwKAGOCxyc8GhnJn784bDQd/zOSytvqDR9sCSR+MStJOJ/2xiH?=
 =?us-ascii?Q?HWHICYgzLlfFeeyTljgo9YpmS9HRTaFFwpE2JJR/WbSDrgDV91tyyNaYL2Iq?=
 =?us-ascii?Q?UW3R4PJVdKb9SREji0OYpVhGC5mApcBK1rYczIBEw/aWevq9YlJQq+01wWEg?=
 =?us-ascii?Q?0JVTh3ww8DB/ZqJR9ZGUkKuFqNICMlg0dkzv3jSXS36W3CDMGaZiUHVlfZ9V?=
 =?us-ascii?Q?hxRam9xRs43KR4L0FT7Akdo+uUoGr0m6UMKBOgxo8QmJp6o3J5z8Er42U27B?=
 =?us-ascii?Q?FcA1t4swDDfNYCqBWT4C7SoW+zNMl4RVwz53zTcc3Gf0GS1qchcf+u8YjbJ9?=
 =?us-ascii?Q?J1Y9Qxg2bN23g5U4hz+vi0uUOvIUz6zu+gH02GjVYmk6WoynAfNcwglZr/ii?=
 =?us-ascii?Q?aU7JNrfJ7nNacQgaO1/PNiss0UG9NlwTRoxhbNdLI1fXVG0TZImnVpfeTZ21?=
 =?us-ascii?Q?Y2Lqbp5CPMNymX7gCjO5LBg/uMT3TA+vFqRXUD/MELw16xH9KHS4DfiRKE1z?=
 =?us-ascii?Q?CkD4cB9psQTm22lDZiDvr4xsSUaq/HoeUzqGxo9Wfhq2UuvNJJ+NK7mYVuUs?=
 =?us-ascii?Q?+/T0C4S1XOn/6XGQdwQWbaYMgIbhBWfwkCM8TLiIUhazijGMwvaAHDeG8Ai9?=
 =?us-ascii?Q?EoR4iGzgq/qopzjLbBDFbwhDmrHZCRh2NdrVDP+FiR2luLgkQpAs8gejFL5Z?=
 =?us-ascii?Q?77IT+WFajo4ix8YsYqX74pR1ROqoqYkkSdEsfNOGMwotTE4u7145AVsCIH8o?=
 =?us-ascii?Q?hlxIy6t4sFzxIj/3hoe5XdZHRdZHrCQqsfrpcaghrT1/6zQzM251oS8Kwak5?=
 =?us-ascii?Q?HcJt1zUxXBAAHJtAlq8QBjmkd+y5tnnzU9HUEt3AEOO1hvJLFdxjdKdGRs0Z?=
 =?us-ascii?Q?AxxZXxDCp69rJQThN8LYW/CQwym0b5TqG3/X3kn8RO8nHsfbuJak/IuIpozI?=
 =?us-ascii?Q?aJnt+oAD3vsUQy9Z67N++dFXtdEKcXCEGlzpUlw0rYm95vpu/mXWuAMLcQOe?=
 =?us-ascii?Q?gkBZyl4zhdbGM/SuiMFN/bdce08lUmga4vT8xcYHJykdaoX2+dMgEHoms2Si?=
 =?us-ascii?Q?FaFBeC9ShlhpFJEyV36RQwckMipbpdIRe8XJrbmvZqSimuPAQDgplBblZYx4?=
 =?us-ascii?Q?nWF1d7NwfVjCokqangtDtKCNYfzq8KA7ayRfAPlDbT+Mz7YpSsfqrzjCL6w6?=
 =?us-ascii?Q?DhIl356a9coSeTdjKspSKWNcZfJAuIEuBAl3tRV4R0dmw52v9wEf2l3pdQnT?=
 =?us-ascii?Q?2aRUJvQ0gBItNTfH6GtzGfeC5YCIf9/AcYc+Xn2MGYYhptltV07nMJUzsCTN?=
 =?us-ascii?Q?guYWn6uXLqYWfSxxdhj/njMG8AD/0yAcYl+H+eM4hYq+0GyEXj4n+H8Uemql?=
 =?us-ascii?Q?S60/7uXVfCZkIb139U8Fm0DZ420s2tTuN7ytYAp7IDwkxesocopr43qw4AqM?=
 =?us-ascii?Q?iwUpyyAHfBMi5pCnwQUAmvb/oWMb8uS+J1MQ0nyhmsQaAZre1bVEJ+G6W652?=
 =?us-ascii?Q?Ffu6OGQuxTAkkLT9voi0fYQ3rHE4Hw3UPBG6fZ4xC0+hN4GyhYm9cMLnrdzR?=
 =?us-ascii?Q?tmS3opmnVVQMLtgwvZUvL7xV9cmWU/ETFnqNQx7Pw+9LNP72fkqvFJi/Me2g?=
 =?us-ascii?Q?ML1XsisEWxjs2c+upvvbr55sl5hRAsndewiF+yrM0k/uIyUkwz+utXOR9/D5?=
 =?us-ascii?Q?dbFCSYgG7D3EAVEEAMVc5+lcAK805Ug=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: bb5fe377-efb4-4b35-bcc5-08da4422e8ee
X-MS-Exchange-CrossTenant-AuthSource: CH2PR10MB4166.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Jun 2022 23:03:15.6226
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: /P46uT0Kvq/tpIyUAGXjdR/JHFdfL3wx+VHjSSG+GP5JhAYx+NusYBbEN0stqUu381YU7sFhETMNaUFPm5qbVA3y/+izGtfauntZ6jpN6cA=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR10MB2600
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-01_09:2022-06-01,2022-06-01 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=999
 phishscore=0 suspectscore=0 malwarescore=0 mlxscore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206010090
X-Proofpoint-GUID: hGfOJK9zUoZLC2XcBU0gCZ2Th3lJ3dCr
X-Proofpoint-ORIG-GUID: hGfOJK9zUoZLC2XcBU0gCZ2Th3lJ3dCr
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Eric Biggers <ebiggers@kernel.org> writes:

> On Thu, May 19, 2022 at 09:50:30AM +0100, David Howells wrote:
>> diff --git a/lib/assoc_array.c b/lib/assoc_array.c
>> index 079c72e26493..ca0b4f360c1a 100644
>> --- a/lib/assoc_array.c
>> +++ b/lib/assoc_array.c
>
> Where are the tests for this file?

As of today there are none:

$ grep -lr assoc_array
lib/assoc_array.c
lib/Makefile
lib/Kconfig
arch/powerpc/mm/numa.c
arch/powerpc/platforms/pseries/hotplug-memory.c
Documentation/core-api/index.rst
Documentation/core-api/assoc_array.rst
Documentation/translations/zh_CN/core-api/index.rst
Documentation/translations/zh_CN/core-api/assoc_array.rst
include/linux/assoc_array.h
include/linux/key.h
include/linux/assoc_array_priv.h
include/keys/keyring-type.h
security/keys/internal.h
security/keys/key.c
security/keys/keyring.c
security/keys/request_key.c

The assoc_array code is easy to get up and running in userspace (see the
reproducer for this bug). So testing it would be feasible with some sort
of userspace runner (KUnit?). Seems it hasn't been done yet.

Stephen

>
> - Eric