Received-SPF: softfail (google.com: domain of transitioning linux-kernel-owner@vger.kernel.org does not designate 23.128.96.19 as permitted sender) client-ip=23.128.96.19;
Date:   Wed, 1 Jun 2022 17:31:03 -0700
From:   Roman Gushchin <roman.gushchin@linux.dev>
To:     Andrew Morton <akpm@linux-foundation.org>
Cc:     linux-mm@kvack.org, Dave Chinner <dchinner@redhat.com>,
        linux-kernel@vger.kernel.org,
        Kent Overstreet <kent.overstreet@gmail.com>,
        Hillf Danton <hdanton@sina.com>,
        Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
        Muchun Song <songmuchun@bytedance.com>
Subject: Re: [PATCH v5 2/6] mm: shrinkers: introduce debugfs interface for
 memory shrinkers
Message-ID: <YpgEx2srp5ipTbe6@carbon>
References: <20220601032227.4076670-1-roman.gushchin@linux.dev>
 <20220601032227.4076670-3-roman.gushchin@linux.dev>
 <20220601142358.75a6c9c5d4a988bd58667717@linux-foundation.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220601142358.75a6c9c5d4a988bd58667717@linux-foundation.org>
Precedence: bulk

On Wed, Jun 01, 2022 at 02:23:58PM -0700, Andrew Morton wrote:
> On Tue, 31 May 2022 20:22:23 -0700 Roman Gushchin <roman.gushchin@linux.dev> wrote:
> 
> > This commit introduces the /sys/kernel/debug/shrinker debugfs
> > interface
> 
> Should it be at the top level?  Maybe /sys/kernel/debug/vm/shrinker
> would be more future-safe. (or .../mm/...)

There are already some top-level mm-related items (slab, zswap, extfrag, etc)
and I don't think there will be non-mm shrinkers in the kernel (given that
it's a kernel-wide API).

But no strong opinion here, if you strongly prefer mm/ or vm/, I'm happy
to change it.

Thanks!