Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp5996603ioo; Wed, 1 Jun 2022 18:07:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz8KyFGPE0zoHyE4/oXdpE5lnE0as0YI8jmOvKH1rwVHEqjJi3q7399d8YkTUNtG65EwUOV X-Received: by 2002:a17:90b:4b02:b0:1e2:ff51:272a with SMTP id lx2-20020a17090b4b0200b001e2ff51272amr2321806pjb.56.1654132035992; Wed, 01 Jun 2022 18:07:15 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654132035; cv=none; d=google.com; s=arc-20160816; b=ynRCMzYT23xjI8ZJxYmmWY9M914Eh2mDtYKcC739JaFcOpjdob3YkuXENUjD4V6U2g BbW4IzCLJJQYQLco3KnUTGTbHYHMOMRFq4xfDG9oEDSdsb0FgTak+Mui/jjjKoOpHlw3 cnR16uz9fu/2iIwZuXUGI867eoKgUd1ZaEUt1AL+hDz/G5xlT9bzIFmcsmTdYGkObwUa RXK2pjFvD6XGLfLVGT46o+Yq/tDovHArk8Dmu2J0OoylPBwcc9lyHO3UBZGKfpHFxB5R B1fWMBmW1IXPD3ZOik3cprGQ3r6k9dtyU7OR2xtPwCyszYOrx5tnYKZj3QtxbDdXhWCw wlcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=H99AvHgoVb2MOyxPw4NiGpSEjhLBZmbaF3U3+UQgMuM=; b=z+3zHGwvoHDvd0DjUtz3gk/pYwseEWr2vRD8yyoR3rCyGl6JTC9bPr/4QVl1iUBxOc Vy1+ojSHImcAzYTDgGQySCpSmTxHruF5F0Ojnuw+oViLlWeSIAR8L8ZtwG5ffu+37oZO 9hw/H0aLAW8MPAKCXhdq0lhXJbbgN9xyM4LImMx04veKFgdiLDJw5BoIMnHdtbsr6zA9 OMrdRR7164lvQd0UiuwgzSGtbZ1JVzT/yUxu4uC3sc1ueyDoBKbcCERwTRm86lO19Hac e9zYnWDumQdT7WebfdFRfFfIUdF4ZBijq9CzJUfbJbDq4vgZ0OOW5YSuvoml563lji44 sMrA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qha8JLVY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net. [2620:137:e000::1:18]) by mx.google.com with ESMTPS id j14-20020a63ec0e000000b003c6aa1dce5fsi3813506pgh.872.2022.06.01.18.07.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Jun 2022 18:07:15 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=qha8JLVY; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 71325261453; Wed, 1 Jun 2022 18:03:30 -0700 (PDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232774AbiFBBDX (ORCPT + 99 others); Wed, 1 Jun 2022 21:03:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40584 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232569AbiFBBDT (ORCPT ); Wed, 1 Jun 2022 21:03:19 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E26E525C1E2; Wed, 1 Jun 2022 18:03:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 9ACC8B81D9C; Thu, 2 Jun 2022 01:03:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01EEAC385B8; Thu, 2 Jun 2022 01:03:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1654131796; bh=wksuz7vaU/eT//E6IgpXwPJq8QtyuB6m7LjRu8m7SC4=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=qha8JLVY2iWPYuve2RGON4YDTNKfH+xK8C0vhdhsGZaiuONp0bzbvfBe5GCdbr96F FGuk6sWryGYBGZf99Ktq+s6EtTg03fYEvi/u4jxdRf3VTPaCRmmYjmc1BsH8ZUqwyK Ja45OsmwNnZBNd2JfqE6UXscH0TQMV86b4Q7yYSJAfcxx0bfZuQ+K6vgmaa6c48FCR 6X3LTLZUov3OoHFU+IVhOS23wHedUQvSLF0uRaj0CvzY0k4RgZ1yFGG7vryX0h2jtf d3BoKuabKLe67ngushbsRUKP+bQ4p2i5lNabIcWWhkPL1rVKHa6wHKZRkalyh/wDRE VX/sOmR+dtUhg== Date: Wed, 1 Jun 2022 18:03:14 -0700 From: Jakub Kicinski To: Rasmus Villemoes Cc: Giuseppe Cavallaro , Alexandre Torgue , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, "David S. Miller" Subject: Re: [PATCH] net: stmmac: use dev_err_probe() for reporting mdio bus registration failure Message-ID: <20220601180314.02e4d84e@kernel.org> In-Reply-To: <20220601142226.1123110-1-linux@rasmusvillemoes.dk> References: <20220601142226.1123110-1-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,MAILING_LIST_MULTI, RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 1 Jun 2022 16:22:26 +0200 Rasmus Villemoes wrote: > if (ret < 0) { > - dev_err(priv->device, > + dev_err_probe(priv->device, ret, > "%s: MDIO bus (id: %d) registration failed", > __func__, priv->plat->bus_id); Please adjust the indent of the continuation lines. And fix the spelling checkpatch also points out.