Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:18 as permitted sender) client-ip=2620:137:e000::1:18;
To:     Tom Rix <trix@redhat.com>
Cc:     njavali@marvell.com, jejb@linux.ibm.com,
        martin.petersen@oracle.com, GR-QLogic-Storage-Upstream@marvell.com,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi: qla2xxx: remove setting of 'req' and 'rsp' parameter
From:   "Martin K. Petersen" <martin.petersen@oracle.com>
Organization: Oracle Corporation
Message-ID: <yq1wndz4wad.fsf@ca-mkp.ca.oracle.com>
References: <20220521201607.4145298-1-trix@redhat.com>
Date:   Wed, 01 Jun 2022 22:46:46 -0400
In-Reply-To: <20220521201607.4145298-1-trix@redhat.com> (Tom Rix's message of
        "Sat, 21 May 2022 16:16:07 -0400")
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?C26DYkRWMZ6tbkLy6f+Wox63UjUMQyaKpRO9GqFFillD/GJb63aM1Y+qP/nz?=
 =?us-ascii?Q?jbLExcxjBxwgp4AcnhtjV9+tGzJWZkCKIGP+28UqtEP4NkqmLdYzigdn9nyM?=
 =?us-ascii?Q?a2Uc0xTdMB8obLPeAMkkSmqm0oixtgm0roVWAnMLzG0NrEmDal/wqVoy6Y/T?=
 =?us-ascii?Q?Big8kHErnAaVARR/Kw2vt3KFWONVzrN6WBRp19q0UmhoIdc2i8JdHs7EAOnz?=
 =?us-ascii?Q?rp5LWZ1JNxIAV2qgHFnknOxKRabVwH5Ue378ATGfpDyPLlDnTlyXve4T5XDr?=
 =?us-ascii?Q?n6ZXBkpCP+H0abw/1ZQ7GahoeCo+Um4E0Jjg0qwUTcT1k4OMQjSmKEZo8KFU?=
 =?us-ascii?Q?M7JPUrcdCs/FOtvXScleQ5DT+gDR+UFfY0W5awYs9+xnb7xmm8vhcZumZ3Ti?=
 =?us-ascii?Q?ALtB2OOBD2FlcjkD1SneQCI/7xtYdvbljvBr7vgDLD8TzGkXyljznWsfUN+S?=
 =?us-ascii?Q?1QkJ/qsYaC0e2O8qW04hJY5xTJjTCLKQ3FRREHbuF3GUrt8K0e3a5xE0on+K?=
 =?us-ascii?Q?sAIrLeV7MeMFjp/7M/zgDhEQ+QbWWckDgJZ0TLG64CJ3E6MQQRrWgNZLGIyW?=
 =?us-ascii?Q?qTpMnDutDfjMsOnxE1P6NCV2M/Hs/m6bXJi4YSQW82FAGGj4JJ9K5SHX+f39?=
 =?us-ascii?Q?b+E3JaDiCr6RExVD/RaxzRfgUiTk9XkHqZFJctDQkkZ4jl1ivXaSmihfNdTp?=
 =?us-ascii?Q?eurWu4ZNKOQyVXMUFQzolU6ZQ6/mwthRyr1j7w708yPvwZoStCVKGdT8D0Rr?=
 =?us-ascii?Q?fZUW2o+NC97b0yBHZzDRKX+K9Yu/5pLGobn2sKKfBDaShV62jc/fVey63X20?=
 =?us-ascii?Q?9HzaQUS/vz4JgfpsrZ/QKF2LojzkfLvSWlAN48oK5UvhQJOvXPBpHu7c0ccq?=
 =?us-ascii?Q?lEhBqp0CeEFuJn8SsCZLxqKpcJcHVGo6Dzub1hKNdLWpwyFxFvR7abYjwrir?=
 =?us-ascii?Q?epIl+U+m7qoISTuV5EVVEkIegC9m8VBVped8rXnlyJ+F2IFIlnHpGMC7eyOO?=
 =?us-ascii?Q?AR+GrjqV10mscV1rNhmCX9+RBp9boj9prMaSwfslXCb1DnStzET4OveDhm9O?=
 =?us-ascii?Q?PiV/Z3upORDCoBz7wB5UmVd0woh++xge5R5llnrbXYtwZnJY9Agx9I93heho?=
 =?us-ascii?Q?pr06iZZN3nWRxPXdLVBxO0FgqzEwtOXa6zwp4U0UJ4td+86HZG/fpSYAZZjX?=
 =?us-ascii?Q?gqFazpz+IlDFrXJ4D0mqs3tCnNXGMXoFZcIfFl2JjSwRzfEg2stDT5s70doC?=
 =?us-ascii?Q?m9OYl7cZ8l8X5XejhvPZLZdRhXXSPotZHEEvyOSphOPa2h2N9LgjRbgen5eI?=
 =?us-ascii?Q?IHEWcQ+SEf9+NvMHF4MAUHR/bCwgNSxoD+KwlGq5wmYv7MkD5S0vw/DnDkaY?=
 =?us-ascii?Q?eU7sHMA/UBN1HDcGd5+mC8erbvtsNXhOqHuejRTyKp9trA67wwdwmi9Bvmc7?=
 =?us-ascii?Q?F/meTMdwGaxdWZanD61s2PYQs51O9MxAR4frhl+bMygStyuoP/N3Un3A/MCN?=
 =?us-ascii?Q?jwPOWeNwiRyz+y/m3l5WnVARlfalMi+da9yNXz7GHZ8y9T21SbeX8mFapyvU?=
 =?us-ascii?Q?+4mNK3mXWK8suyuMEOqPAaQi7oegrpc3Ut04pCO3wFqEdpxUkfnj/R7GwCf8?=
 =?us-ascii?Q?y3d3dDnwQDbWnhAFhHuWjLWx1qlXYw8AgYjVY9j2hRaZPHfp2P9/5KZol44C?=
 =?us-ascii?Q?XihPmbJWenOM1E+TmOyKXFyPnhSuOh07pE2m65hWyIXiGOx9LXXA2yIflV29?=
 =?us-ascii?Q?uQaqYc0S5I+gcxVX7DnnHRQ8OPh1Syw=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 25cde736-497e-4d6f-4979-08da44422384
X-MS-Exchange-CrossTenant-AuthSource: PH0PR10MB4759.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2022 02:46:48.2467
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: XvdMnp+j6506iDYPYSc7QkiK73xE+O9rg8fGx4ZYaYjDXBlb14UG78ZIj8Cd4/cKFFBmcDMrGzKjSbWqyyyfEjxnI+EvxvcgvdbrmDEzbmE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR10MB6158
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-01_09:2022-06-01,2022-06-01 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 mlxlogscore=426
 phishscore=0 suspectscore=0 malwarescore=0 mlxscore=0 adultscore=0
 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206020011
X-Proofpoint-GUID: EFfF3HSu3ASvU9cILJYToEkvjgftnVk-
X-Proofpoint-ORIG-GUID: EFfF3HSu3ASvU9cILJYToEkvjgftnVk-
X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED,
	DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,RDNS_NONE,SPF_HELO_NONE,T_SCC_BODY_TEXT_LINE
	autolearn=no autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
	lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


Tom,

> The functions qla25xx_free_req_que and qla25xx_free_rsp_que are
> similar.  They free a 'req' and a 'rsp' parameter respectively.  The
> last statement of both functions is setting the parameter to NULL.
> This has no effect and can be removed.

Applied to 5.19/scsi-staging, thanks!

-- 
Martin K. Petersen	Oracle Linux Engineering