Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <534a43c8-5491-b57c-292a-dd56d6c8af86@nvidia.com>
Date:   Wed, 1 Jun 2022 20:43:44 -0700
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.5.0
Subject: Re: [PATCH net-next v2] selftests: net: fib_rule_tests: fix support
 for running individual tests
Content-Language: en-US
To:     Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>,
        netdev@vger.kernel.org
Cc:     outreachy@lists.linux.dev, davem@davemloft.net,
        edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
        linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220601174316.4278-1-eng.alaamohamedsoliman.am@gmail.com>
From:   Roopa Prabhu <roopa@nvidia.com>
In-Reply-To: <20220601174316.4278-1-eng.alaamohamedsoliman.am@gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bEtkdVlVa3ZkcHVaMlNVYU9NNjRlYXJxem82N0ZCNnhuR0o2SnR6bCtNaU5a?=
 =?utf-8?B?aXpHS1lEK1pxSzNsYXhSR1Vob1c5TjQ1eGQrb2lvVHNOZytlRXlob1JJZ0VB?=
 =?utf-8?B?NTlvZTZDNkJjR2htTE4xdmJWeGRWNjBiQks5MGhXSGpFRGxtWlVESW9KZTQx?=
 =?utf-8?B?K1dWVDg5ZnRUa1pqRHNyOVhQNVJwQ09UUDhlT1hkS2ZlQWkwOTVSTTF0bXZp?=
 =?utf-8?B?QXVHemJPNzFyYVpxS2RKQk5EdmlNT2FYblNwb212OVNWbVRLMDV2bS9uSmNT?=
 =?utf-8?B?dFN2RTZhQ3pQcERRTEdKM1dUcC84NGE0S2ZIZFV6cFJiSlZsN3BoZUFpMzdq?=
 =?utf-8?B?ckFGbjgzcXErZnAwejErVW1rVmk1OGhwazc3MVNRUThRbFlBcGpIWEV3R0VF?=
 =?utf-8?B?bVBIdG84U2M1WmlieEVoUFh4Y0JhTUdMUmFJdlRSMVFRSzBsejZmenRiK25l?=
 =?utf-8?B?ZXdYbWpBWGMycXdXVjQrTHptQXFBR3VCUWtlYWNiN2JiSHZOVE5Hc3FRT2tD?=
 =?utf-8?B?aXhnVDlGamR1REFqU21kMFJ4bHg5dnB5T3pKaERhN0g2NzdYTUszby9UMTBR?=
 =?utf-8?B?WGV3THp6NzQ4TFRVbUFCdi9IVnQrMUI4L2NvTzhIM1hUcndSbDVxaEtSUUlF?=
 =?utf-8?B?TE00c2Rad0VDcDV0dURwb3pyNTlORWd0ckkyNUtMT0xuNHd0YTRjM2JMMmN2?=
 =?utf-8?B?VXRVVERGVmR6a2gzUFlDK2ZvdlFMdnoxSW1KMDlvS0dScEdGTDRiNEZiRW1y?=
 =?utf-8?B?cFhQdUtvNW9OOVFpNndzRzNnY21xY3V1bnp4NVhnMTVRZEZxanZWa0pzY1dj?=
 =?utf-8?B?ZWFLUnQ1Q2RUTlhlajdheUlSVnBCODRycTlCaHdqTnNadk5PSURPdmpQdmd4?=
 =?utf-8?B?bW9lSzRFZGdyUlZZQmtWWXppQjVkVTY1MDJRUmEzTXEvajZTTGdKVGtndXdp?=
 =?utf-8?B?a2FENENNV1RwRm15b1BiRm9ma0o2aWZ3SjR4MWVIT2NucG1xT09RV1dLTE9s?=
 =?utf-8?B?VmtMelR2TVNmS2ZOaDVyRU1YSGphQ3E0dlpjVElMTTBUSUE2by81c2RMbUlF?=
 =?utf-8?B?RlZQUFJkTlRzc09GY2ZGQURMLzh0UmtjTjNObUxENUN6ZFFoUEFOandWTmdr?=
 =?utf-8?B?SDc5YVB4MXA2OHo2aHRkMitUVHdLRjdQZis1YXhQd2FvZEI3alBYRU8yS3hZ?=
 =?utf-8?B?RE9KUmIzUWlBN3FRRGtzbXBla2g2U3EvR1N3ZmQ3SXpFT2lhbmJ2QkpHN0tD?=
 =?utf-8?B?SjNDTGdoaHVyZU8zQUZnNUV2R2s1cEZCbGdYWkZJdGljdlluOERVbGhReXdW?=
 =?utf-8?B?b1ZFV3NuckxWcFV5WCtGZ2g4eC9RTFpDYjdIYUY5Ukt5cFlYWmFVckR0WkVZ?=
 =?utf-8?B?MERER3dVTmNyR2ZseG5UVmZ2enAzT0swd0M1UnUyNjgwSmVZd0hySXpLU3hM?=
 =?utf-8?B?L0hVM2pmUDRNZytaUDlnZmVXK2c3SkpKUDlBc1R4VVRtUFMwT04wR0lpM2JN?=
 =?utf-8?B?L2NQUjE2MUFNK0s2T09PakVKajVzTWFxc3VuV2RxSzhzOVZacS9HczRJM1pR?=
 =?utf-8?B?aWxDYllYb2YzdWI1TWU2bU03QlVUaWlCZ09PVmRjWjB2MHYwMy9pd0VlSysx?=
 =?utf-8?B?Q2xIWTkwbDQzenpGbG9EbkxqeVNyaHlZdE9lVGVwcUZvMUFhaUMwVW10S2t6?=
 =?utf-8?B?Smt1UmVqbHBFMDkyQlo4UndUdHppUW5BVjV6bkg5bnJDUWcyWkFTeFV6YzVK?=
 =?utf-8?B?UUMvM1BkbXdJaG11Qk01TlQyRTFOcUVLcHFnV2hkMDZhVzVOYnFvaDhyYXdX?=
 =?utf-8?B?UEdESU44dGVXcUVSWWVVRHZJam9IMnlqZnEvU3FCZ1hhRmxWTjlDVkpzSDlQ?=
 =?utf-8?B?VGE3bkZranZGN0F6ODZlaG9GWWZjOFBaRHlxbUE3cUtJb3NXUkVEMk8wSnpJ?=
 =?utf-8?B?UW5JNEtrMVBBMmVoKzJoVmZJMFROUmkyblFlTGlJZ2FhSXdRcDFqMDg4dncx?=
 =?utf-8?B?NmdvSnJ2c2U0NFN4Rm5uOFpqZ0hxQ0VTNlVvSTRyaWdBNkphRDJwMWwzc2Jx?=
 =?utf-8?B?MWMvOHZGZmZibFg0c2xFNFA0bEtiMTZqNnVsdVZYdnVHdzFUWW5xb081MVh1?=
 =?utf-8?B?TFRiL0thbnBYN0NoNXRkZkRWeUZZb0ExVWxmNWpReVduUVEzZW1JanY2b3dO?=
 =?utf-8?B?aUVTOXFmaU5oTkJCT3NjL1JKZkFaUHI2RVVEZFFNRDlyOUtGMjFWT2ZsbTdM?=
 =?utf-8?B?SW5JRllveFdHMFhoZlorbFNOdUFTNGJLV3lOeGlhSVFPME9aSUVXcEtLN1o3?=
 =?utf-8?B?UThqcHgxMWN6d1YyM3hVMXUxeC9oMmFwSndWamdwUjVvWHcrOHFLZz09?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ce4ba6a2-ead2-4e42-8758-08da444a1971
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR12MB5504.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2022 03:43:47.3672
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: YIp7akzSbX8e3T/a9TFqDwdyjh2Rf4YkIRhq6Fd2SPfKWcfEuwcgeFBXdhp/UvovkN2EoHN3c4poiHROqGvj9w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB2944
X-Spam-Status: No, score=-2.9 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FORGED_SPF_HELO,
        NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,
        SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no
        version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 6/1/22 10:43, Alaa Mohamed wrote:
> parsing and usage of -t got missed in the previous patch.
> this patch fixes it
>
> Signed-off-by: Alaa Mohamed <eng.alaamohamedsoliman.am@gmail.com>
> ---

Alaa, need a v3 with Fixes tag

Fixes: 816cda9ae531 ("selftests: net: fib_rule_tests: add support to 
select a test to run")

do a git log and grep for "Fixes:" to see an example


> changes in v2:
> 	edit commit subject and message.
> ---
>   tools/testing/selftests/net/fib_rule_tests.sh | 23 +++++++++++++++++++
>   1 file changed, 23 insertions(+)
>
> diff --git a/tools/testing/selftests/net/fib_rule_tests.sh b/tools/testing/selftests/net/fib_rule_tests.sh
> index bbe3b379927a..c245476fa29d 100755
> --- a/tools/testing/selftests/net/fib_rule_tests.sh
> +++ b/tools/testing/selftests/net/fib_rule_tests.sh
> @@ -303,6 +303,29 @@ run_fibrule_tests()
>   	log_section "IPv6 fib rule"
>   	fib_rule6_test
>   }
> +################################################################################
> +# usage
> +
> +usage()
> +{
> +	cat <<EOF
> +usage: ${0##*/} OPTS
> +
> +        -t <test>   Test(s) to run (default: all)
> +                    (options: $TESTS)
> +EOF
> +}
> +
> +################################################################################
> +# main
> +
> +while getopts ":t:h" opt; do
> +	case $opt in
> +		t) TESTS=$OPTARG;;
> +		h) usage; exit 0;;
> +		*) usage; exit 1;;
> +	esac
> +done
>   
>   if [ "$(id -u)" -ne 0 ];then
>   	echo "SKIP: Need root privileges"