Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220510023255.1283529-1-starzhangzsd@gmail.com>
In-Reply-To: <20220510023255.1283529-1-starzhangzsd@gmail.com>
From:   Stephen Zhang <starzhangzsd@gmail.com>
Date:   Thu, 2 Jun 2022 14:23:43 +0800
Message-ID: <CANubcdVNEsJvGz+gpJjvF14_D_+K9Xv5UtQJdf9s1o07ghFY1A@mail.gmail.com>
Subject: Re: [PATCH v3] pcmcia: add MIPS_DB1XXX dependence
To:     linux@dominikbrodowski.net, Jonathan.Cameron@huawei.com,
        broonie@kernel.org, arnd@arndb.de, lukas.bulwahn@gmail.com,
        daniel@zonque.org
Cc:     zhangshida <zhangshida@kylinos.cn>, linux-kernel@vger.kernel.org,
        k2ci <kernel-bot@kylinos.cn>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

ping

Stephen Zhang <starzhangzsd@gmail.com> =E4=BA=8E2022=E5=B9=B45=E6=9C=8810=
=E6=97=A5=E5=91=A8=E4=BA=8C 10:33=E5=86=99=E9=81=93=EF=BC=9A
>
> From: Shida Zhang <zhangshida@kylinos.cn>
>
> drivers/pcmcia/db1xxx_ss.c uses the bcsr_xxxx() from
> arch/mips/alchemy/devboards/bcsr.c, which causes a link
> error:
>
> drivers/pcmcia/db1xxx_ss.c:(.text+0x2b4): undefined reference to `bcsr_re=
ad'
> mips-linux-gnu-ld: ../drivers/pcmcia/db1xxx_ss.c:(.text+0x2fc): undefined=
 reference to `bcsr_read'
> drivers/pcmcia/db1xxx_ss.c:(.text+0x374): undefined reference to `bcsr_re=
ad'
> mips-linux-gnu-ld: ../drivers/pcmcia/db1xxx_ss.c:(.text+0x380): undefined=
 reference to `bcsr_read'
> drivers/pcmcia/db1xxx_ss.c:(.text+0x534): undefined reference to `bcsr_re=
ad'
> drivers/pcmcia/db1xxx_ss.c:(.text+0xcc8): undefined reference to `bcsr_mo=
d'
>
>
> So add MIPS_DB1XXX dependence.
>
> Reported-by: k2ci <kernel-bot@kylinos.cn>
> Signed-off-by: Shida Zhang <zhangshida@kylinos.cn>
> Acked-by: Arnd Bergmann <arnd@arndb.de>
> ---
> Changes from v1:
> - Rewrite the commit message.
> Changes from v2:
> - Give credit to k2ci for reporting the issue.
> ---
>  drivers/pcmcia/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pcmcia/Kconfig b/drivers/pcmcia/Kconfig
> index 2ce261cfff8e..04b51cb67fbf 100644
> --- a/drivers/pcmcia/Kconfig
> +++ b/drivers/pcmcia/Kconfig
> @@ -151,7 +151,7 @@ config TCIC
>
>  config PCMCIA_ALCHEMY_DEVBOARD
>         tristate "Alchemy Db/Pb1xxx PCMCIA socket services"
> -       depends on MIPS_ALCHEMY && PCMCIA
> +       depends on MIPS_ALCHEMY && MIPS_DB1XXX && PCMCIA
>         help
>           Enable this driver of you want PCMCIA support on your Alchemy
>           Db1000, Db/Pb1100, Db/Pb1500, Db/Pb1550, Db/Pb1200, DB1300
> --
> 2.30.2
>