Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Imran Khan <imran.f.khan@oracle.com>
To:     tj@kernel.org, viro@zeniv.linux.org.uk, gregkh@linuxfoundation.org
Cc:     matthew.wilcox@oracle.com, konrad.wilk@oracle.com,
        linux-kernel@vger.kernel.org
Subject: [PATCH RESEND v4 4/4] kernfs: Replace global kernfs_open_file_mutex with hashed mutexes.
Date:   Thu,  2 Jun 2022 16:39:07 +1000
Message-Id: <20220602063907.136569-5-imran.f.khan@oracle.com>
In-Reply-To: <20220602063907.136569-1-imran.f.khan@oracle.com>
References: <20220602063907.136569-1-imran.f.khan@oracle.com>
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?neqH/diUXa42mJMGrqmqzmgdpjgeIsUaILRx7j4X3ekQ/aiGk8phwBP9V0ds?=
 =?us-ascii?Q?+eYNaidwMEM6wI2AVM6uj8Tg8kqlXvep6gHe8UAzS/Gh/7eEoLDZmHtwZg24?=
 =?us-ascii?Q?F2npzFsQClZXyoFDO0A6bDmiipgxYO8ZuC1RATH2qRZ5XYVhxcjB+sUVRZst?=
 =?us-ascii?Q?FQx+traAOHc1ffkIFwYRwhoxNW7DrkrafHqDRYdLRnzk6FH46PdpkrDiy6CY?=
 =?us-ascii?Q?NASx0pdWrMEcgT/wUtiT0LBJjRWy4rKLjvPLrnikpU0+C9FFdNfPW7piMGTH?=
 =?us-ascii?Q?ga6DspsUFeWxXWAmJmcjYao4RYPQKELpXqIxy6hxM2Uf1kL/2zEnc/Rcvhe/?=
 =?us-ascii?Q?TLW1cj/texunwvneeyqr6Pu1mIHTYJT6/xRK0DbeRrCfLIhMoBPgyGTHUE9r?=
 =?us-ascii?Q?kHAjPo82fyLoTSRyiOhJNvIE1OjO9OVg/Vyd08OPjA+OEw9StIByuI76I31M?=
 =?us-ascii?Q?GrbFDyzSouus0y69fzqevLrTE/GKMxtvpKDSy9UM+KHBXCBjlmzmKwIs9X7b?=
 =?us-ascii?Q?TMUzzhPQJOh0gRLF06Bnx8q8Qi9LFdAJha/7G4suD4gVeWLYo7zYl49R7ndD?=
 =?us-ascii?Q?sueRo+aVEFHB2IdidNqYiM9oetqVTVsPjAoEZpngyAyB/wVNvwIU+z28zNDc?=
 =?us-ascii?Q?IWXkcoUSUnvDCdZTC9JIetB3fqwDkZI+q0D4a8BYQjhAN2IPiRJQfv3zmbab?=
 =?us-ascii?Q?vW+Wl4dp96o4umwnVoDktwtyKOIg+BWqTra5v8YWPcODZ1aqJeTaSOXWsZOo?=
 =?us-ascii?Q?5ISsFQRQRzc1vTOfeerQ4Lr/EU2ziuDsPYNS6HWB1pmtR3SVg//NGfTeE2Qn?=
 =?us-ascii?Q?Nk2ngzMWKTXU0ScdPg6yHPhVMp9+Dd4r01O630L2qZBvqn7T9ivcJ3axmpyO?=
 =?us-ascii?Q?M46D6V8hvhvTnCxsKSAMMEIThCxVTqTxc6e9ghKQ6sQ7C7a9Ln/GynpMqXa0?=
 =?us-ascii?Q?QtU0pveWlRRTJvztMyOMAr1IfdV4qzMhtR9fWday6rZEyfvW6feDG3Wl2VMl?=
 =?us-ascii?Q?A2+Iyl3Hj1vv/r7+tB+BgJFq85kEahWgMviMRAr2e/EFItFgwbzWDcd9HnNR?=
 =?us-ascii?Q?TqAGGZRPCdGHFbekRJo4fgoOXXXjavU5tycb4rTxXDIhe12MzyU3nmnBuC/3?=
 =?us-ascii?Q?0p3IPA5QglHWyyFKtldnh3gmYSzLguoyPfpW6Yl/iDZmcUtt+HLNRDV4xmty?=
 =?us-ascii?Q?hirjclWIwybgdRJLGBN5VJfc/hcEJXjakM8FYlA8JgYcf4Hr0/zAxbNFlqZ2?=
 =?us-ascii?Q?gdpGEzie61V9TEx+h4IkXH+DG+eViyZdZSJMstM/fOA4ayCxfmWQJN20xP0h?=
 =?us-ascii?Q?f+dlcdlkMwArcVzpJWT5SReP6TnT41W6U1dH2aWVA4+EMHSQLrGm92tCb4Tz?=
 =?us-ascii?Q?je1f3NucR9yT8Tv+30pY7t5MvnZ7fKQBvPQSoQTtttwWO1Eb+gtJSdKe4hFU?=
 =?us-ascii?Q?8c2cxOG+LRY8IedWdO9m6qRfUok1dc2U1jxmFdCCK4FpbXAuEop78qc08t7x?=
 =?us-ascii?Q?k1KD/zz3sAyVj5D3K5iviAMFFU9uMiKbGdtREQvH8batSKLPu18uSxi9b2op?=
 =?us-ascii?Q?k53C4dpSVF2rfD3mCcZMP2bgrurXhsm9ZhxdNpr56bh/mt2nibkGmWyG9ghz?=
 =?us-ascii?Q?3hA4sAoLKy5ghGc7HuZVsBkO8bfr6vMdMnFLZ9E8UOgbRrhaK1cawmdToMON?=
 =?us-ascii?Q?RGBXqOtVrZScYTzEDHvIB5FvIaSH4iaMYtfwWOU5hUTh2uwQ6g7R40IvdGSo?=
 =?us-ascii?Q?45TsgEduCSp9Sk/2gkjzP3rcVAHg4M4=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 26f8fdb1-33b1-48b9-f5ad-08da4462a59e
X-MS-Exchange-CrossTenant-AuthSource: CO1PR10MB4468.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2022 06:39:30.7019
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: PLsF8Cmhnx9A4syYANa6Xkqcxm5S8/RT8pDuRWyhLbMYg3/8Ysfx02v/OjCmqTVOGGwQ2UCHZZRezK+G77BBaw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR10MB5845
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-02_01:2022-06-01,2022-06-02 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 suspectscore=0
 malwarescore=0 mlxscore=0 mlxlogscore=999 adultscore=0 bulkscore=0
 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206020024
X-Proofpoint-GUID: j-JHfHAlThFJeXEcL16yZe4gjSTJdiUx
X-Proofpoint-ORIG-GUID: j-JHfHAlThFJeXEcL16yZe4gjSTJdiUx
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

In current kernfs design a single mutex, kernfs_open_file_mutex, protects
the list of kernfs_open_file instances corresponding to a sysfs attribute.
So even if different tasks are opening or closing different sysfs files
they can contend on osq_lock of this mutex. The contention is more apparent
in large scale systems with few hundred CPUs where most of the CPUs have
running tasks that are opening, accessing or closing sysfs files at any
point of time.

Using hashed mutexes in place of a single global mutex, can significantly
reduce contention around global mutex and hence can provide better
scalability. Moreover as these hashed mutexes are not part of kernfs_node
objects we will not see any singnificant change in memory utilization of
kernfs based file systems like sysfs, cgroupfs etc.

Modify interface introduced in previous patch to make use of hashed
mutexes. Use kernfs_node address as hashing key.

Signed-off-by: Imran Khan <imran.f.khan@oracle.com>
Acked-by: Tejun Heo <tj@kernel.org>
---
 fs/kernfs/file.c            | 17 ++---------
 fs/kernfs/kernfs-internal.h |  4 +++
 fs/kernfs/mount.c           | 19 +++++++++++++
 include/linux/kernfs.h      | 57 +++++++++++++++++++++++++++++++++++++
 4 files changed, 83 insertions(+), 14 deletions(-)

diff --git a/fs/kernfs/file.c b/fs/kernfs/file.c
index d35d01d30fa0..987ef7165acc 100644
--- a/fs/kernfs/file.c
+++ b/fs/kernfs/file.c
@@ -18,19 +18,6 @@
 
 #include "kernfs-internal.h"
 
-/*
- * There's one kernfs_open_file for each open file and one kernfs_open_node
- * for each kernfs_node with one or more open files.
- *
- * kernfs_node->attr.open points to kernfs_open_node.  attr.open is
- * RCU protected.
- *
- * filp->private_data points to seq_file whose ->private points to
- * kernfs_open_file.  kernfs_open_files are chained at
- * kernfs_open_node->files, which is protected by kernfs_open_file_mutex.
- */
-static DEFINE_MUTEX(kernfs_open_file_mutex);
-
 struct kernfs_open_node {
 	struct rcu_head		rcu_head;
 	atomic_t		event;
@@ -51,7 +38,9 @@ static LLIST_HEAD(kernfs_notify_list);
 
 static inline struct mutex *kernfs_open_file_mutex_ptr(struct kernfs_node *kn)
 {
-	return &kernfs_open_file_mutex;
+	int idx = hash_ptr(kn, NR_KERNFS_LOCK_BITS);
+
+	return &kernfs_locks->open_file_mutex[idx];
 }
 
 static inline struct mutex *kernfs_open_file_mutex_lock(struct kernfs_node *kn)
diff --git a/fs/kernfs/kernfs-internal.h b/fs/kernfs/kernfs-internal.h
index eeaa779b929c..3ae214d02d44 100644
--- a/fs/kernfs/kernfs-internal.h
+++ b/fs/kernfs/kernfs-internal.h
@@ -164,4 +164,8 @@ void kernfs_drain_open_files(struct kernfs_node *kn);
  */
 extern const struct inode_operations kernfs_symlink_iops;
 
+/*
+ * kernfs locks
+ */
+extern struct kernfs_global_locks *kernfs_locks;
 #endif	/* __KERNFS_INTERNAL_H */
diff --git a/fs/kernfs/mount.c b/fs/kernfs/mount.c
index cfa79715fc1a..d0859f72d2d6 100644
--- a/fs/kernfs/mount.c
+++ b/fs/kernfs/mount.c
@@ -20,6 +20,7 @@
 #include "kernfs-internal.h"
 
 struct kmem_cache *kernfs_node_cache, *kernfs_iattrs_cache;
+struct kernfs_global_locks *kernfs_locks;
 
 static int kernfs_sop_show_options(struct seq_file *sf, struct dentry *dentry)
 {
@@ -387,6 +388,22 @@ void kernfs_kill_sb(struct super_block *sb)
 	kfree(info);
 }
 
+static void __init kernfs_mutex_init(void)
+{
+	int count;
+
+	for (count = 0; count < NR_KERNFS_LOCKS; count++)
+		mutex_init(&kernfs_locks->open_file_mutex[count]);
+}
+
+static void __init kernfs_lock_init(void)
+{
+	kernfs_locks = kmalloc(sizeof(struct kernfs_global_locks), GFP_KERNEL);
+	WARN_ON(!kernfs_locks);
+
+	kernfs_mutex_init();
+}
+
 void __init kernfs_init(void)
 {
 	kernfs_node_cache = kmem_cache_create("kernfs_node_cache",
@@ -397,4 +414,6 @@ void __init kernfs_init(void)
 	kernfs_iattrs_cache  = kmem_cache_create("kernfs_iattrs_cache",
 					      sizeof(struct kernfs_iattrs),
 					      0, SLAB_PANIC, NULL);
+
+	kernfs_lock_init();
 }
diff --git a/include/linux/kernfs.h b/include/linux/kernfs.h
index 2dd9c8df0f4f..13e703f615f7 100644
--- a/include/linux/kernfs.h
+++ b/include/linux/kernfs.h
@@ -18,6 +18,7 @@
 #include <linux/uidgid.h>
 #include <linux/wait.h>
 #include <linux/rwsem.h>
+#include <linux/cache.h>
 
 struct file;
 struct dentry;
@@ -34,6 +35,62 @@ struct kernfs_fs_context;
 struct kernfs_open_node;
 struct kernfs_iattrs;
 
+/*
+ * NR_KERNFS_LOCK_BITS determines size (NR_KERNFS_LOCKS) of hash
+ * table of locks.
+ * Having a small hash table would impact scalability, since
+ * more and more kernfs_node objects will end up using same lock
+ * and having a very large hash table would waste memory.
+ *
+ * At the moment size of hash table of locks is being set based on
+ * the number of CPUs as follows:
+ *
+ * NR_CPU      NR_KERNFS_LOCK_BITS      NR_KERNFS_LOCKS
+ *   1                  1                       2
+ *  2-3                 2                       4
+ *  4-7                 4                       16
+ *  8-15                6                       64
+ *  16-31               8                       256
+ *  32 and more         10                      1024
+ *
+ * The above relation between NR_CPU and number of locks is based
+ * on some internal experimentation which involved booting qemu
+ * with different values of smp, performing some sysfs operations
+ * on all CPUs and observing how increase in number of locks impacts
+ * completion time of these sysfs operations on each CPU.
+ */
+#ifdef CONFIG_SMP
+#define NR_KERNFS_LOCK_BITS (2 * (ilog2(NR_CPUS < 32 ? NR_CPUS : 32)))
+#else
+#define NR_KERNFS_LOCK_BITS     1
+#endif
+
+#define NR_KERNFS_LOCKS     (1 << NR_KERNFS_LOCK_BITS)
+
+/*
+ * There's one kernfs_open_file for each open file and one kernfs_open_node
+ * for each kernfs_node with one or more open files.
+ *
+ * filp->private_data points to seq_file whose ->private points to
+ * kernfs_open_file.
+ *
+ * kernfs_open_files are chained at kernfs_open_node->files, which is
+ * protected by kernfs_global_locks.open_file_mutex[i].
+ *
+ * To reduce possible contention in sysfs access, arising due to single
+ * locks, use an array of locks (e.g. open_file_mutex) and use kernfs_node
+ * object address as hash keys to get the index of these locks.
+ *
+ * Hashed mutexes are safe to use here because operations using these don't
+ * rely on global exclusion.
+ *
+ * In future we intend to replace other global locks with hashed ones as well.
+ * kernfs_global_locks acts as a holder for all such hash tables.
+ */
+struct kernfs_global_locks {
+	struct mutex open_file_mutex[NR_KERNFS_LOCKS];
+};
+
 enum kernfs_node_type {
 	KERNFS_DIR		= 0x0001,
 	KERNFS_FILE		= 0x0002,
-- 
2.30.2