Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp6297865ioo; Thu, 2 Jun 2022 03:30:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzvXgwIWMTegBzyT8ZJHKfQfE+EFSnJfMdwE+wdLgNLTXSLJVXPQXbXm2BEQs0VpiOPmFQ3 X-Received: by 2002:a17:907:2d1e:b0:6fe:c5a3:4874 with SMTP id gs30-20020a1709072d1e00b006fec5a34874mr3663888ejc.61.1654165846458; Thu, 02 Jun 2022 03:30:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654165846; cv=none; d=google.com; s=arc-20160816; b=k/RErOfyWbHWupXF/onNKP+oR2l6XLjGXnOpiuttLV7qJpi36M751oScDjZYKL+Vjk X5Z+M2lm00ZESj/OWDWKD4T0qGNfgv2uG403NKT7pZUtIKgSFi2kotoxYTVJ8b04TE2w bdDs9nH98zaWlik0EYQekHGgIthjFvIcCWNop/LROs3WDan8BhPGZ/eEvqEG6P5BEoF0 qrQs1lg1AoWpG7BqjITh+jz88S5eMMWTHeSL0MO+xKh2MZa4M/FyvjMYa43z9Ow0xfh1 vwFEYmBA/ONEf4v9inG9A1tRUm7wV1lJrTuS0Ai1H01SwfZH2pg7sE4TOQTLtiq7KVro PK2A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=nY3s5pwGYz7yVgsJYT451g7kmaGWXBN97cwYanxG+aU=; b=cSKkwnfd+DXncOmyOoXCxgTv2NCA+cDQMslyZDksgWEmzt2joODxz+V7hKVwcPc/A+ AKOjcYRl3SM34kMHPXiDa6fCZsGSL/ZQmgeFWN/E0V+k3uzGqMTa7KsTMy7Ed9ByBt4c lyUACV9tlwkjxlL8rwzQ0si/qWy3FT28LSH9Yii52Cj2GZhSeHj2bzcPzAIEnoIBOtFR qaFsmOUiZP5Lnmb2Ce7D68+W7nMQQvShmbPChh1YDGGWk9TV2m6kqr8+fjgC8PKQmXTw 1Y4rQ1AeAI2l8GYab7TyQfLney2OfpogeAN4z4ueEjUqosKyqpNT85wuwH9nOnGrkyHg +tog== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@metrotek.ru header.s=mail header.b=gHsWm1EX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id gb3-20020a170907960300b006fed9433169si4895420ejc.826.2022.06.02.03.30.20; Thu, 02 Jun 2022 03:30:46 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=fail header.i=@metrotek.ru header.s=mail header.b=gHsWm1EX; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232809AbiFBJIz (ORCPT + 99 others); Thu, 2 Jun 2022 05:08:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231569AbiFBJIm (ORCPT ); Thu, 2 Jun 2022 05:08:42 -0400 Received: from mail.pr-group.ru (mail.pr-group.ru [178.18.215.3]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 48A882010DA; Thu, 2 Jun 2022 02:08:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=metrotek.ru; s=mail; h=from:subject:date:message-id:to:cc:mime-version:content-transfer-encoding; bh=GQmIjedgQb9DY7Mgnqkz3jdM5XV3TNvTH/CR49OuWb0=; b=gHsWm1EXamIrs35nDXgIwXT+l+zmQlSIKRzjwQbohbvy8q0tc5piCTisYUAHWfzwSHfFZB2rOVzWY HF9+De3bDQNPnVbjxEtZqJKb6lUkrwaXFYKLXdg8EZkzYUuYtF+RbUMObSkCWfkPaq9uIjXCxvEYk0 UieIKmq7qAN7Gs0fR3Av4fcHMUqIzoiIRk8giRVS9aUFj8Rqh/NprMGFezGCQIFhj9qAWz//IsKbs2 Yaj4IPTWHNx3iiBlnTPCXZJ0ZIrHJlhJ31EZrTeqBiTsMX2jsghXWmDgLAE8SMCx1fNankKMpbMMsd /C6sWiBj/Q3WyQ6wjHerrnyAJvHgadg== X-Kerio-Anti-Spam: Build: [Engines: 2.16.3.1424, Stamp: 3], Multi: [Enabled, t: (0.000010,0.016292)], BW: [Enabled, t: (0.000014,0.000001)], RTDA: [Enabled, t: (0.083076), Hit: No, Details: v2.39.0; Id: 15.52kcej.1g4hqofpo.mdnu; mclb], total: 0(700) X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Level: X-Footer: bWV0cm90ZWsucnU= Received: from localhost.localdomain ([178.70.36.174]) (authenticated user i.bornyakov@metrotek.ru) by mail.pr-group.ru with ESMTPSA (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256 bits)); Thu, 2 Jun 2022 12:08:17 +0300 From: Ivan Bornyakov To: mdf@kernel.org, hao.wu@intel.com, yilun.xu@intel.com, trix@redhat.com Cc: Ivan Bornyakov , Conor.Dooley@microchip.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-fpga@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, system@metrotek.ru Subject: [PATCH v15 0/3] Microchip Polarfire FPGA manager Date: Thu, 2 Jun 2022 11:45:47 +0300 Message-Id: <20220602084550.4380-1-i.bornyakov@metrotek.ru> X-Mailer: git-send-email 2.35.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Add support to the FPGA manager for programming Microchip Polarfire FPGAs over slave SPI interface with .dat formatted bitsream image. Changelog: v1 -> v2: fix printk formating v2 -> v3: * replace "microsemi" with "microchip" * replace prefix "microsemi_fpga_" with "mpf_" * more sensible .compatible and .name strings * remove unused defines STATUS_SPI_VIOLATION and STATUS_SPI_ERROR v3 -> v4: fix unused variable warning Put 'mpf_of_ids' definition under conditional compilation, so it would not hang unused if CONFIG_OF is not enabled. v4 -> v5: * prefix defines with MPF_ * mdelay() -> usleep_range() * formatting fixes * add DT bindings doc * rework fpga_manager_ops.write() to fpga_manager_ops.write_sg() We can't parse image header in write_init() because image header size is not known beforehand. Thus parsing need to be done in fpga_manager_ops.write() callback, but fpga_manager_ops.write() also need to be reenterable. On the other hand, fpga_manager_ops.write_sg() is called once. Thus, rework usage of write() callback to write_sg(). v5 -> v6: fix patch applying I forgot to clean up unrelated local changes which lead to error on patch 0001-fpga-microchip-spi-add-Microchip-MPF-FPGA-manager.patch applying on vanilla kernel. v6 -> v7: fix binding doc to pass dt_binding_check v7 -> v8: another fix for dt_binding_check warning v8 -> v9: * add another patch to support bitstream offset in FPGA image buffer * rework fpga_manager_ops.write_sg() back to fpga_manager_ops.write() * move image header parsing from write() to write_init() v9 -> v10: * add parse_header() callback to fpga_manager_ops * adjust fpga_mgr_write_init[_buf|_sg]() for parse_header() usage * implement parse_header() in microchip-spi driver v10 -> v11: include missing unaligned.h to microchip-spi fix error: implicit declaration of function 'get_unaligned_le[16|32]' v11 -> v12: * microchip-spi: double read hw status, ignore first read, because it can be unreliable. * microchip-spi: remove sleep between status readings in poll_status_not_busy() to save a few seconds. Status is polled on every 16 byte writes - that is quite often, therefore usleep_range() accumulate to a considerable number of seconds. v12 -> v13: * fpga-mgr: separate fpga_mgr_parse_header_buf() from fpga_mgr_write_init_buf() * fpga-mgr: introduce FPGA_MGR_STATE_PARSE_HEADER and FPGA_MGR_STATE_PARSE_HEADER_ERR fpga_mgr_states * fpga-mgr: rename fpga_mgr_write_init_sg() to fpga_mgr_prepare_sg() and rework with respect to a new fpga_mgr_parse_header_buf() * fpga-mgr: rework write accounting in fpga_mgr_buf_load_sg() for better clarity * microchip-spi: rename MPF_STATUS_POLL_TIMEOUT to MPF_STATUS_POLL_RETRIES * microchip-spi: add comment about status reading quirk to mpf_read_status() * microchip-spi: rename poll_status_not_busy() to mpf_poll_status() and add comment. * microchip-spi: make if statement in mpf_poll_status() easier to read. v13 -> v14: * fpga-mgr: improvements from Xu Yilun in - fpga_mgr_parse_header_buf() - fpga_mgr_write_init_buf() - fpga_mgr_prepare_sg() - fpga_mgr_buf_load_sg() * fpga-mgr: add check for -EAGAIN from fpga_mgr_parse_header_buf() when called from fpga_mgr_buf_load_mapped() * microchip-spi: remove excessive cs_change from second spi_transfer in mpf_read_status() * microchip-spi: change type of components_size_start, bitstream_start, i from size_t to u32 in mpf_ops_parse_header() v14 -> v15: eliminate memcpy() in mpf_ops_write() Eliminate excessive memcpy() in mpf_ops_write() by using spi_sync_transfer() instead of spi_write(). Ivan Bornyakov (3): fpga: fpga-mgr: support bitstream offset in image buffer fpga: microchip-spi: add Microchip MPF FPGA manager dt-bindings: fpga: add binding doc for microchip-spi fpga mgr .../fpga/microchip,mpf-spi-fpga-mgr.yaml | 44 ++ drivers/fpga/Kconfig | 9 + drivers/fpga/Makefile | 1 + drivers/fpga/fpga-mgr.c | 176 ++++++-- drivers/fpga/microchip-spi.c | 391 ++++++++++++++++++ include/linux/fpga/fpga-mgr.h | 17 +- 6 files changed, 610 insertions(+), 28 deletions(-) create mode 100644 Documentation/devicetree/bindings/fpga/microchip,mpf-spi-fpga-mgr.yaml create mode 100644 drivers/fpga/microchip-spi.c -- 2.35.1