Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <cb35e356-bc90-2a67-6983-1a4c3a0ea62d@linaro.org>
Date:   Thu, 2 Jun 2022 10:37:47 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.7.0
Subject: Re: [PATCH 3/3] thermal/sysfs: Remove cooling device sysfs statistics
Content-Language: en-US
To:     Lukasz Luba <lukasz.luba@arm.com>
Cc:     linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
        rafael@kernel.org, quic_manafm@quicinc.com,
        Amit Kucheria <amitk@kernel.org>,
        Zhang Rui <rui.zhang@intel.com>, Todd Kjos <tkjos@google.com>
References: <20220601151441.9128-1-daniel.lezcano@linaro.org>
 <20220601151441.9128-3-daniel.lezcano@linaro.org>
 <be8395e3-98d7-7a8f-7153-c491b22d4463@arm.com>
From:   Daniel Lezcano <daniel.lezcano@linaro.org>
In-Reply-To: <be8395e3-98d7-7a8f-7153-c491b22d4463@arm.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk


Hi Lukasz,

[Adding Todd]

On 01/06/2022 17:33, Lukasz Luba wrote:
> Hi Daniel,
> 
> 
> On 6/1/22 16:14, Daniel Lezcano wrote:
>> The statistics are for debugging purpose and belong to debugfs rather
>> than sysfs. As the previous changes introduced the same statistics in
>> debugfs, those in sysfs are no longer needed and can be removed.
> 
> I just want to let you know that in current Android kernels we cannot
> even compile the kernel with CONFIG_DEBUG_FS.

Right, it makes sense. Precisely, with the sysfs stats they are always 
compiled in for the Android kernel and is a problem for low memory 
systems. While debugfs can fulfill its purpose in the developement and 
will be removed in production systems.

> I have this pain with
> Energy Model there... Some vendors might see useful info via this
> sysfs interface in bring-up of the SoC.

Well alternatively, information can be extracted from procfs in the 
device-tree description.

What prevents to add energy information in sysfs now that the energy 
model is per device ?

> I don't know if there are user-space tools tracking this
> information via sysfs. We probably should check that.
> 
> I agree that these statistics look more like debug info, rather than
> something useful for control.
> 
> Furthermore, we have trace events for the cooling state changes, which
> should be good enough for bring-up and experiments.
> 
> I don't have strong preferences here. I tend to agree to remove this
> interface if there are no user-space tools using it.

I agree userspace can also get information about the transition but the 
goal of the debugfs is also add information about thermal internals like 
average temperature at mitigation time, min and max, timings, etc ...


-- 
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog