Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Yihao Han <hanyihao@vivo.com>
To:     Hans de Goede <hdegoede@redhat.com>, Helge Deller <deller@gmx.de>,
        linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
        linux-kernel@vger.kernel.org
Cc:     Yihao Han <hanyihao@vivo.com>
Subject: [PATCH] fbdev: simplefb: Check before clk_put() not needed
Date:   Thu,  2 Jun 2022 02:42:18 -0700
Message-Id: <20220602094219.13024-1-hanyihao@vivo.com>
Content-Type: text/plain
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?VNr1WvJpETFGkk6/nDe50RELnVifupDVsnjtQ8ut/V5vXVrb1OkYwpYMcUkD?=
 =?us-ascii?Q?nozalz4Qsv1NwP7opxzTllXjxewlTapTxyjTrGHXmLeju/SvVkwMQ0/oKiTA?=
 =?us-ascii?Q?YuMAiFcaCqUTlRivqa1bjXdVY1YeweFuiV9Er7LjS+Mo5RmopuNUXfgbt2dS?=
 =?us-ascii?Q?Zn7A1qilhH9WOlvy5W67/MSsTnqpjnok1TjTukN9Rzkpe9LrUeTiWNcMy3nL?=
 =?us-ascii?Q?KvIA2n01DcmLuXb+1u0NIDTk61pqXEkmSkyEuQ75QRpIe/XsY8mVvnq2zVDa?=
 =?us-ascii?Q?JE74tQjGH0rz2enFi8jXyi8zH80J2ynwj1fGegsx3sxun9IloQ4Bj4FB5Vhn?=
 =?us-ascii?Q?w5+HxAEQ2tS3tO0+RQ65SSG97+GPCaBRkJlNmwiaAjRoaxhmDC+J9FTK2tQZ?=
 =?us-ascii?Q?alc2YtSqKZ6j8kL95jOwZftkdztxcOMLlPhxVg7UZVChkK/wBm26NuJ0TRLX?=
 =?us-ascii?Q?aySdufQY6jpLMpZD1zGn0cN3CfRy6FFUB4w+pzfvzXz/vbtpWzfsub3M616a?=
 =?us-ascii?Q?/+V/554vLUHdRUcPp2HbGpORTt8k+bEhrYZ7bWrKDDOkxB0hoc9RuZxbDoqf?=
 =?us-ascii?Q?eGOPzPPsjTPe1ZOBE2IAj6aB+l+/27uCVqvEirJH8p7lMUNbnSVhu5TC380z?=
 =?us-ascii?Q?Wii1wxdin1/jdh/h7OmB6zNHPius4WRrMQ2xJprfKMZdsKCXdX0JpzdBGYxI?=
 =?us-ascii?Q?b85hmDK3xnLaQCqmGsxqsHWeSZEyMYgtUk993kJVdZdyXY/Z0zj88EAYMHqN?=
 =?us-ascii?Q?Hgv+6bInYZfBJR5qTWlHTSzcLlmKfNjRG8L5v6xfwb5QpMCkc/iuILU69HkB?=
 =?us-ascii?Q?GzWsMM0sGgKDG13WD/DsQvCMGccmRiSnji0dIs+oDS90IC5lvhJIw1h/XQbq?=
 =?us-ascii?Q?Ax/WUn31xtESlmRRVV9wIXnGj1W6RGOyfzlKb2kbdFGB0sE0a1RzlPjPS5y7?=
 =?us-ascii?Q?4LITGRwbkGUftg5mj7XvqXdR3WKijg0PKOoBT+koLKJ2tENncULnolitnLts?=
 =?us-ascii?Q?/xkwDPUlEA6/5dVDey0XzxoEHQbN5wxuMDVrMxawmH7293oSJGy2BkgznxNY?=
 =?us-ascii?Q?xHjpw/nU/ISgQHP1aDqTOGtE6nLdLc4n/GKRI9hmZ+i6s9ps5vfMa3jj2HTB?=
 =?us-ascii?Q?RZM3QxeEyED6f3KmMBizWX1Jwh5OAkXY4oTyCVC+ViVfwl82MpaHprjH1BA3?=
 =?us-ascii?Q?KHEYFAk0D14I1rySCO3MxdaYLJF5gCZ6+KtPUPBENfQokjMb9GyQldSBVSLF?=
 =?us-ascii?Q?bF7JGHSP/G2Ax+kRA2XGIWuJyR2AEHZE2/CYBsQQH72YeeM9H5FXWqGDNFIU?=
 =?us-ascii?Q?NUNyhnJtR+QX2JaeZzk/yhdzd+PCcoImJLDk0fuCQ0DbCHBaBDob257prsef?=
 =?us-ascii?Q?t5wQKBz22rHOBHrqjSuecWy0EfnuYSKmRWzqufTuymhG7KRVhWM60eiUuRwm?=
 =?us-ascii?Q?k6OJd1w3VIbCEUKsCj72NoVQKx7oQ1K9VV91t48c9mEM1yBLKqeWr2sKuqtk?=
 =?us-ascii?Q?8c9p0I4UePimOQJlBvZ/5oYuHzzRRJcoBNRNcFuZN9IuTkd0dmnp5ceT3st/?=
 =?us-ascii?Q?MgdlMB01R39Wc4aOgtd0nQaz9fO1OFJbQSSZUSuogzA572MsDPmEeKmzuyYi?=
 =?us-ascii?Q?eLrLRAJ6UNkGkW/g901ApDMhXVFy7qKTbt2gULZqQHIEXl5yopMxhxrXuXTK?=
 =?us-ascii?Q?3tUw/NQxLyP6z6ar2Cp1wHkrY4eBB24vw4THsrCj/wQeVZynoNdbzJGGHrnD?=
 =?us-ascii?Q?fuQZmY86jA=3D=3D?=
X-OriginatorOrg: vivo.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 9f8504cf-5519-45b3-9451-08da447c37df
X-MS-Exchange-CrossTenant-AuthSource: TYZPR06MB4173.apcprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2022 09:42:33.2254
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 923e42dc-48d5-4cbe-b582-1a797a6412ed
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jJcU3aaSpLxFGoB8LlLNMoM+JkcKIOOVuWkyeUMbeRSRuM79F1ONF50LXJ/CnnTRtPJU89sd/bLTOprEnLyTJQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: KL1PR0601MB4323
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,
        DKIM_VALID,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_PASS,SPF_PASS,
        T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

clk_put() already checks the clk ptr using !clk and IS_ERR()
so there is no need to check it again before calling it.

Signed-off-by: Yihao Han <hanyihao@vivo.com>
---
 drivers/video/fbdev/simplefb.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/video/fbdev/simplefb.c b/drivers/video/fbdev/simplefb.c
index 2c198561c338..f96ce8801be4 100644
--- a/drivers/video/fbdev/simplefb.c
+++ b/drivers/video/fbdev/simplefb.c
@@ -237,8 +237,7 @@ static int simplefb_clocks_get(struct simplefb_par *par,
 		if (IS_ERR(clock)) {
 			if (PTR_ERR(clock) == -EPROBE_DEFER) {
 				while (--i >= 0) {
-					if (par->clks[i])
-						clk_put(par->clks[i]);
+					clk_put(par->clks[i]);
 				}
 				kfree(par->clks);
 				return -EPROBE_DEFER;
-- 
2.17.1