Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220601100005.2989022-1-chenhuacai@loongson.cn>
 <20220601100005.2989022-4-chenhuacai@loongson.cn> <Yph/Q+szVkhDPg4a@debian.me>
In-Reply-To: <Yph/Q+szVkhDPg4a@debian.me>
From:   Huacai Chen <chenhuacai@gmail.com>
Date:   Thu, 2 Jun 2022 17:26:51 +0800
Message-ID: <CAAhV-H4MeVyT1TVx6gfaYaPU3oNSLUyr4iJpt0-FRCNzPf=jfw@mail.gmail.com>
Subject: Re: [PATCH V12 03/24] Documentation: LoongArch: Add basic documentations
To:     Bagas Sanjaya <bagasdotme@gmail.com>
Cc:     Huacai Chen <chenhuacai@loongson.cn>,
        Arnd Bergmann <arnd@arndb.de>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Airlie <airlied@linux.ie>,
        Jonathan Corbet <corbet@lwn.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-arch <linux-arch@vger.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Xuefeng Li <lixuefeng@loongson.cn>,
        Yanteng Si <siyanteng@loongson.cn>,
        Guo Ren <guoren@kernel.org>, Xuerui Wang <kernel@xen0n.name>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        WANG Xuerui <git@xen0n.name>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi, Bagas,

On Thu, Jun 2, 2022 at 5:13 PM Bagas Sanjaya <bagasdotme@gmail.com> wrote:
>
> On Wed, Jun 01, 2022 at 05:59:44PM +0800, Huacai Chen wrote:
>
> > +Note: The register ``$r21`` is reserved in the ELF psABI, but used by the Linux
> > +kernel for storing the percpu base address. It normally has no ABI name, but is
> > +called ``$u0`` in the kernel. You may also see ``$v0`` or ``$v1`` in some old code,
> > +they are deprecated aliases of ``$a0`` and ``$a1`` respectively.
>
> A nitpick: instead of just comma (,), also use "however" conjunction, that
> is "You may also see ..., however they ... ."
OK, thanks.

Huacai
>
> > +
> > +Note: You may see ``$fv0`` or ``$fv1`` in some old code, they are deprecated
> > +aliases of ``$fa0`` and ``$fa1`` respectively.
> > +
>
> The nitpick above also applies here, too.
>
> Otherwise, htmldocs built successfully without any new warnings.
>
> Tested-by: Bagas Sanjaya <bagasdotme@gmail.com>
>
> --
> An old man doll... just what I always wanted! - Clara