Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 2 Jun 2022 12:45:15 +0200
From:   Steffen Klassert <steffen.klassert@secunet.com>
To:     Stephen Hemminger <stephen@networkplumber.org>
CC:     <netdev@vger.kernel.org>, Herbert Xu <herbert@gondor.apana.org.au>,
        "David S. Miller" <davem@davemloft.net>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] xfrm: convert alg_key to flexible array member
Message-ID: <20220602104515.GI91220@gauss3.secunet.de>
References: <20220524204741.980721-1-stephen@networkplumber.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20220524204741.980721-1-stephen@networkplumber.org>
Precedence: bulk

On Tue, May 24, 2022 at 01:47:40PM -0700, Stephen Hemminger wrote:
> Iproute2 build generates a warning when built with gcc-12.
> This is because the alg_key in xfrm.h API has zero size
> array element instead of flexible array.
> 
>     CC       xfrm_state.o
> In function ‘xfrm_algo_parse’,
>     inlined from ‘xfrm_state_modify.constprop’ at xfrm_state.c:573:5:
> xfrm_state.c:162:32: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
>   162 |                         buf[j] = val;
>       |                         ~~~~~~~^~~~~
> 
> This patch convert the alg_key into flexible array member.
> There are other zero size arrays here that should be converted as
> well.
> 
> This patch is RFC only since it is only compile tested and
> passes trivial iproute2 tests.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

I've put this today to our test systems and it showed no problems,
so we can integrate it after the merge window.