Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp6523852ioo; Thu, 2 Jun 2022 08:08:19 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyQuDfBz+zECpqSYVpuiCLMamBQ/7dtPkHUEDF/IeYsIEw3qq0QUg9JWr2rZptxeYJ0UJBN X-Received: by 2002:a63:144c:0:b0:3fa:6f09:a3e4 with SMTP id 12-20020a63144c000000b003fa6f09a3e4mr4712207pgu.102.1654182499668; Thu, 02 Jun 2022 08:08:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654182499; cv=none; d=google.com; s=arc-20160816; b=wP4v09YhDY6gCMc1bL1DT4jVsBNm74KovWqC4ZYYk/kN0ZfEhdnYGrKpRL2Kj1abv2 nuLy3mABJx5wnPnoaOj1Wa2laxt5Z48awLjSfyxDqrx/OxqHzceO177u/xWmMQZUTKHn 1EoWOhIUlBQiUa0aMYvip4t3chVQ3wzkN3faeN4vgpMzI29GGVTgPr1mHFxB5OEHb2b1 r8ENymKmFEQHAFAIk4uARKizsn8T7coxtWKvRbXERk6di63ssin3dj/Ho7PoPJgPH0J9 55aQiA8CgZAyff/gSIENAoAU1p6fupd51LfwWNapzDyMKeENL7YOztaEQK3R6k4m1HbF e5uQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature :dkim-filter; bh=TJORYCaZwleY0HJ0Sf6EGMw3BDRKmgvS6PExAz6yCvo=; b=kIjIkwDHXRyMRhTrnvSV5AE6peYb4H2Hfct8fdKCVzqhooa0c3ZQ1qGLu51lg77x9M 3fvnqS+3Hr4dIJDiZyx0vJnXBtbSdj4jOYNaZq6dxxaApS6l3/1MJtE4QsHCNtrzbwFi t4eUS0fczyq9xB5BOzJuP9EgBkCOtbo/6/8l1KdTb5JXdgbbR1w3o7DPYojzHraaQSXw Dfv9oCd2oIuel4Y0CSqpkqTJfJdz9VQCfu1DFKvcs+pqgGK7LGVVQ/67r2IpJvnfA92T E4UtLQTfqWeW2d7K+LQs5yqczJnRIVGSZsN1iGw89DiI3oI82MfFYg+cJIC4nVRcUjoI UMgw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@onstation.org header.s=default header.b=W9Zhw8gm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id d9-20020a170902aa8900b00163fbc05bb7si5893409plr.552.2022.06.02.08.08.02; Thu, 02 Jun 2022 08:08:19 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@onstation.org header.s=default header.b=W9Zhw8gm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233104AbiFBJhc (ORCPT + 99 others); Thu, 2 Jun 2022 05:37:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51886 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232172AbiFBJhb (ORCPT ); Thu, 2 Jun 2022 05:37:31 -0400 X-Greylist: delayed 555 seconds by postgrey-1.37 at lindbergh.monkeyblade.net; Thu, 02 Jun 2022 02:37:28 PDT Received: from onstation.org (onstation.org [52.200.56.107]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 75F231FA69; Thu, 2 Jun 2022 02:37:27 -0700 (PDT) Received: from localhost (c-98-239-145-235.hsd1.wv.comcast.net [98.239.145.235]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by onstation.org (Postfix) with ESMTPSA id CB1D841F4AA; Thu, 2 Jun 2022 05:28:11 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.11.0 onstation.org CB1D841F4AA DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=onstation.org; s=default; t=1654162091; bh=TJORYCaZwleY0HJ0Sf6EGMw3BDRKmgvS6PExAz6yCvo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=W9Zhw8gmnLUD6GQQOqxhbKZmH12gqLLXpIYzPr7GHSDLI7htIwMTtmFqeLm4j9Osn 8fa2sKvEcM4pu/TaqXAyjunHdOhLIqpjQzbiirSjQk90qSlSPgMa4thYXAbpnBYf6e vMC7nBD16LPCp21cuuozStBnTxaiFlgKVMjRK2eo= Date: Thu, 2 Jun 2022 05:28:11 -0400 From: Brian Masney To: Miaoqian Lin Cc: Andy Gross , Bjorn Andersson , Rob Clark , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] soc: qcom: ocmem: Fix refcount leak in of_get_ocmem Message-ID: <20220602092811.GA9253@onstation.org> References: <20220602042430.1114-1-linmq006@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220602042430.1114-1-linmq006@gmail.com> X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_PASS, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 02, 2022 at 08:24:30AM +0400, Miaoqian Lin wrote: > of_parse_phandle() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > of_node_put() will check NULL pointer. > > Fixes: 88c1e9404f1d ("soc: qcom: add OCMEM driver") > Signed-off-by: Miaoqian Lin Reviewed-by: Brian Masney