Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 2 Jun 2022 18:33:27 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Alex Deucher <alexdeucher@gmail.com>
Cc:     Ernst =?iso-8859-1?Q?Sj=F6strand?= <ernstp@gmail.com>,
        kbuild-all@lists.01.org, kernel test robot <lkp@intel.com>,
        kbuild@lists.01.org, LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [kbuild] drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1433
 amdgpu_discovery_get_vcn_info() error: buffer overflow
 'adev->vcn.vcn_codec_disable_mask' 2 <= 3
Message-ID: <20220602153326.GI2168@kadam>
References: <202205271546.oV14N2r8-lkp@intel.com>
 <CADnq5_NOkqRsoqELkLayNU+xArXd-4RO=_banvJpXHtSW4-YdA@mail.gmail.com>
 <CAD=4a=WRbp8w4DA2c6hE7W5A2-woRyHLvtC-GPitFwQireCeNw@mail.gmail.com>
 <20220602115046.GH2168@kadam>
 <CADnq5_PZBV0wAnNSLSdTc_8acaK3F6ZKDpcgwktmNaR9DKxG9Q@mail.gmail.com>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CADnq5_PZBV0wAnNSLSdTc_8acaK3F6ZKDpcgwktmNaR9DKxG9Q@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?AY1oFytdZt0N/YbHRM7ShzodLRbCLns9MribDRt6GoGIV94gjWfHPo82VA?=
 =?iso-8859-1?Q?kgTnxfwMGDvGZGP3eG466QBxreTjUGRKMysCJ5EiRHOrgrjb9ERWD/Gtu0?=
 =?iso-8859-1?Q?dNxbfGsJDGlhXdCjUBnpuS3NhhnImikR4+mnj1opXjl8KqvnnPcA0Dqygm?=
 =?iso-8859-1?Q?Z4gMQJLSmt0vzO2blTyVGvixysd2NB3FtxDxCYsKiTcnZiH/LcO2h+EMq3?=
 =?iso-8859-1?Q?Iq12KTcV+pFr1ND2qBWYB0B3aMrNsTHI2bYMnWw6/95z499qLG7ZSqCUPw?=
 =?iso-8859-1?Q?0p9neS9ziwKz5dCV10VGTh00DN9W+dH4AuGqfHmsBZqUzcpYEFfTossn9g?=
 =?iso-8859-1?Q?5WStrXKelqhYFjY23KkZerqrkCkplORLw4yFInWAueBKzh8ECg85lWTPuJ?=
 =?iso-8859-1?Q?gP/TB1IuoxhyUq6rsxpySzHO7hYcmiRRn0Fz0Ue0wbWlAOvimGC0pWCLpp?=
 =?iso-8859-1?Q?syulKBHKLLIDMDaoyR/mkLP+Xl8VBqAPNliaCmsbnhokophEC03vxtX8EK?=
 =?iso-8859-1?Q?SrNzQu+nphx2sYZ5Jnfbi3XQnro4ftAuFleK5x08jh5te0ynE8UOwpXCmB?=
 =?iso-8859-1?Q?NniBG/Ht+OtmQwtJaEeSq1dhfd3DpYkmMWdGVSUQ9GWvQMVj/OUPF9ArdF?=
 =?iso-8859-1?Q?//tNTKQYBhSmw3Rtdfuixk27ycvDnU1zA80sRkbF8XY7Q5g7/4U8nTnVQ0?=
 =?iso-8859-1?Q?ddMArzPREEJTfGY9NqWa81cpcBqE/yULgnea4Q3rZ0nqL8/GkNJgVPPh/A?=
 =?iso-8859-1?Q?upgPr8QMmFAIAdc/mYKv1ctAwTvd/GlsnieKDf5gI2lCF44RGaAD08q2PL?=
 =?iso-8859-1?Q?sH9YYnzZfS4HpSYbYWvS8yiQ8dQo57EC9R72etRdE1lMsnocI23OM5UMtO?=
 =?iso-8859-1?Q?iCSB5r3nQgxR5SbzxOBqpUMLHUisvJveZYl1wbrg1lkiUaG9lHH2v7BcT7?=
 =?iso-8859-1?Q?E/1JBnO094P5D3gS0+/qPWorYjnV+a658MwzSQt84X9lTX4N6rYqFtI909?=
 =?iso-8859-1?Q?/ziEXa4u5zN9xCav/BLn21eopcJKfp2pf30uGVUuWXOW53I2bQmBZcCuWJ?=
 =?iso-8859-1?Q?LQQEmS7BxZ3MWTx/It+twgGgbYGBxqmHW5cyQHO0j4seQ3kg90GTyqwgHk?=
 =?iso-8859-1?Q?RmXBnVeMzZiqah5s6t43fBUpRT37MaLo8hVBYXqJef212eVJLQmTRe1pGh?=
 =?iso-8859-1?Q?BL5uIu7YX3xFxAm+JM7XXRfmzZWq7fK5AS4J/pMDFNhkIawOV+M0mY1eHT?=
 =?iso-8859-1?Q?eQvoV04lVExg3fSvfCY1rP/fM0joFUrusZudKWI4zIlMy5NZWhiIHcGPkf?=
 =?iso-8859-1?Q?rg0LynWCj3lLGlpmqBsm/lDJUojvr86f6/47W7TxZLzjUiCV9fDYnNdwXI?=
 =?iso-8859-1?Q?k3ArWMNde7I/zRNn7OSEt74jdWyllkAqLEc2BOkJVqKLgwizWelMvIh81f?=
 =?iso-8859-1?Q?CKNWYGpf2pSGQmXsHvZ+DY1DTrkNFuwgsmOOdv7JB0acawxKoUu59ENHxi?=
 =?iso-8859-1?Q?85OFid1B4zR9/erSE0N4Suesku4SWPeOhHKLEr0tCNBSFJnJw4/MaBANJF?=
 =?iso-8859-1?Q?q+Ojy4+oxzxOHul1Jc1lgWNXOynWUqeCAzIBgXL8FG+RTp1ZXBvrmqijEE?=
 =?iso-8859-1?Q?BpnnXgm5da6rvRqgT6i0UfsXiUxEmP+4dGAYsqx/0yAJP4uQ76e/+mT5LL?=
 =?iso-8859-1?Q?IwFOn4lRmsDcqUfH8iTfiROyXqZ2slWpTKsRV6VzahaCalnL7USYKMvtXY?=
 =?iso-8859-1?Q?7fw0W6nj/3v3uiqAuTxBusV5tgXc5rhyREz0hevw4JNNTm4hyvBevixt+s?=
 =?iso-8859-1?Q?0xx2UJ98gaXK34R4uZjd8ZhCXV13r4Y=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c53b5e24-f918-44e3-cdaa-08da44ad48bf
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2022 15:33:47.2219
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: InWVBinP4IdK4a1CBVh3k6q7QeUGj7eNqNvuZqwuiWbOchayPjh6mEa7nUNxxMaq4lWLIiWRV7RsOa0gsWfw/JbnlKBUWXVbVbZrCgnYs8w=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB3870
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-02_04:2022-06-02,2022-06-02 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 mlxscore=0
 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206020065
X-Proofpoint-ORIG-GUID: oo5PLSp8YfQkDxWwtbpHiB1kPi_dtZ9P
X-Proofpoint-GUID: oo5PLSp8YfQkDxWwtbpHiB1kPi_dtZ9P
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 02, 2022 at 10:24:58AM -0400, Alex Deucher wrote:
> On Thu, Jun 2, 2022 at 7:51 AM Dan Carpenter <dan.carpenter@oracle.com> wrote:
> >
> > On Thu, Jun 02, 2022 at 08:26:03AM +0200, Ernst Sj?strand wrote:
> > > Dan: I also ran Smatch which resulted in the following discussion:
> > >
> > > https://lists.freedesktop.org/archives/amd-gfx/2022-May/079228.html 
> >
> > Since the bounds check is dead code which does not make sense and is not
> > required, another idea would be to just delete it.
> 
> It wouldn't be dead code if AMDGPU_MAX_VCN_INSTANCES ever increased.

Or we could add a comment to the code I suppose.

	/* Impossible in 2022 but this check might sense in the future */

regards,
dan carpenter