Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp6631291ioo; Thu, 2 Jun 2022 10:20:31 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxa6Bkf+sB6ifJx7x/6HMd+WBm5pT74OnUJbZw6wdDXMYc12mCihFjYC6Tv5j7jspriGtM3 X-Received: by 2002:a05:6a00:a94:b0:4fd:c14b:21cb with SMTP id b20-20020a056a000a9400b004fdc14b21cbmr6114448pfl.53.1654190431467; Thu, 02 Jun 2022 10:20:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654190431; cv=none; d=google.com; s=arc-20160816; b=UxK+f8H1Z7Ex4P7HDhxCIUhwYvNvgbzFbr5oEwezWwy5bTAWtWX7Pu4NqyNGrzHAWk 55DFj9BTmfpZWCrptHlLSK+n0APy2ZpEeqHiHr+9lOqpR3GmdPLAIq0vFQeEQ2vYYwcU 9OWDF5sgxCgwe3clM+tiyoDQuPvbVyuDw2HVV6ZKq9m/+ff0XbIhfRAaGS2Po3Dbhd6x ELEhtsfWzxV5teIJ6bcTBvaE1HD3usL4Q5NhVyl5XRTTdyRgP4WQzfaGy0mHMuOmjC78 nUZ4unA18W6dB+0WdgCrFxxjnTA50RGmAJiIDmbVu8kO101p/mgbS7bdTJVGZtsF/LXY D8dg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=pLq4FfOmH1Z10SVOPyRw53Y07ktnM/zSjoiPMbJ+fsE=; b=NUvgA14RDejIWIgfEsL+wWIH0QrWxck5kRUsgUS4MiFgICVFLxdb2Fr8Kqyu+9CeJk wRfU7ctiYO4ewX3deEgqOENeotKeDrc8wgan9dkgShwHFDkeuLnOfi5Iu3byYV9EeUj4 k0eN/iJ+b3IRge0XzhGXa5OLjEK8iHSyWaM5vzXEZL/pG/vxTBO58PCKM9WPncceM5qE BM5Mo9yEvd7azm3tm3PAFw9KArW0k5PamhOQwP7twbAwn2GBi4WbZ0sTqvcLUmwIXthD BkxTQ4EwOXSo5JxNDGRU98cpGrXyuc4AvDZv1TWVACxDnHTSTILjcy99pPVY5m4uOg8m FxZg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id kx14-20020a17090b228e00b001e08418faecsi6257656pjb.23.2022.06.02.10.20.17; Thu, 02 Jun 2022 10:20:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=huawei.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234072AbiFBLOm (ORCPT + 99 others); Thu, 2 Jun 2022 07:14:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44990 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230176AbiFBLOl (ORCPT ); Thu, 2 Jun 2022 07:14:41 -0400 Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C02F268312; Thu, 2 Jun 2022 04:14:39 -0700 (PDT) Received: from kwepemi500025.china.huawei.com (unknown [172.30.72.55]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4LDNfJ3tc9zgYSw; Thu, 2 Jun 2022 19:12:56 +0800 (CST) Received: from kwepemm600009.china.huawei.com (7.193.23.164) by kwepemi500025.china.huawei.com (7.221.188.170) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 2 Jun 2022 19:14:37 +0800 Received: from [10.174.176.73] (10.174.176.73) by kwepemm600009.china.huawei.com (7.193.23.164) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.24; Thu, 2 Jun 2022 19:14:37 +0800 Subject: Re: [PATCH -next v5 0/8] bugfix and cleanup for blk-throttle To: , , , CC: , , , References: <20220528064330.3471000-1-yukuai3@huawei.com> From: Yu Kuai Message-ID: <244865d4-e7e7-432f-8e9c-248ab900d283@huawei.com> Date: Thu, 2 Jun 2022 19:14:36 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <20220528064330.3471000-1-yukuai3@huawei.com> Content-Type: text/plain; charset="gbk"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.176.73] X-ClientProxiedBy: dggems705-chm.china.huawei.com (10.3.19.182) To kwepemm600009.china.huawei.com (7.193.23.164) X-CFilter-Loop: Reflected X-Spam-Status: No, score=-6.8 required=5.0 tests=BAYES_00,NICE_REPLY_A, RCVD_IN_DNSWL_MED,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ?? 2022/05/28 14:43, Yu Kuai ะด??: > Changes in v5: > - add comments in patch 4 > - clear bytes/io_skipped in throtl_start_new_slice_with_credit() in > patch 4 > - and cleanup patches 5-8 > Changes in v4: > - add reviewed-by tag for patch 1 > - add patch 2,3 > - use a different way to fix io hung in patch 4 > Changes in v3: > - fix a check in patch 1 > - fix link err in patch 2 on 32-bit platform > - handle overflow in patch 2 > Changes in v2: > - use a new solution suggested by Ming > - change the title of patch 1 > - add patch 2 > > Patch 1 fix that blk-throttle can't work if multiple bios are throttle, > Patch 2 fix overflow while calculating wait time > Patch 3,4 fix io hung due to configuration updates. > Patch 5-8 are cleanup patches, there are no functional changes, just > some places that I think can be optimized during code review. friendly ping ... > > Previous version: > v1: https://lore.kernel.org/all/20220517134909.2910251-1-yukuai3@huawei.com/ > v2: https://lore.kernel.org/all/20220518072751.1188163-1-yukuai3@huawei.com/ > v3: https://lore.kernel.org/all/20220519085811.879097-1-yukuai3@huawei.com/ > v4: https://lore.kernel.org/all/20220523082633.2324980-1-yukuai3@huawei.com/ > > Yu Kuai (8): > blk-throttle: fix that io throttle can only work for single bio > blk-throttle: prevent overflow while calculating wait time > blk-throttle: factor out code to calculate ios/bytes_allowed > blk-throttle: fix io hung due to config updates > blk-throttle: use 'READ/WRITE' instead of '0/1' > blk-throttle: calling throtl_dequeue/enqueue_tg in pairs > blk-throttle: cleanup tg_update_disptime() > blk-throttle: clean up flag 'THROTL_TG_PENDING' > > block/blk-throttle.c | 158 +++++++++++++++++++++++++++++-------------- > block/blk-throttle.h | 16 +++-- > 2 files changed, 120 insertions(+), 54 deletions(-) >