Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Feedback-ID: i8771445c:Fastmail
Date:   Thu, 2 Jun 2022 10:40:37 +0200
From:   Maxime Ripard <maxime@cerno.tech>
To:     Jiasheng Jiang <jiasheng@iscas.ac.cn>
Cc:     laurent.pinchart@ideasonboard.com, andrzej.hajda@intel.com,
        narmstrong@baylibre.com, robert.foss@linaro.org, jonas@kwiboo.se,
        jernej.skrabec@gmail.com, airlied@linux.ie, daniel@ffwll.ch,
        sam@ravnborg.org, alsi@bang-olufsen.dk, jagan@amarulasolutions.com,
        biju.das.jz@bp.renesas.com, l.stach@pengutronix.de,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm: bridge: adv7511: Add check for
 mipi_dsi_driver_register
Message-ID: <20220602084037.c2pslwra4dyhnh3d@penduick>
References: <20220601111255.2911012-1-jiasheng@iscas.ac.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20220601111255.2911012-1-jiasheng@iscas.ac.cn>
Precedence: bulk

On Wed, Jun 01, 2022 at 07:12:55PM +0800, Jiasheng Jiang wrote:
> On Wed, Jun 01, 2022 at 05:15:37PM +0800, Laurent Pinchart wrote:
> >> Well, as far as I am concerned, the adv7511_exit() in the same file has already dealt with the issue.
> >> Therefore, it might not be necessary to add another mipi_dsi_driver_unregister().
> > 
> > The issue is that adv7511_exit() is not called if adv7511_init() fails.
> 
> Sorry, I can not find the caller of adv7511_init().
> Please give me more detail.

It's called by the kernel when the module is unloaded (module_exit).
It's not what Laurent is saying though.

His point is that in adv7511, if i2c_add_driver fails, you'll still need
to call mipi_dsi_driver_unregister to clean things up.

Maxime