Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp6946588ioo; Thu, 2 Jun 2022 17:56:41 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2xK2/qsmsEVdl04U6Hu3fS9g+GsbjrOgZL38Ze9/H1HalK5PRgpzFIzQdQ8S5mu9EhvFQ X-Received: by 2002:a05:6402:27c8:b0:42e:2e43:86ae with SMTP id c8-20020a05640227c800b0042e2e4386aemr1271438ede.427.1654217801427; Thu, 02 Jun 2022 17:56:41 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654217801; cv=none; d=google.com; s=arc-20160816; b=HkAXAy7gDcZI9WlGpBKAqaGSpIJST04Eqf/1Gm8or1VWFUITtCp6NnAoyI8uAWokGF sAjgwQYQAh3931vP9edU8je/wMIHQJNRZM/LIt5DJw8obXaaFufti5Ll/qoK7+e7Yfe+ gHGo7gs0oycdpJ1ftnMrTcOSsVDx7UKQGl2fXAcXJCAsm1XmUmf/PHOkiW7yOrZTIKXu SW54R4KIJEqWWr1WPuRMSbQgDfJOWIMRna3krmB/9OVSjp3c4v8ZY5rw2mA0y4/arX0F tHohAA4OeapyYDxJKyOf6z/E+TFiMWS9e6WFonDvt1sPYJ7cJ0VclCOOUccWg2cJVFm2 V2bw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=BszKUWBoDhe4QochGZDZFlBkPYZcs7PuZmpP6HGKNOM=; b=G7WJgTpU9YEcUJXlgFS0hPL7DIbtqj27GTHJfnc1SXs6Mh1fS4zi7lU1sq0gK9fvYk Mhxz1O7ukZIYvwC03I0vb/o9jTyX9J6u+0DSq0lykmIj60sIKz2YxxVbyHdlF+pV6z5s JuG8qjgmdQjafjTd0Ou9xVQ4R6tHJO6zgmex2HC8rlKDHrIINNgvvlZvupQrSgBGon/i Z1CHMckDgkiVcukGqR9q2MhZvFnAg9ODVfOJQocZ622NgUpC9XwdspYv+gpuYBV0Qu2N CIOYlkeSAV3Nmpgaf051QyDBNg9yQkkcJASt9n3DcCDHSHbNvSdXfjcAUFMhHLYRYk6S Ufsw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=CZpI41s8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a4-20020aa7c804000000b0042dd2760210si3471152edt.543.2022.06.02.17.56.16; Thu, 02 Jun 2022 17:56:41 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b=CZpI41s8; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230499AbiFBGqs (ORCPT + 99 others); Thu, 2 Jun 2022 02:46:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58872 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231439AbiFBGqm (ORCPT ); Thu, 2 Jun 2022 02:46:42 -0400 Received: from mail-yb1-xb2b.google.com (mail-yb1-xb2b.google.com [IPv6:2607:f8b0:4864:20::b2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F37AB2A3A04; Wed, 1 Jun 2022 23:46:40 -0700 (PDT) Received: by mail-yb1-xb2b.google.com with SMTP id g4so6705644ybf.12; Wed, 01 Jun 2022 23:46:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=BszKUWBoDhe4QochGZDZFlBkPYZcs7PuZmpP6HGKNOM=; b=CZpI41s86ZMmSgVndxepBehDJn37LAJpF4lJD+Vv9uqU+84sORclP23vCS8vNJxFnJ XmmR7jhK63Mtpjn57lySuY0YBXb9mjRD+2golXeTaoes3dAvAbL5qnqi3urd4uColD/c VCaG3IpEZXRfY3xosx7rpsHyWKm+vWV3mQbXPrdsqzPEEWenjjQBaV/4Pzn/zFM9wKyl 5Z//gVMqTYJXp+EkufKYVEjH+m9X47ZXFY8TbXQHa5JOhAqgS4xCJFnVVmAHMShjSyJa O5SkMlogQV25sswqgweGLR/4L+vv59Nxu+gCELogE9FQZEDR+JNPRCBPU2cjIti/YK4m 1fTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=BszKUWBoDhe4QochGZDZFlBkPYZcs7PuZmpP6HGKNOM=; b=m0Q88LG5ykSbnRatc88mSG5KjMaVy882YOi/N2Qb84+v88JQXEXFEOam+/4XlqK3Ng vtEC5jjrHG9OtmlsC2N+0koXRPwEPCzPUqTCftlxb5ybDOXGp9ZyR8c+8jnY0jofOAKU c1O7USu3Amd/ypUdXTvRCRW3ELx7X2cvE7Jqhkci+RiC9E1Bl+eY5+oLocGhj0HcBUVf XNCKs7fmoWswv5JIjdg2YLlSLUlIwORZpWh5BsdySSvFqQ+biWhSiK9VL06iHi7Dq20+ LS1DXbx5AKLd5T3/8xRCqlAJqWx9I/k/Nvk/0RXFMPu0+bADiPGoNDbceDzgnoCj3khJ Yfvw== X-Gm-Message-State: AOAM530dj8D5accccFHcNEaJBh9xM7eImGjBdrVP86FUnKa2btEBD2NE kQmZ0gCH2QyRxhdEqq+IKzwlmVQM5q/HMEZALXU= X-Received: by 2002:a5b:691:0:b0:64d:ab44:f12e with SMTP id j17-20020a5b0691000000b0064dab44f12emr3640214ybq.533.1654152400227; Wed, 01 Jun 2022 23:46:40 -0700 (PDT) MIME-Version: 1.0 References: <20220520114242.150235-1-benchuanggli@gmail.com> In-Reply-To: From: Ben Chuang Date: Thu, 2 Jun 2022 14:46:29 +0800 Message-ID: Subject: Re: [RESEND, PATCH] mmc: sdhci-pci-gli: Fix GL9763E runtime PM when the system resumes from suspend To: Ulf Hansson Cc: Adrian Hunter , linux-mmc , Linux Kernel Mailing List , greg.tu@genesyslogic.com.tw, Ben Chuang , SeanHY.Chen@genesyslogic.com.tw, jason.lai@genesyslogic.com.tw, victor.shih@genesyslogic.com.tw, kane.chen@intel.corp-partner.google.com Content-Type: text/plain; charset="UTF-8" X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 31, 2022 at 9:39 PM Ulf Hansson wrote: > > On Fri, 20 May 2022 at 13:43, Ben Chuang wrote: > > > > When the system resumes from suspend (S3 or S4), the power mode is > > MMC_POWER_OFF. In this status, gl9763e_runtime_resume() should not enable > > PLL. Add a condition to this function to enable PLL only when the power > > mode is MMC_POWER_ON. > > > > Fixes: d607667bb8fa (mmc: sdhci-pci-gli: Add runtime PM for GL9763E) > > Signed-off-by: Ben Chuang > > Sorry for the delay, I have been out traveling. Unfortunately this > didn't make it for v5.18, although I have queued it up for v5.19 and > added a stable tag. > > Thanks and kind regards > Uffe > It's ok. Thank you for the explanation. Best regards, Ben > > > --- > > Hi, > > > > Sorry, resend this patch because typo two email addresses. > > Sorry for Adrian and Kane. > > > > Best regards, > > Ben > > --- > > drivers/mmc/host/sdhci-pci-gli.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/mmc/host/sdhci-pci-gli.c b/drivers/mmc/host/sdhci-pci-gli.c > > index d09728c37d03..d81e5dc90e15 100644 > > --- a/drivers/mmc/host/sdhci-pci-gli.c > > +++ b/drivers/mmc/host/sdhci-pci-gli.c > > @@ -972,6 +972,9 @@ static int gl9763e_runtime_resume(struct sdhci_pci_chip *chip) > > struct sdhci_host *host = slot->host; > > u16 clock; > > > > + if (host->mmc->ios.power_mode != MMC_POWER_ON) > > + return 0; > > + > > clock = sdhci_readw(host, SDHCI_CLOCK_CONTROL); > > > > clock |= SDHCI_CLOCK_PLL_EN; > > -- > > 2.36.0 > >