Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 2 Jun 2022 11:13:41 -0700
From:   Andrew Morton <akpm@linux-foundation.org>
To:     Jakub =?UTF-8?B?TWF0xJtuYQ==?= <matenajakub@gmail.com>
Cc:     linux-mm@kvack.org, patches@lists.linux.dev,
        linux-kernel@vger.kernel.org, vbabka@suse.cz, mhocko@kernel.org,
        mgorman@techsingularity.net, willy@infradead.org,
        liam.howlett@oracle.com, hughd@google.com, kirill@shutemov.name,
        riel@surriel.com, rostedt@goodmis.org, peterz@infradead.org
Subject: Re: [PATCH 1/2] [PATCH 1/2] mm: refactor of vma_merge()
Message-Id: <20220602111341.6674e4d862d6d925b0eebcb3@linux-foundation.org>
In-Reply-To: <20220602145642.16948-2-matenajakub@gmail.com>
References: <20220602145642.16948-1-matenajakub@gmail.com>
        <20220602145642.16948-2-matenajakub@gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu,  2 Jun 2022 16:56:41 +0200 Jakub Matěna <matenajakub@gmail.com> wrote:

> Refactor vma_merge() to make it shorter and more understandable.
> Main change is the elimination of code duplicity in the case of
> merge next check. This is done by first doing checks and caching
> the results before executing the merge itself. The variable 'area' is
> divided into 'mid' and 'res' as previously it was used for two purposes,
> as the middle VMA between prev and next and also as the result of the
> merge itself. Exit paths are also unified.
> 

Thanks, but unfortunately the code you're working on here has changed
greatly in Liam's mapletree patchset.  Could you please take a look at
the mm-unstable branch at
git://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm and decide if you
want to tackle it?