Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 2 Jun 2022 14:50:46 +0300
From:   Dan Carpenter <dan.carpenter@oracle.com>
To:     Ernst =?iso-8859-1?Q?Sj=F6strand?= <ernstp@gmail.com>
Cc:     Alex Deucher <alexdeucher@gmail.com>, kbuild-all@lists.01.org,
        kernel test robot <lkp@intel.com>, kbuild@lists.01.org,
        LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>
Subject: Re: [kbuild] drivers/gpu/drm/amd/amdgpu/amdgpu_discovery.c:1433
 amdgpu_discovery_get_vcn_info() error: buffer overflow
 'adev->vcn.vcn_codec_disable_mask' 2 <= 3
Message-ID: <20220602115046.GH2168@kadam>
References: <202205271546.oV14N2r8-lkp@intel.com>
 <CADnq5_NOkqRsoqELkLayNU+xArXd-4RO=_banvJpXHtSW4-YdA@mail.gmail.com>
 <CAD=4a=WRbp8w4DA2c6hE7W5A2-woRyHLvtC-GPitFwQireCeNw@mail.gmail.com>
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <CAD=4a=WRbp8w4DA2c6hE7W5A2-woRyHLvtC-GPitFwQireCeNw@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?4I8s7+EKlIlNoC2wBH1s4jXFdYbdNtTKBer3hG7bFPP4mN3xOBHhHSjlkf?=
 =?iso-8859-1?Q?/X8vuY8B1SKRgAJUl/yxXSR0tS7Bqv9cgq+sMap2lQ9PbQv/RmADiZlnFh?=
 =?iso-8859-1?Q?J1pF0RDN/wtpsttulqk6HdnEgNxhc58mYTaYIm+uYS4AD+aXdayjPxDJog?=
 =?iso-8859-1?Q?J1Ar6leUQzFNy3VPgqbZB2669ycUg5MAhWZoNHv4artE/sJU+bRgjc/6ct?=
 =?iso-8859-1?Q?XEB9EeQ+36kelZsn467QLGhnmVos3VJ0xKDMsir+xhydGxvAolEz/WVEc7?=
 =?iso-8859-1?Q?6oD0n5y09xya3ZYeWmeAH6P9IttTpkSY5b1PTu0oos7XRWoivxddRM6KbK?=
 =?iso-8859-1?Q?8vbd+NiWjNN3oFH8T7oxEzRzVAR9KJwGb8uYfRcNSJcbaDeSNvWcTOCHoi?=
 =?iso-8859-1?Q?T/AJk2KNKOqSIYMBhTiLYSnp/eqt7TwufLE3rSiQLHxetwdOuvC0jipdCB?=
 =?iso-8859-1?Q?9qosuNKUANP43ONGiOeUDiN/uzsBTujyyfVxiB22Ih1MpV2SkDwIaVuxDJ?=
 =?iso-8859-1?Q?J6cICLY5suCFetYevjtIeeHpiS2gk2rRWpxQDpwUBnDk2KTbTI6WEADY90?=
 =?iso-8859-1?Q?d8oASGaEc1LdXhSFcv0QSU6GR0ASaA1kkPreajw1qUS2n/MFmCRwH3TBWB?=
 =?iso-8859-1?Q?Euh9iSCNMhzvIO+kt1nrYmDFGXlJNzZiglH2Ihn358fMuy6XP79XeaOg4p?=
 =?iso-8859-1?Q?t+rgxK5hZv8U+cjfTxfYy/Uj5fo/JR9svuf7ztZ/wAaXlqjTyh1su56XwK?=
 =?iso-8859-1?Q?xJGnKvaeLBykQKyBDhnQ9jU+g8drih+m4UfvRb7rFSD5fLi/gZN+/QG7iw?=
 =?iso-8859-1?Q?eC4bP7sZVYV8XPHaI3BY+m4WSCAUj0/D1ecpZqMWGgz7BXmqaJS6fFQFfl?=
 =?iso-8859-1?Q?95yGNbarz26vaOsuFi6MPD+xk2CEGvn13YMAbhy8Hhzn/H6eP2rKZsJ0AB?=
 =?iso-8859-1?Q?NGDR7OaWza3r9Z6kp9r6Zvr53ZvtVKqlmXFvHnHpOgCyxKMvYq9GHxo0A6?=
 =?iso-8859-1?Q?bVRvkGVcD/otbPbxyV1HE2qwT6Czjz3ZqRwaWCvajv01hA3T6IV7ctFqT1?=
 =?iso-8859-1?Q?CNQ3qIbF83/9pJ492wxNV/xaD3UMtlepYgaL4fgaiqaQl60UuJFY5YbjUr?=
 =?iso-8859-1?Q?v6tiveVYQ4hEWSNj3bgtIZPjrMV2FfypCWFk1mxFIacgpMwrNWmau7BzRy?=
 =?iso-8859-1?Q?4tenMWCRrxAmqL9OSebp+/Ncv5tBsvPraYMaFBk45MHCKbcnIjVDvDN/tS?=
 =?iso-8859-1?Q?KRR64r6u1z3GEDIQOJOgG+QGsZ7VRGr7tXe8+gL40arSfgPwg1XnXLEkhV?=
 =?iso-8859-1?Q?xxgRXHb4UD6bOpLnXh9KkXmxMzs9J+NkHCcnY5XDHhmpp9sBVCIK1xqKlc?=
 =?iso-8859-1?Q?oSkzx+nrgza72QGWZqV8AevqfcgTmC/4ZNWLZ9JPtQGBLlAoW4jfyAB3qi?=
 =?iso-8859-1?Q?dQVA7ixbC1gLlBzD9apB+2+PR9e0U1rOslz7WF7nGxjWywQ9rDOzV27+/H?=
 =?iso-8859-1?Q?7prZBNhSpskUpRNBvBbJuqDWuTBY2YUA/t8WPXT1fT9Rzm4mVMSPN6ClzC?=
 =?iso-8859-1?Q?GEcZzxIdV3octtw2tRzl4EzM/P4wLmGzYRw2b5E4H5WkC/Mb5ezNmVt3fp?=
 =?iso-8859-1?Q?+Oa+1wkPNLkZGhNaDOosalXBaJWiNB0yXdxhNarPn7UsdeCNADbRGnCRK6?=
 =?iso-8859-1?Q?ujvfMXdaUvoF6cU0ESMIaePJKT8FyV6TUmCg/k59ZF4ACUNc8V2VaUJU1z?=
 =?iso-8859-1?Q?x53zE12TiQ1N5rvjWWHXjsTGTonxx4U5TsPcEFkyG7PvpZFr0O2Eek1chF?=
 =?iso-8859-1?Q?TJe6RdppN47uc72Xn+jUKyomZ0sHC8I=3D?=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 3bb4346c-885e-4c59-6f96-08da448e2cad
X-MS-Exchange-CrossTenant-AuthSource: MWHPR1001MB2365.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Jun 2022 11:51:05.5392
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: MyC2nGk0vr3/LA3sXfSVkHywMVoy8rqbEkASm9HLSzc/l0A0yDLd7CanaXc9QZVcgGJaQ+n5u1Bv/N79F9twv7HDC1yQqQTxPJPzrU2sIw4=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5138
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.517,18.0.874
 definitions=2022-06-02_02:2022-06-02,2022-06-02 signatures=0
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=794 mlxscore=0
 suspectscore=0 spamscore=0 phishscore=0 malwarescore=0 bulkscore=0
 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2204290000 definitions=main-2206020050
X-Proofpoint-ORIG-GUID: in2mBRDNc4Cp0RI0aU564SfZ6N-OUreh
X-Proofpoint-GUID: in2mBRDNc4Cp0RI0aU564SfZ6N-OUreh
X-Spam-Status: No, score=-2.8 required=5.0 tests=BAYES_00,DKIMWL_WL_MED,
        DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,
        RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE
        autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
        lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Jun 02, 2022 at 08:26:03AM +0200, Ernst Sj?strand wrote:
> Dan: I also ran Smatch which resulted in the following discussion:
> 
> https://lists.freedesktop.org/archives/amd-gfx/2022-May/079228.html 

Since the bounds check is dead code which does not make sense and is not
required, another idea would be to just delete it.

regards,
dan carpenter