Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220602022404.508144-1-sunliming@kylinos.cn> <20220602082559.795189e1@rorschach.local.home>
In-Reply-To: <20220602082559.795189e1@rorschach.local.home>
From:   sunliming <kelulanainsley@gmail.com>
Date:   Thu, 2 Jun 2022 21:54:27 +0800
Message-ID: <CAJncD7S88TnmoYkLnhiHWEH_8V_PfF56ctLA6Z1_joqHOmDTAg@mail.gmail.com>
Subject: Re: [PATCH] tracing: Simplify conditional compilation code in tracing_set_tracer()
To:     Steven Rostedt <rostedt@goodmis.org>
Cc:     mingo@kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Steven Rostedt <rostedt@goodmis.org> =E4=BA=8E2022=E5=B9=B46=E6=9C=882=E6=
=97=A5=E5=91=A8=E5=9B=9B 20:26=E5=86=99=E9=81=93=EF=BC=9A
>
> On Thu,  2 Jun 2022 10:24:04 +0800
> sunliming <sunliming@kylinos.cn> wrote:
>
> > Two conditional compilation directives "#ifdef CONFIG_TRACER_SNAPSHOT"
> > are used consecutively, and no other code in between. Simplify conditio=
nal
> > the compilation code and only use one "#ifdef CONFIG_TRACER_SNAPSHOT".
>
> I think you mean CONFIG_TRACER_MAX_TRACE here.
>
> -- Steve
>
> >
> > Signed-off-by: sunliming <sunliming@kylinos.cn>
> > ---
> >  kernel/trace/trace.c | 2 --
> >  1 file changed, 2 deletions(-)
> >
> > diff --git a/kernel/trace/trace.c b/kernel/trace/trace.c
> > index f400800bc910..dc959e339512 100644
> > --- a/kernel/trace/trace.c
> > +++ b/kernel/trace/trace.c
> > @@ -6430,9 +6430,7 @@ int tracing_set_tracer(struct trace_array *tr, co=
nst char *buf)
> >               synchronize_rcu();
> >               free_snapshot(tr);
> >       }
> > -#endif
> >
> > -#ifdef CONFIG_TRACER_MAX_TRACE
> >       if (t->use_max_tr && !had_max_tr) {
> >               ret =3D tracing_alloc_snapshot_instance(tr);
> >               if (ret < 0)
>
Yes, you are right. I am sorry about this low-level mistakes.