Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
MIME-Version: 1.0
References: <20220602182159.248387-1-shy828301@gmail.com> <20220602182159.248387-6-shy828301@gmail.com>
 <Ypkk0pRHwBrI9Cj/@casper.infradead.org>
In-Reply-To: <Ypkk0pRHwBrI9Cj/@casper.infradead.org>
From:   Yang Shi <shy828301@gmail.com>
Date:   Thu, 2 Jun 2022 16:15:20 -0700
Message-ID: <CAHbLzkqfdFmiEymUfp=_mWK_6tRKeMe0pQ6fGAPLi=oL326LtQ@mail.gmail.com>
Subject: Re: [v2 PATCH 5/7] mm: thp: kill transparent_hugepage_active()
To:     Matthew Wilcox <willy@infradead.org>
Cc:     Vlastimil Babka <vbabka@suse.cz>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Andrew Morton <akpm@linux-foundation.org>,
        Linux MM <linux-mm@kvack.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Thu, Jun 2, 2022 at 2:00 PM Matthew Wilcox <willy@infradead.org> wrote:
>
> On Thu, Jun 02, 2022 at 11:21:57AM -0700, Yang Shi wrote:
> > diff --git a/include/linux/huge_mm.h b/include/linux/huge_mm.h
> > index 79d5919beb83..f315c70d5256 100644
> > --- a/include/linux/huge_mm.h
> > +++ b/include/linux/huge_mm.h
> > @@ -209,7 +209,9 @@ static inline bool file_thp_enabled(struct vm_area_struct *vma)
> >              !inode_is_open_for_write(inode) && S_ISREG(inode->i_mode);
> >  }
> >
> > -bool transparent_hugepage_active(struct vm_area_struct *vma);
> > +extern bool hugepage_vma_check(struct vm_area_struct *vma,
>
> Please remove the 'extern's.  They add no value to function
> declarations.

Yeah, thanks for catching this.

>