Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <aa5a8e73-b9b4-38e7-4f85-2bf309a346e0@infineon.com>
Date:   Thu, 2 Jun 2022 17:34:07 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH v4 1/3] dt-bindings: trivial-devices: Add two I2C TPM
 devices
Content-Language: en-US
To:     Rob Herring <robh@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
CC:     <jarkko@kernel.org>, <linux-kernel@vger.kernel.org>,
        <linux-integrity@vger.kernel.org>, <devicetree@vger.kernel.org>,
        <peterhuewe@gmx.de>, <jgg@ziepe.ca>,
        <krzysztof.kozlowski+dt@linaro.org>,
        Johannes Holland <johannes.holland@infineon.com>,
        Amir Mizinski <amirmizi6@gmail.com>
References: <20220525165849.7789-1-Alexander.Steffen@infineon.com>
 <20220525165849.7789-2-Alexander.Steffen@infineon.com>
 <8c4941a1-e047-1352-32ba-8595cd0143f0@linaro.org>
 <20220602134848.GA2178372-robh@kernel.org>
From:   Alexander Steffen <Alexander.Steffen@infineon.com>
In-Reply-To: <20220602134848.GA2178372-robh@kernel.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 02.06.22 15:48, Rob Herring wrote:
> On Thu, May 26, 2022 at 02:29:56PM +0200, Krzysztof Kozlowski wrote:
>> On 25/05/2022 18:58, Alexander Steffen wrote:
>>> Both are supported by the upcoming tpm_tis_i2c driver.
>>>
>>> Signed-off-by: Alexander Steffen <Alexander.Steffen@infineon.com>
>>> ---
>>>   Documentation/devicetree/bindings/trivial-devices.yaml | 4 ++++
>>>   1 file changed, 4 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml
>>> index 550a2e5c9e05..dc52822331dd 100644
>>> --- a/Documentation/devicetree/bindings/trivial-devices.yaml
>>> +++ b/Documentation/devicetree/bindings/trivial-devices.yaml
>>> @@ -135,6 +135,8 @@ properties:
>>>             - infineon,slb9635tt
>>>               # Infineon SLB9645 I2C TPM (new protocol, max 400khz)
>>>             - infineon,slb9645tt
>>> +            # Infineon SLB9673 I2C TPM 2.0
>>> +          - infineon,slb9673
>>>               # Infineon TLV493D-A1B6 I2C 3D Magnetic Sensor
>>>             - infineon,tlv493d-a1b6
>>>               # Infineon Multi-phase Digital VR Controller xdpe11280
>>> @@ -323,6 +325,8 @@ properties:
>>>             - st,24c256
>>>               # Ambient Light Sensor with SMBUS/Two Wire Serial Interface
>>>             - taos,tsl2550
>>> +            # TCG TIS-compliant TPM with I2C interface
>>> +          - tcg,tpm_tis-i2c
>>
>> One flavor uses tpm-tis, another tpm_tis... I guess it is too late to
>> make it consistent, but let's stick to the one more reasonable, so:
>> "tpm-tis-i2c".
> 
> Neither should be used except perhaps as a fallback.

That is the intention, yes.

> Does 'TCG TIS-compliant TPM' encompass every property of a device? Power
> supplies, resets, interrupts, quirks, etc.?

In an ideal world, yes. In practice, of course implementations do have 
bugs that might require different workarounds. By selecting 
tcg,tpm-tis-i2c instead of anything more specific, you promise that the 
device is fully compliant to the TCG specification and does not require 
any such workarounds.

Alexander