Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <e68000bf-a271-d1f2-56a5-a9ddce2bbb7c@infradead.org>
Date:   Thu, 2 Jun 2022 09:34:27 -0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH V14 01/24] irqchip: Adjust Kconfig for Loongson
Content-Language: en-US
To:     Huacai Chen <chenhuacai@loongson.cn>,
        Arnd Bergmann <arnd@arndb.de>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Airlie <airlied@linux.ie>,
        Jonathan Corbet <corbet@lwn.net>,
        Linus Torvalds <torvalds@linux-foundation.org>
Cc:     linux-arch@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-kernel@vger.kernel.org, Xuefeng Li <lixuefeng@loongson.cn>,
        Yanteng Si <siyanteng@loongson.cn>,
        Huacai Chen <chenhuacai@gmail.com>,
        Guo Ren <guoren@kernel.org>, Xuerui Wang <kernel@xen0n.name>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        Marc Zyngier <maz@kernel.org>, WANG Xuerui <git@xen0n.name>
References: <20220602115141.3962749-1-chenhuacai@loongson.cn>
 <20220602115141.3962749-2-chenhuacai@loongson.cn>
From:   Randy Dunlap <rdunlap@infradead.org>
In-Reply-To: <20220602115141.3962749-2-chenhuacai@loongson.cn>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hi,

On 6/2/22 04:51, Huacai Chen wrote:
> diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig
> index 44fb8843e80e..1cb3967fe798 100644
> --- a/drivers/irqchip/Kconfig
> +++ b/drivers/irqchip/Kconfig
> @@ -557,7 +557,7 @@ config LOONGSON_LIOINTC
>  
>  config LOONGSON_HTPIC
>  	bool "Loongson3 HyperTransport PIC Controller"
> -	depends on MACH_LOONGSON64
> +	depends on (MACH_LOONGSON64 && MIPS)

If you ever have another patch version, please drop the unnecessary left and
right parentheses above.

	depends on MACH_LOONGSON64 && MIPS

>  	default y
>  	select IRQ_DOMAIN
>  	select GENERIC_IRQ_CHIP

thanks.
-- 
~Randy