Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
IronPort-SDR: RxE70zajE2xgqmRWPJRRkCb+d8pdBrbY0BIXsZrwTwp54w/muQ/QwT6tDGpXgDmtqIzS3Jn7uv
 THFyzhvtGDorQaDU0B4bThv1hZ/46w9U5E0l1q/dJ9q18JW0HZiqZReXXCMAyz5TXosxkOkGNX
 G4cENLZj3OElXogSn4NgX6AUt+SOAfxRRvYMTgAXVe1XhqVm3LrnQ6bUlNVE76LpJtZhXZddFj
 R3bOyNfAoOr1ayWrH2iJq4i8K7LJIPvF0RHt+OEqCFMsRk+e4LRsntp4Q4KzImEOheZP+8KwUM
 lZ4SCD0S3LxB6wr5gR603fcW
IronPort-SDR: aMJROiXZYDS/P0QmetGMF91W5iG6bGPDjAj+vWUvOb30XNXtEni+Ebyb9SDcRE6tWSuojx43oa
 OvQPSPNFtHjNdUH0JnfQB66rlfgk54Gueeg1uEKq8mt5Tfh0txRQWZXMn8x/htU8admRLbYwos
 FqnbHfB+fqWnex4Qm+tk17IPZzOS5sI9EyYKb81i+YyaG5gMaIShPy7ZpXHtLWCnlps0rsvqAN
 SbPqw38LKn9BEvafEzF2o0eiWt/Wb1AFq3ISORSPh5y8pBfilIGEH1opZfoqCAf3S5P2UNEQL6
 ZKI=
WDCIronportException: Internal
Message-ID: <87953d70-198d-e146-b67d-b320603d52d3@opensource.wdc.com>
Date:   Thu, 2 Jun 2022 15:32:24 +0900
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0)
 Gecko/20100101 Thunderbird/91.9.1
Subject: Re: [PATCH v2] ata: pata_octeon_cf: Fix refcount leak in
 octeon_cf_probe
Content-Language: en-US
To:     Miaoqian Lin <linmq006@gmail.com>,
        Sergey Shtylyov <s.shtylyov@omp.ru>,
        Jeff Garzik <jgarzik@redhat.com>,
        David Daney <david.daney@cavium.com>,
        linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20220601085926.45183-1-linmq006@gmail.com>
From:   Damien Le Moal <damien.lemoal@opensource.wdc.com>
Organization: Western Digital Research
In-Reply-To: <20220601085926.45183-1-linmq006@gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2022/06/01 17:59, Miaoqian Lin wrote:
> of_find_device_by_node() takes reference, we should use put_device()
> to release it when not need anymore.
> Add missing put_device() to avoid refcount leak.
> 
> Fixes: 43f01da0f279 ("MIPS/OCTEON/ata: Convert pata_octeon_cf.c to use device tree.")
> Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
> ---
> changes in v2:
> - Add put_device() at the end of if (dma_dev).
>   we need the null check and do handling only if dma_dev!=NULL.
> - call put_device before of_node_put() in error path. keep the
>   reverse order of resource allocation.
> 
> v1 link:
> https://lore.kernel.org/all/20220511062723.56652-1-linmq006@gmail.com/
> ---
>  drivers/ata/pata_octeon_cf.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c
> index 6b5ed3046b44..35608a0cf552 100644
> --- a/drivers/ata/pata_octeon_cf.c
> +++ b/drivers/ata/pata_octeon_cf.c
> @@ -856,12 +856,14 @@ static int octeon_cf_probe(struct platform_device *pdev)
>  				int i;
>  				res_dma = platform_get_resource(dma_dev, IORESOURCE_MEM, 0);
>  				if (!res_dma) {
> +					put_device(&dma_dev->dev);
>  					of_node_put(dma_node);
>  					return -EINVAL;
>  				}
>  				cf_port->dma_base = (u64)devm_ioremap(&pdev->dev, res_dma->start,
>  									 resource_size(res_dma));
>  				if (!cf_port->dma_base) {
> +					put_device(&dma_dev->dev);
>  					of_node_put(dma_node);
>  					return -EINVAL;
>  				}
> @@ -871,6 +873,7 @@ static int octeon_cf_probe(struct platform_device *pdev)
>  					irq = i;
>  					irq_handler = octeon_cf_interrupt;
>  				}
> +				put_device(&dma_dev->dev);
>  			}
>  			of_node_put(dma_node);
>  		}

Applied to for-5.19-fixes. Thanks !

-- 
Damien Le Moal
Western Digital Research