Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Thu, 2 Jun 2022 15:47:37 -0700
From:   Ira Weiny <ira.weiny@intel.com>
To:     Jonathan Cameron <Jonathan.Cameron@huawei.com>
Cc:     Dan Williams <dan.j.williams@intel.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Alison Schofield <alison.schofield@intel.com>,
        Vishal Verma <vishal.l.verma@intel.com>,
        Dave Jiang <dave.jiang@intel.com>,
        Ben Widawsky <ben@bwidawsk.net>, linux-kernel@vger.kernel.org,
        linux-cxl@vger.kernel.org, linux-pci@vger.kernel.org
Subject: Re: [PATCH V9 6/9] cxl/port: Read CDAT table
Message-ID: <Ypk+Cc0fWelIcamX@iweiny-desk3>
References: <20220531152632.1397976-1-ira.weiny@intel.com>
 <20220531152632.1397976-7-ira.weiny@intel.com>
 <20220601163540.00006978@Huawei.com>
 <20220601173113.000005a6@Huawei.com>
 <YpkCHADvGv6i3jVP@iweiny-desk3>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YpkCHADvGv6i3jVP@iweiny-desk3>
Precedence: bulk

On Thu, Jun 02, 2022 at 11:31:56AM -0700, Ira wrote:
> On Wed, Jun 01, 2022 at 05:31:13PM +0100, Jonathan Cameron wrote:
> > On Wed, 1 Jun 2022 16:35:40 +0100
> > Jonathan Cameron <Jonathan.Cameron@Huawei.com> wrote:
> > 
> > > On Tue, 31 May 2022 08:26:29 -0700
> > > ira.weiny@intel.com wrote:
> > > 
> > > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > > > 
> > > > The OS will need CDAT data from CXL devices to properly set up
> > > > interleave sets.  Currently this is supported through a DOE mailbox
> > > > which supports CDAT.
> > > > 
> > > > Cache the CDAT data for later parsing.  Provide a sysfs binary attribute
> > > > to allow dumping of the CDAT.
> > > > 
> > > > Binary dumping is modeled on /sys/firmware/ACPI/tables/
> > > > 
> > > > The ability to dump this table will be very useful for emulation of real
> > > > devices once they become available as QEMU CXL type 3 device emulation will
> > > > be able to load this file in.
> > > > 
> > > > This does not support table updates at runtime. It will always provide
> > > > whatever was there when first cached. Handling of table updates can be
> > > > implemented later.
> > > > 
> > > > Finally create a complete list of DOE defines within cdat.h for code
> > > > wishing to decode the CDAT table.
> > > > 
> > > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > > > Co-developed-by: Ira Weiny <ira.weiny@intel.com>
> > > > Signed-off-by: Ira Weiny <ira.weiny@intel.com>
> > > >   
> > > 
> > > Fun question of ownership inline...
> > 
> > And a follow up due to triggering a bug that predated this series...
> > 
> > I'd send a fix, but I'm off on a long weekend shortly :)
> 
> NP I discussed with Dan and the use of dev_groups should allow me to move this
> to port probe where it belongs.  I put it here for the sysfs stuff.

Not to make a habit of replying to my own mails but this works.

So I'm going to go forward with spinning this again.

Ira