Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
From:   Dmitry Rokosov <DDRokosov@sberdevices.ru>
To:     Jonathan Cameron <jic23@kernel.org>
CC:     "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "linux-iio@vger.kernel.org" <linux-iio@vger.kernel.org>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        kernel <kernel@sberdevices.ru>,
        "stano.jakubek@gmail.com" <stano.jakubek@gmail.com>,
        "shawnguo@kernel.org" <shawnguo@kernel.org>,
        "lars@metafoo.de" <lars@metafoo.de>,
        "andy.shevchenko@gmail.com" <andy.shevchenko@gmail.com>,
        "stephan@gerhold.net" <stephan@gerhold.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 3/3] dt-bindings: iio: accel: add dt-binding schema for
 msa311 accel driver
Thread-Topic: [PATCH v2 3/3] dt-bindings: iio: accel: add dt-binding schema
 for msa311 accel driver
Thread-Index: AQHYcGNsHieJqKs6FU67Uad334M2Aq0vuKGAgASpOICAB9q1gA==
Date:   Thu, 2 Jun 2022 17:39:55 +0000
Message-ID: <20220602174013.x4ygdpbivr2xv5iq@CAB-WSD-L081021.sigma.sbrf.ru>
References: <20220525181532.6805-1-ddrokosov@sberdevices.ru>
 <20220525181532.6805-4-ddrokosov@sberdevices.ru>
 <20220525183255.lc7hmmcfj47yrxc3@CAB-WSD-L081021.sigma.sbrf.ru>
 <20220528184337.0855c8cc@jic23-huawei>
In-Reply-To: <20220528184337.0855c8cc@jic23-huawei>
Accept-Language: ru-RU, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <719AE3C7FD7B814D986963EEA545FF29@sberdevices.ru>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
Precedence: bulk

Jonathan,

On Sat, May 28, 2022 at 06:43:37PM +0100, Jonathan Cameron wrote:
> On Wed, 25 May 2022 18:32:45 +0000
> Dmitry Rokosov <DDRokosov@sberdevices.ru> wrote:
>=20
> > > +  interrupt-names:
> > > +    const: irq =20
> > I stay interrupt-names node here, because otherwise dt_binding_check
> > command shows such a warning:
> >=20
> > =3D=3D=3D=3D
> >   CHECK   Documentation/devicetree/bindings/iio/accel/memsensing,msa311=
.example.dt.yaml
> > Documentation/devicetree/bindings/iio/accel/memsensing,msa311.example.d=
t.yaml: accelerometer@62: 'interrupt-names' does not match any of the regex=
es: 'pinctrl-[0-9]+'
> > =3D=3D=3D=3D
> >=20
> > I can't delete this node from the example as well, because it's require=
d for
> > msa311 dts i2c irq declaration.
>=20
> Sorry, you've lost me - what breaks if you drop it from the example?
> I'd expect to see no interrupt-names being documented or in the example.
>=20
> >=20
> > Please help me to resolve this problem properly if possible. If we can
> > ignore such warning I'll delete interrupt-names in the next patchset's
> > version.
>=20
> We can't ignore the warning, so this comes down to what am I missing with
> the need for it in the example...
>=20

You are totally right. I thought during i2c device probe we should
provide interrupt-names dts property because i2c irq parsing requires
it, but I was wrong. i2c_device_probe() function tries to parse irq
value using interrupt-names property and fallbacks to simple
of_irq_get() if interrupt-names property is missing. In other words,
interrupt-names property is not required for device node declaration, so
it can be removed from documentation. Thank you for pointing this out.

> >=20
> > > +examples:
> > > +  - |
> > > +    #include <dt-bindings/interrupt-controller/irq.h>
> > > +    i2c {
> > > +        #address-cells =3D <1>;
> > > +        #size-cells =3D <0>;
> > > + =20
> > Properties #address-cells and #size-cells are still located in the
> > schema example, because otherwise dt_binding_check raises the below=20
> > warnings if we delete these properties:
>=20
> They should be there for the i2c node, (as they are required for an i2c b=
us master
> node) but you had them documented as being in the msa311 node.  If it's
> not in the
> accelerometer@62 {
>=20
> }
>=20
> section of the example documetnation doesn't belong on this file (it will=
 be
> elsewhere).=20
>=20
> The request is to drop the documentation of them (as we are documenting
> the msa311 part of the binding only).  They should indeed still be there
> in the example.
>=20
> Jonathan
>=20

I've removed #address-cells and #size-cells properties from
doc section as well as interrupt-names. All dtbs checkings have passed
successfully. Thank you!

--=20
Thank you,
Dmitry=