Received: by 2002:a05:6602:18e:0:0:0:0 with SMTP id m14csp7680890ioo; Fri, 3 Jun 2022 11:12:14 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2sTQjSGhgtRMk+UxIhClQKTu30SVUh/QnUFiWSFFRBFod0Jpaqf+sPNMQOk+M8jcPt+Fa X-Received: by 2002:a05:6402:254e:b0:42b:4633:e53e with SMTP id l14-20020a056402254e00b0042b4633e53emr12322200edb.314.1654279934129; Fri, 03 Jun 2022 11:12:14 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1654279934; cv=none; d=google.com; s=arc-20160816; b=qvu/TJ7jPF7BQ497pya2hnUax0f30rii2XdPHb/FwAe2bVLEhuWIo9PjAr0IX5ogxB qoI8KqtgTNHvF4FYrXnZjPs6QhcvN7LRSWG4GEZabW1nyNExUDrDGvfgSy3LPRmh6bNU kGXU6bfmHdmCVD/uStm8r80UI4FFJhbEjJWc94RFwuuX1qufYSjyWljhQbbb0cPipard YcD2X9u3viklK9acqs/PnBrZieNDmM0mdYZPIfgfZhMDTT0YQcjZAb2oZ6tQ3h0RPw/e O+hDix9f/Day0emBa2THBURHzhhb39bhR73NRbgD1HGFE1mh9GcvOssBVVEId24mz+lC JKZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:dkim-signature; bh=QhgQbZWu2ePNiL3kMffzc1g5XrP31lL0xDbJldxuiGY=; b=qgUythYZAEj7QfHbnbT8GXa4jWcC+vc60bsYe8WZosypfw1MZArhHLC3c9gSDw9K62 rnyhljkRsVo3afRULJHcSPSrypHJmXA8iDJmthb7j8y3DFMF3vCePQ3Ch/LLoayDZWIc M5YJwI+RvS5HqBeCAnBSRKGiaAV8tGuWwu71eTR0M0V7z4Stpz4khNI6TOSErZZ3XUrI ZlffPJwBuzCTX57PQmGwgdjQj9J+w/TSoFr941piBlI5OWuno7RVBEuQRbII4D8tvep5 THKVb+H4oow7VSVu2kEVaOQgzLeHOjEb5Z5YSVXVypZ/tHAscbE/3ppHC7HabQAnK5eZ tTig== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="M4t2nL/L"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b22-20020a1709065e5600b006ff119c8837si509641eju.420.2022.06.03.11.11.39; Fri, 03 Jun 2022 11:12:14 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20210112 header.b="M4t2nL/L"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234280AbiFBLhI (ORCPT + 99 others); Thu, 2 Jun 2022 07:37:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52840 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232241AbiFBLhE (ORCPT ); Thu, 2 Jun 2022 07:37:04 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5757B3DDDD; Thu, 2 Jun 2022 04:37:01 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id i10so7416434lfj.0; Thu, 02 Jun 2022 04:37:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:in-reply-to:references:date:message-id :mime-version; bh=QhgQbZWu2ePNiL3kMffzc1g5XrP31lL0xDbJldxuiGY=; b=M4t2nL/LCOWMr0V/YY9BBpnfhddK4t6Gl1lkZJ+TkHO6s8enHiaddn/RhaCwpPgXiO gdiwCkA8W4vD2BkM8rqL3V0/W91hvX337zO9s8lmkdd4tUz49tR+VscPfDTYzjYDUzD0 4aFmSb09d0uc8VwlyarQXo5N5UGpwSZLGPrMFrsHxVu97bNsTOyQhn55ZQjSpj4ZpBsO jYwqu9Dv0EskGdBCnAoMb3Kcukj6xFOCpcC4NskgBOsvGsADKkq6Q7JORcV8Y5C/V9mO jtpMCsFqlY7p8EtQ4fjBG4TU7GITmsmPe8m61t+CyMBcf4gURvxtPWMcWchk0nl3BzRF oRGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:in-reply-to:references:date :message-id:mime-version; bh=QhgQbZWu2ePNiL3kMffzc1g5XrP31lL0xDbJldxuiGY=; b=jsrCaZIFB44XbcLjb0/X4AxGNT0LOBW90G37o6ghQExBP5OuIiXmroT0ZJUTDIWWKs sQyo4ewVuMeLWHrGZncr7fqsO5Lc2W7+yY58p8mC4mZq1mijF0BjbgDg9A1h3DHMlWBD vZC7Al8LTAxXx/BC1LIo53F8psoDoTXAWzTZ+lLaAzLUEmJZ2fBjt+YKrQ0nOYL0OlmC 10AABxmWLTSOEP3gtMUiKv7ioWmSsMmm7H1CI8Ot2aFgp81APJxGeCPueCWOxDIodDZy AdFdQENO17vbuvRCoJM0oP0jsHdKXKemoqdjLr94V96u+ZAz+fTmZEE6DmRc7BmSB7yh NpLQ== X-Gm-Message-State: AOAM533CLmSa57CdkNnKBwBNwZoISZ99heYyesIWzCK5N0ksBGSqvzBe 2/wZHYryg2mEJBTLMAexkLIhTPprtFv/jQ== X-Received: by 2002:a05:6512:3c93:b0:44b:4ba:c334 with SMTP id h19-20020a0565123c9300b0044b04bac334mr3300232lfv.27.1654169819579; Thu, 02 Jun 2022 04:36:59 -0700 (PDT) Received: from wse-c0127 ([208.127.141.28]) by smtp.gmail.com with ESMTPSA id h12-20020ac25d6c000000b004740f2bb4d5sm978972lft.258.2022.06.02.04.36.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jun 2022 04:36:59 -0700 (PDT) From: Hans Schultz X-Google-Original-From: Hans Schultz To: Ido Schimmel , Nikolay Aleksandrov Cc: Hans Schultz , Ido Schimmel , davem@davemloft.net, kuba@kernel.org, netdev@vger.kernel.org, Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , Eric Dumazet , Paolo Abeni , Jiri Pirko , Ivan Vecera , Roopa Prabhu , Shuah Khan , Daniel Borkmann , linux-kernel@vger.kernel.org, bridge@lists.linux-foundation.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH V3 net-next 1/4] net: bridge: add fdb flag to extent locked port feature In-Reply-To: References: <20220524152144.40527-2-schultz.hans+netdev@gmail.com> <86sfov2w8k.fsf@gmail.com> <86sfoqgi5e.fsf@gmail.com> <86y1yfzap3.fsf@gmail.com> <86sfonjroi.fsf@gmail.com> <3d93d46d-c484-da0a-c12c-80e83eba31c9@blackwall.org> Date: Thu, 02 Jun 2022 13:36:56 +0200 Message-ID: <86pmjrjnzb.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On tor, jun 02, 2022 at 13:39, Ido Schimmel wrote: > On Thu, Jun 02, 2022 at 01:30:06PM +0300, Nikolay Aleksandrov wrote: >> On 02/06/2022 13:17, Hans Schultz wrote: >> > On tor, jun 02, 2022 at 12:33, Nikolay Aleksandrov wrote: >> >> On 02/06/2022 12:17, Hans Schultz wrote: >> >>> On tis, maj 31, 2022 at 17:23, Ido Schimmel wrote: >> >>>> On Tue, May 31, 2022 at 11:34:21AM +0200, Hans Schultz wrote: >> > >> >>> Another issue is that >> >>> bridge fdb add MAC dev DEV master static >> >>> seems to add the entry with the SELF flag set, which I don't think is >> >>> what we would want it to do or? >> >> >> >> I don't see such thing (hacked iproute2 to print the flags before cmd): >> >> $ bridge fdb add 00:11:22:33:44:55 dev vnet110 master static >> >> flags 0x4 >> >> >> >> 0x4 = NTF_MASTER only >> >> >> > >> > I also get 0x4 from iproute2, but I still get SELF entries when I look >> > with: >> > bridge fdb show dev DEV >> > >> >> after the above add: >> $ bridge fdb show dev vnet110 | grep 00:11 >> 00:11:22:33:44:55 master virbr0 static > > I think Hans is testing with mv88e6xxx which dumps entries directly from > HW via ndo_fdb_dump(). See dsa_slave_port_fdb_do_dump() which sets > NTF_SELF. > > Hans, are you seeing the entry twice? Once with 'master' and once with > 'self'? > Well yes, but I get some additional entries with 'self' for different vlans. So from clean adding a random fdb entry I get 4 entries on the port, 2 with 'master' and two with 'self'. It looks like this: # bridge fdb add 00:22:33:44:55:66 dev eth6 master static # bridge fdb show dev eth6 | grep 55 00:22:33:44:55:66 vlan 1 master br0 offload static 00:22:33:44:55:66 master br0 offload static 00:22:33:44:55:66 vlan 1 self static 00:22:33:44:55:66 vlan 4095 self static If I do a replace of a locked entry I only get one with the 'self' flag.