Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Message-ID: <de31731a-5cb5-ece1-6b7f-895d9c04fa95@gmail.com>
Date:   Fri, 3 Jun 2022 14:35:51 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.9.1
Subject: Re: [PATCH V14 03/24] Documentation: LoongArch: Add basic
 documentations
Content-Language: en-US
To:     Huacai Chen <chenhuacai@gmail.com>
Cc:     Huacai Chen <chenhuacai@loongson.cn>,
        Arnd Bergmann <arnd@arndb.de>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Airlie <airlied@linux.ie>,
        Jonathan Corbet <corbet@lwn.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-arch <linux-arch@vger.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Xuefeng Li <lixuefeng@loongson.cn>,
        Yanteng Si <siyanteng@loongson.cn>,
        Guo Ren <guoren@kernel.org>, Xuerui Wang <kernel@xen0n.name>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        WANG Xuerui <git@xen0n.name>
References: <20220602115141.3962749-1-chenhuacai@loongson.cn>
 <20220602115141.3962749-4-chenhuacai@loongson.cn>
 <YplnruNz++gABlU0@debian.me>
 <CAAhV-H5Hi_gYvrO6DAGGA=OVExunCubNpDBdkRBxFxiP1APAKw@mail.gmail.com>
From:   Bagas Sanjaya <bagasdotme@gmail.com>
In-Reply-To: <CAAhV-H5Hi_gYvrO6DAGGA=OVExunCubNpDBdkRBxFxiP1APAKw@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 6/3/22 12:27, Huacai Chen wrote:
> Thank you for your testing. In my environment (sphinx_2.4.4), with or
> without the border both have no warnings. :)
> And I think these are more pretty if we keep the border, especially
> when formatted into PDF. How do you think?
> 

I think what you mean is reST table border, right?

By comparison, in Documentation/arm/booting.rst, there is a diagram
in "Setup the kernel tagged list". The diagram is written just inside
the literal code block and works fine, albeit the code block
spans fully. The diagram is small, however.

Otherwise, I see unequal padding in rendered IRQ diagrams. If I
remember correctly, the bottom and left padding are larger than top
and right padding. IDK why.

So please apply my suggestion diff.

Thanks.

-- 
An old man doll... just what I always wanted! - Clara