Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20;
Date:   Fri, 3 Jun 2022 16:01:43 +0200
From:   "Jason A. Donenfeld" <Jason@zx2c4.com>
To:     Arnd Bergmann <arnd@arndb.de>
Cc:     Huacai Chen <chenhuacai@loongson.cn>,
        Andy Lutomirski <luto@kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Peter Zijlstra <peterz@infradead.org>,
        Andrew Morton <akpm@linux-foundation.org>,
        David Airlie <airlied@linux.ie>,
        Jonathan Corbet <corbet@lwn.net>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-arch <linux-arch@vger.kernel.org>,
        "open list:DOCUMENTATION" <linux-doc@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Xuefeng Li <lixuefeng@loongson.cn>,
        Yanteng Si <siyanteng@loongson.cn>,
        Huacai Chen <chenhuacai@gmail.com>,
        Guo Ren <guoren@kernel.org>, Xuerui Wang <kernel@xen0n.name>,
        Jiaxun Yang <jiaxun.yang@flygoat.com>,
        Stephen Rothwell <sfr@canb.auug.org.au>,
        WANG Xuerui <git@xen0n.name>
Subject: Re: [PATCH V15 10/24] LoongArch: Add other common headers
Message-ID: <YpoURwkAbqRlr7Yi@zx2c4.com>
References: <20220603072053.35005-1-chenhuacai@loongson.cn>
 <20220603072053.35005-11-chenhuacai@loongson.cn>
 <YpoPZjJ/Adfu3uH9@zx2c4.com>
 <CAK8P3a0iASLd768imA8pG32Cc2RsqG8-ZyN+Obcg+PksVj1FJg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <CAK8P3a0iASLd768imA8pG32Cc2RsqG8-ZyN+Obcg+PksVj1FJg@mail.gmail.com>
Precedence: bulk

Hi Arnd,

On Fri, Jun 03, 2022 at 03:55:27PM +0200, Arnd Bergmann wrote:
> On Fri, Jun 3, 2022 at 3:40 PM Jason A. Donenfeld <Jason@zx2c4.com> wrote:
> > On Fri, Jun 03, 2022 at 03:20:39PM +0800, Huacai Chen wrote:
> > > diff --git a/arch/loongarch/include/asm/timex.h b/arch/loongarch/include/asm/timex.h
> >
> > "Currently only used on SMP for scheduling" isn't quite correct. It's
> > also used by random_get_entropy(). And anything else that uses
> > get_cycles() for, e.g., benchmarking, might use it too.
> >
> > You wrote also, "we know that all SMP capable CPUs have cycle counters",
> > so if I gather from this statement that some !SMP CPUs don't have a
> > cycle counter, though some do. If that's a correct supposition, then
> > you may need to rewrite this file to be something like:
> 
> The file is based on the mips version that deals with a variety of
> implementations
> and has the same comment.
> 
> I assume the loongarch chips all behave the same way here, and won't need
> a special case for non-SMP.

Oh good. In that case, the code is fine and I suppose the comment could
just be removed.

Jason